Support subframe NavigationEntry ad-tagging for Back-To-Ad intervention [chromium/src : main]

0 views
Skip to first unread message

Yao Xiao (Gerrit)

unread,
Dec 15, 2025, 2:31:27 AM (yesterday) Dec 15
to Rakina Zata Amni, AyeAye, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kaan Icer, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, csharris...@chromium.org, dmurph+wat...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, npm+...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org, webap...@microsoft.com, yigu+...@chromium.org
Attention needed from Rakina Zata Amni

Yao Xiao voted and added 1 comment

Votes added by Yao Xiao

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Yao Xiao . resolved

rakina@: PTAL. Thanks!

Context: I am expanding `mojom::NavigationInitiatorActivationAndAdStatus` from 3 to 4 states. The existing enum structure was from your suggestion 3 years ago ([link](https://crrev.com/c/4017155/6..20/content/browser/renderer_host/render_frame_host_impl.h#b3881)) to avoid conceptual overlap with `RFHI::last_committed_common_params_has_user_gesture_`.

However, for the new work, I now need the "from ad" signal even when there is no transient user activation.

Not sure if this changes your preference between keeping the enum structure or switching to two booleans. But since the enum is already established, I am leaning towards retaining it to minimize the churn of updating function signatures across the stack.

Open in Gerrit

Related details

Attention is currently required from:
  • Rakina Zata Amni
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I82347f5c629a2287ef44a64c13ba08acd011e4b0
Gerrit-Change-Number: 7257976
Gerrit-PatchSet: 7
Gerrit-Owner: Yao Xiao <yao...@chromium.org>
Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
Gerrit-Comment-Date: Mon, 15 Dec 2025 07:31:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rakina Zata Amni (Gerrit)

unread,
Dec 15, 2025, 9:18:55 PM (yesterday) Dec 15
to Yao Xiao, AyeAye, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kaan Icer, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, csharris...@chromium.org, dmurph+wat...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, npm+...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org, webap...@microsoft.com, yigu+...@chromium.org
Attention needed from Yao Xiao

Rakina Zata Amni voted and added 2 comments

Votes added by Rakina Zata Amni

Code-Review+1

2 comments

Patchset-level comments
Yao Xiao . resolved

rakina@: PTAL. Thanks!

Context: I am expanding `mojom::NavigationInitiatorActivationAndAdStatus` from 3 to 4 states. The existing enum structure was from your suggestion 3 years ago ([link](https://crrev.com/c/4017155/6..20/content/browser/renderer_host/render_frame_host_impl.h#b3881)) to avoid conceptual overlap with `RFHI::last_committed_common_params_has_user_gesture_`.

However, for the new work, I now need the "from ad" signal even when there is no transient user activation.

Not sure if this changes your preference between keeping the enum structure or switching to two booleans. But since the enum is already established, I am leaning towards retaining it to minimize the churn of updating function signatures across the stack.

Rakina Zata Amni

Thanks for giving the context! I think things haven't changed around the clarity of user gesture filtering since then, so this seems OK to me.

Rakina Zata Amni . resolved

LGTM, thanks

Open in Gerrit

Related details

Attention is currently required from:
  • Yao Xiao
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I82347f5c629a2287ef44a64c13ba08acd011e4b0
    Gerrit-Change-Number: 7257976
    Gerrit-PatchSet: 7
    Gerrit-Owner: Yao Xiao <yao...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-Attention: Yao Xiao <yao...@chromium.org>
    Gerrit-Comment-Date: Tue, 16 Dec 2025 02:18:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Yao Xiao <yao...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Yao Xiao (Gerrit)

    unread,
    Dec 15, 2025, 9:40:34 PM (yesterday) Dec 15
    to Daniel Cheng, Josh Karlin, Rakina Zata Amni, AyeAye, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kaan Icer, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, csharris...@chromium.org, dmurph+wat...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, npm+...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org, webap...@microsoft.com, yigu+...@chromium.org
    Attention needed from Daniel Cheng and Josh Karlin

    Yao Xiao added 1 comment

    Patchset-level comments
    Yao Xiao . resolved

    dcheng@: PTAL at navigation_policy.cc and mojom changes. Thanks!
    jkarlin@: PTAL at *page_load_metrics* and *subresource_filter* changes. Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    • Josh Karlin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I82347f5c629a2287ef44a64c13ba08acd011e4b0
    Gerrit-Change-Number: 7257976
    Gerrit-PatchSet: 7
    Gerrit-Owner: Yao Xiao <yao...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Josh Karlin <jka...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-Attention: Josh Karlin <jka...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Tue, 16 Dec 2025 02:40:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    2:00 AM (20 hours ago) 2:00 AM
    to Yao Xiao, Daniel Cheng, Josh Karlin, Rakina Zata Amni, AyeAye, Chromium LUCI CQ, Christian Biesinger, chromium...@chromium.org, Kaan Icer, alexmo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, csharris...@chromium.org, dmurph+wat...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, npm+...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, subresource-f...@chromium.org, webap...@microsoft.com, yigu+...@chromium.org
    Attention needed from Josh Karlin and Yao Xiao

    Daniel Cheng voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Josh Karlin
    • Yao Xiao
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I82347f5c629a2287ef44a64c13ba08acd011e4b0
    Gerrit-Change-Number: 7257976
    Gerrit-PatchSet: 7
    Gerrit-Owner: Yao Xiao <yao...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Josh Karlin <jka...@chromium.org>
    Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
    Gerrit-Reviewer: Yao Xiao <yao...@chromium.org>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-Attention: Yao Xiao <yao...@chromium.org>
    Gerrit-Attention: Josh Karlin <jka...@chromium.org>
    Gerrit-Comment-Date: Tue, 16 Dec 2025 07:00:13 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages