Replaced chrome::kIsolatedAppScheme with webapps::kIsolatedAppScheme for chrome/browser/ [chromium/src : main]

0 views
Skip to first unread message

Simon Hangl (Gerrit)

unread,
Sep 12, 2025, 6:00:21 AM (6 days ago) Sep 12
to Bhaskar Sharma, Olga Korokhina, Vlad Krot, Andrew Rayskiy, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, speed-metr...@chromium.org, speed-metrics...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, devtools...@chromium.org, browser-comp...@chromium.org, rmcelra...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, chromeos-kio...@google.com, mgiuca...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, philli...@chromium.org, chromium-a...@chromium.org, byronle...@chromium.org, chungshe...@google.com, dennyh...@google.com, oshima...@chromium.org, menghua...@google.com, weiluanw...@google.com, extension...@chromium.org
Attention needed from Bhaskar Sharma, Olga Korokhina and Vlad Krot

Simon Hangl voted and added 1 comment

Votes added by Simon Hangl

Code-Review+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Bhaskar Sharma
  • Olga Korokhina
  • Vlad Krot
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iae80a2b7d9f0a6781e1ba666cd7f30dcca053ecd
Gerrit-Change-Number: 6935333
Gerrit-PatchSet: 29
Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
Gerrit-Reviewer: Olga Korokhina <koro...@google.com>
Gerrit-Reviewer: Simon Hangl <sim...@google.com>
Gerrit-Reviewer: Vlad Krot <vk...@google.com>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-Attention: Vlad Krot <vk...@google.com>
Gerrit-Attention: Olga Korokhina <koro...@google.com>
Gerrit-Attention: Bhaskar Sharma <bhaska...@google.com>
Gerrit-Comment-Date: Fri, 12 Sep 2025 10:00:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Olga Korokhina (Gerrit)

unread,
Sep 12, 2025, 6:16:48 AM (6 days ago) Sep 12
to Bhaskar Sharma, Simon Hangl, Vlad Krot, Andrew Rayskiy, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, speed-metr...@chromium.org, speed-metrics...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, devtools...@chromium.org, browser-comp...@chromium.org, rmcelra...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, chromeos-kio...@google.com, mgiuca...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, philli...@chromium.org, chromium-a...@chromium.org, byronle...@chromium.org, chungshe...@google.com, dennyh...@google.com, oshima...@chromium.org, menghua...@google.com, weiluanw...@google.com, extension...@chromium.org
Attention needed from Bhaskar Sharma and Vlad Krot

Olga Korokhina voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Bhaskar Sharma
  • Vlad Krot
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iae80a2b7d9f0a6781e1ba666cd7f30dcca053ecd
    Gerrit-Change-Number: 6935333
    Gerrit-PatchSet: 29
    Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
    Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
    Gerrit-Reviewer: Olga Korokhina <koro...@google.com>
    Gerrit-Reviewer: Simon Hangl <sim...@google.com>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-Attention: Bhaskar Sharma <bhaska...@google.com>
    Gerrit-Attention: Vlad Krot <vk...@google.com>
    Gerrit-Comment-Date: Fri, 12 Sep 2025 10:16:30 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Rayskiy (Gerrit)

    unread,
    Sep 15, 2025, 6:30:31 AM (3 days ago) Sep 15
    to Bhaskar Sharma, Kyle Horimoto, Olga Korokhina, Simon Hangl, Vlad Krot, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, speed-metr...@chromium.org, speed-metrics...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, devtools...@chromium.org, browser-comp...@chromium.org, rmcelra...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, chromeos-kio...@google.com, mgiuca...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, philli...@chromium.org, chromium-a...@chromium.org, byronle...@chromium.org, chungshe...@google.com, dennyh...@google.com, oshima...@chromium.org, menghua...@google.com, weiluanw...@google.com, extension...@chromium.org
    Attention needed from Bhaskar Sharma, Kyle Horimoto, Olga Korokhina, Simon Hangl and Vlad Krot

    Andrew Rayskiy voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Bhaskar Sharma
    • Kyle Horimoto
    • Olga Korokhina
    • Simon Hangl
    • Vlad Krot
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Iae80a2b7d9f0a6781e1ba666cd7f30dcca053ecd
      Gerrit-Change-Number: 6935333
      Gerrit-PatchSet: 33
      Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
      Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
      Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
      Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
      Gerrit-Reviewer: Olga Korokhina <koro...@google.com>
      Gerrit-Reviewer: Simon Hangl <sim...@google.com>
      Gerrit-Reviewer: Vlad Krot <vk...@google.com>
      Gerrit-Attention: Bhaskar Sharma <bhaska...@google.com>
      Gerrit-Attention: Kyle Horimoto <khor...@chromium.org>
      Gerrit-Attention: Simon Hangl <sim...@google.com>
      Gerrit-Attention: Olga Korokhina <koro...@google.com>
      Gerrit-Attention: Vlad Krot <vk...@google.com>
      Gerrit-Comment-Date: Mon, 15 Sep 2025 10:30:15 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Vlad Krot (Gerrit)

      unread,
      Sep 15, 2025, 6:47:42 AM (3 days ago) Sep 15
      to Bhaskar Sharma, Andrew Rayskiy, Kyle Horimoto, Olga Korokhina, Simon Hangl, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, speed-metr...@chromium.org, speed-metrics...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, devtools...@chromium.org, browser-comp...@chromium.org, rmcelra...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, chromeos-kio...@google.com, mgiuca...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, philli...@chromium.org, chromium-a...@chromium.org, byronle...@chromium.org, chungshe...@google.com, dennyh...@google.com, oshima...@chromium.org, menghua...@google.com, weiluanw...@google.com, extension...@chromium.org
      Attention needed from Bhaskar Sharma, Kyle Horimoto, Olga Korokhina and Simon Hangl

      Vlad Krot added 1 comment

      Commit Message
      Line 16, Patchset 33 (Latest):for Android/iOS.
      Vlad Krot . unresolved

      I get why we can bypass tests, because it is a large scale refactor and a trivial change. The part about `thus that is not compiled or tested
      for Android/iOS.` is not clear to me, how is it relevant

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Bhaskar Sharma
      • Kyle Horimoto
      • Olga Korokhina
      • Simon Hangl
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Iae80a2b7d9f0a6781e1ba666cd7f30dcca053ecd
        Gerrit-Change-Number: 6935333
        Gerrit-PatchSet: 33
        Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
        Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
        Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
        Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
        Gerrit-Reviewer: Olga Korokhina <koro...@google.com>
        Gerrit-Reviewer: Simon Hangl <sim...@google.com>
        Gerrit-Reviewer: Vlad Krot <vk...@google.com>
        Gerrit-Attention: Bhaskar Sharma <bhaska...@google.com>
        Gerrit-Attention: Kyle Horimoto <khor...@chromium.org>
        Gerrit-Attention: Simon Hangl <sim...@google.com>
        Gerrit-Attention: Olga Korokhina <koro...@google.com>
        Gerrit-Comment-Date: Mon, 15 Sep 2025 10:47:27 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Simon Hangl (Gerrit)

        unread,
        Sep 15, 2025, 7:05:07 AM (3 days ago) Sep 15
        to Bhaskar Sharma, Andrew Rayskiy, Kyle Horimoto, Olga Korokhina, Vlad Krot, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, speed-metr...@chromium.org, speed-metrics...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, devtools...@chromium.org, browser-comp...@chromium.org, rmcelra...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, chromeos-kio...@google.com, mgiuca...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, philli...@chromium.org, chromium-a...@chromium.org, byronle...@chromium.org, chungshe...@google.com, dennyh...@google.com, oshima...@chromium.org, menghua...@google.com, weiluanw...@google.com, extension...@chromium.org
        Attention needed from Bhaskar Sharma, Kyle Horimoto and Olga Korokhina

        Simon Hangl voted and added 1 comment

        Votes added by Simon Hangl

        Code-Review+1

        1 comment

        Patchset-level comments
        Simon Hangl . resolved

        LGTM

        Related details

        Attention is currently required from:
        • Bhaskar Sharma
        • Kyle Horimoto
        • Olga Korokhina
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Iae80a2b7d9f0a6781e1ba666cd7f30dcca053ecd
          Gerrit-Change-Number: 6935333
          Gerrit-PatchSet: 33
          Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
          Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
          Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
          Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
          Gerrit-Reviewer: Olga Korokhina <koro...@google.com>
          Gerrit-Reviewer: Simon Hangl <sim...@google.com>
          Gerrit-Reviewer: Vlad Krot <vk...@google.com>
          Gerrit-Attention: Bhaskar Sharma <bhaska...@google.com>
          Gerrit-Attention: Kyle Horimoto <khor...@chromium.org>
          Gerrit-Attention: Olga Korokhina <koro...@google.com>
          Gerrit-Comment-Date: Mon, 15 Sep 2025 11:04:49 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: Yes
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Bhaskar Sharma (Gerrit)

          unread,
          Sep 15, 2025, 9:15:35 AM (3 days ago) Sep 15
          to Simon Hangl, Andrew Rayskiy, Kyle Horimoto, Olga Korokhina, Vlad Krot, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, speed-metr...@chromium.org, speed-metrics...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, devtools...@chromium.org, browser-comp...@chromium.org, rmcelra...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, chromeos-kio...@google.com, mgiuca...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, philli...@chromium.org, chromium-a...@chromium.org, byronle...@chromium.org, chungshe...@google.com, dennyh...@google.com, oshima...@chromium.org, menghua...@google.com, weiluanw...@google.com, extension...@chromium.org
          Attention needed from Andrew Rayskiy, Kyle Horimoto, Olga Korokhina, Simon Hangl and Vlad Krot

          Bhaskar Sharma voted and added 1 comment

          Votes added by Bhaskar Sharma

          Commit-Queue+1

          1 comment

          Commit Message
          Line 16, Patchset 33:for Android/iOS.
          Vlad Krot . resolved

          I get why we can bypass tests, because it is a large scale refactor and a trivial change. The part about `thus that is not compiled or tested
          for Android/iOS.` is not clear to me, how is it relevant

          Bhaskar Sharma

          Done

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Andrew Rayskiy
          • Kyle Horimoto
          • Olga Korokhina
          • Simon Hangl
          • Vlad Krot
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement is not satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Iae80a2b7d9f0a6781e1ba666cd7f30dcca053ecd
            Gerrit-Change-Number: 6935333
            Gerrit-PatchSet: 35
            Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
            Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
            Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
            Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
            Gerrit-Reviewer: Olga Korokhina <koro...@google.com>
            Gerrit-Reviewer: Simon Hangl <sim...@google.com>
            Gerrit-Reviewer: Vlad Krot <vk...@google.com>
            Gerrit-Attention: Simon Hangl <sim...@google.com>
            Gerrit-Attention: Kyle Horimoto <khor...@chromium.org>
            Gerrit-Attention: Andrew Rayskiy <green...@google.com>
            Gerrit-Attention: Olga Korokhina <koro...@google.com>
            Gerrit-Attention: Vlad Krot <vk...@google.com>
            Gerrit-Comment-Date: Mon, 15 Sep 2025 13:15:17 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            Comment-In-Reply-To: Vlad Krot <vk...@google.com>
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Vlad Krot (Gerrit)

            unread,
            Sep 15, 2025, 9:23:12 AM (3 days ago) Sep 15
            to Bhaskar Sharma, Simon Hangl, Andrew Rayskiy, Kyle Horimoto, Olga Korokhina, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, speed-metr...@chromium.org, speed-metrics...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, devtools...@chromium.org, browser-comp...@chromium.org, rmcelra...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, chromeos-kio...@google.com, mgiuca...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, philli...@chromium.org, chromium-a...@chromium.org, byronle...@chromium.org, chungshe...@google.com, dennyh...@google.com, oshima...@chromium.org, menghua...@google.com, weiluanw...@google.com, extension...@chromium.org
            Attention needed from Andrew Rayskiy, Bhaskar Sharma, Kyle Horimoto, Olga Korokhina and Simon Hangl

            Vlad Krot voted Code-Review+1

            Code-Review+1
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Andrew Rayskiy
            • Bhaskar Sharma
            • Kyle Horimoto
            • Olga Korokhina
            • Simon Hangl
            Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement is not satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Iae80a2b7d9f0a6781e1ba666cd7f30dcca053ecd
            Gerrit-Change-Number: 6935333
            Gerrit-PatchSet: 35
            Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
            Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
            Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
            Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
            Gerrit-Reviewer: Olga Korokhina <koro...@google.com>
            Gerrit-Reviewer: Simon Hangl <sim...@google.com>
            Gerrit-Reviewer: Vlad Krot <vk...@google.com>
            Gerrit-Attention: Bhaskar Sharma <bhaska...@google.com>
            Gerrit-Attention: Simon Hangl <sim...@google.com>
            Gerrit-Attention: Kyle Horimoto <khor...@chromium.org>
            Gerrit-Attention: Andrew Rayskiy <green...@google.com>
            Gerrit-Attention: Olga Korokhina <koro...@google.com>
            Gerrit-Comment-Date: Mon, 15 Sep 2025 13:22:54 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Kyle Horimoto (Gerrit)

            unread,
            Sep 15, 2025, 11:09:39 AM (3 days ago) Sep 15
            to Bhaskar Sharma, Kyle Horimoto, Vlad Krot, Simon Hangl, Andrew Rayskiy, Olga Korokhina, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, speed-metr...@chromium.org, speed-metrics...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, devtools...@chromium.org, browser-comp...@chromium.org, rmcelra...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, chromeos-kio...@google.com, mgiuca...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, philli...@chromium.org, chromium-a...@chromium.org, byronle...@chromium.org, chungshe...@google.com, dennyh...@google.com, oshima...@chromium.org, menghua...@google.com, weiluanw...@google.com, extension...@chromium.org
            Attention needed from Andrew Rayskiy, Bhaskar Sharma, Olga Korokhina and Simon Hangl

            Kyle Horimoto voted Code-Review+1

            Code-Review+1
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Andrew Rayskiy
            • Bhaskar Sharma
            • Olga Korokhina
            • Simon Hangl
            Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement satisfiedCode-Review
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Iae80a2b7d9f0a6781e1ba666cd7f30dcca053ecd
            Gerrit-Change-Number: 6935333
            Gerrit-PatchSet: 35
            Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
            Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
            Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
            Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
            Gerrit-Reviewer: Olga Korokhina <koro...@google.com>
            Gerrit-Reviewer: Simon Hangl <sim...@google.com>
            Gerrit-Reviewer: Vlad Krot <vk...@google.com>
            Gerrit-Attention: Bhaskar Sharma <bhaska...@google.com>
            Gerrit-Attention: Simon Hangl <sim...@google.com>
            Gerrit-Attention: Andrew Rayskiy <green...@google.com>
            Gerrit-Attention: Olga Korokhina <koro...@google.com>
            Gerrit-Comment-Date: Mon, 15 Sep 2025 15:09:24 +0000
            Gerrit-HasComments: No
            Gerrit-Has-Labels: Yes
            satisfied_requirement
            open
            diffy

            Simon Hangl (Gerrit)

            unread,
            Sep 15, 2025, 11:44:28 AM (3 days ago) Sep 15
            to Bhaskar Sharma, Kyle Horimoto, Vlad Krot, Andrew Rayskiy, Olga Korokhina, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, speed-metr...@chromium.org, speed-metrics...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, devtools...@chromium.org, browser-comp...@chromium.org, rmcelra...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, chromeos-kio...@google.com, mgiuca...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, philli...@chromium.org, chromium-a...@chromium.org, byronle...@chromium.org, chungshe...@google.com, dennyh...@google.com, oshima...@chromium.org, menghua...@google.com, weiluanw...@google.com, extension...@chromium.org
            Attention needed from Andrew Rayskiy, Bhaskar Sharma, Kyle Horimoto, Olga Korokhina and Vlad Krot

            Simon Hangl voted and added 1 comment

            Votes added by Simon Hangl

            Code-Review+1

            1 comment

            Patchset-level comments
            Simon Hangl . resolved

            LGTM

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Andrew Rayskiy
            • Bhaskar Sharma
            • Kyle Horimoto
            • Olga Korokhina
            • Vlad Krot
            Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement satisfiedCode-Owners
              • requirement is not satisfiedCode-Review
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: Iae80a2b7d9f0a6781e1ba666cd7f30dcca053ecd
              Gerrit-Change-Number: 6935333
              Gerrit-PatchSet: 36
              Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
              Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
              Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
              Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
              Gerrit-Reviewer: Olga Korokhina <koro...@google.com>
              Gerrit-Reviewer: Simon Hangl <sim...@google.com>
              Gerrit-Reviewer: Vlad Krot <vk...@google.com>
              Gerrit-Attention: Vlad Krot <vk...@google.com>
              Gerrit-Attention: Andrew Rayskiy <green...@google.com>
              Gerrit-Attention: Olga Korokhina <koro...@google.com>
              Gerrit-Attention: Kyle Horimoto <khor...@chromium.org>
              Gerrit-Attention: Bhaskar Sharma <bhaska...@google.com>
              Gerrit-Comment-Date: Mon, 15 Sep 2025 15:44:11 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              unsatisfied_requirement
              open
              diffy

              Olga Korokhina (Gerrit)

              unread,
              Sep 16, 2025, 6:27:06 AM (2 days ago) Sep 16
              to Bhaskar Sharma, Simon Hangl, Kyle Horimoto, Vlad Krot, Andrew Rayskiy, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, speed-metr...@chromium.org, speed-metrics...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, devtools...@chromium.org, browser-comp...@chromium.org, rmcelra...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, chromeos-kio...@google.com, mgiuca...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, philli...@chromium.org, chromium-a...@chromium.org, byronle...@chromium.org, chungshe...@google.com, dennyh...@google.com, oshima...@chromium.org, menghua...@google.com, weiluanw...@google.com, extension...@chromium.org
              Attention needed from Andrew Rayskiy, Bhaskar Sharma, Kyle Horimoto and Vlad Krot

              Olga Korokhina voted Code-Review+1

              Code-Review+1
              Open in Gerrit

              Related details

              Attention is currently required from:
              • Andrew Rayskiy
              • Bhaskar Sharma
              • Kyle Horimoto
              • Vlad Krot
              Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement satisfiedCode-Owners
                • requirement satisfiedCode-Review
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: Iae80a2b7d9f0a6781e1ba666cd7f30dcca053ecd
                Gerrit-Change-Number: 6935333
                Gerrit-PatchSet: 36
                Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
                Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
                Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
                Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
                Gerrit-Reviewer: Olga Korokhina <koro...@google.com>
                Gerrit-Reviewer: Simon Hangl <sim...@google.com>
                Gerrit-Reviewer: Vlad Krot <vk...@google.com>
                Gerrit-Attention: Vlad Krot <vk...@google.com>
                Gerrit-Attention: Andrew Rayskiy <green...@google.com>
                Gerrit-Attention: Kyle Horimoto <khor...@chromium.org>
                Gerrit-Attention: Bhaskar Sharma <bhaska...@google.com>
                Gerrit-Comment-Date: Tue, 16 Sep 2025 10:26:52 +0000
                Gerrit-HasComments: No
                Gerrit-Has-Labels: Yes
                satisfied_requirement
                open
                diffy

                Chromium LUCI CQ (Gerrit)

                unread,
                Sep 16, 2025, 7:01:42 AM (2 days ago) Sep 16
                to Bhaskar Sharma, Olga Korokhina, Simon Hangl, Kyle Horimoto, Vlad Krot, Andrew Rayskiy, AyeAye, chromium...@chromium.org, speed-metr...@chromium.org, speed-metrics...@chromium.org, bmcquad...@chromium.org, loading-rev...@chromium.org, csharris...@chromium.org, devtools...@chromium.org, browser-comp...@chromium.org, rmcelra...@chromium.org, kuragin+web-ap...@chromium.org, dmurph+watc...@chromium.org, chromeos-kio...@google.com, mgiuca...@chromium.org, loyso...@chromium.org, dibyapal+wa...@chromium.org, zelin+watch-we...@chromium.org, webap...@microsoft.com, philli...@chromium.org, chromium-a...@chromium.org, byronle...@chromium.org, chungshe...@google.com, dennyh...@google.com, oshima...@chromium.org, menghua...@google.com, weiluanw...@google.com, extension...@chromium.org

                Chromium LUCI CQ submitted the change

                Change information

                Commit message:
                Replaced chrome::kIsolatedAppScheme with webapps::kIsolatedAppScheme for chrome/browser/

                Usage of chrome::kIsolatedWebScheme has been replaced by
                webapps:kIsolatedWebScheme for chrome/browser folder. Necessary BUILD
                files and DEPS file have been updated.

                Low-Coverage-Reason: LARGE_SCALE_REFACTOR
                Bug: 442531738
                Change-Id: Iae80a2b7d9f0a6781e1ba666cd7f30dcca053ecd
                Reviewed-by: Olga Korokhina <koro...@google.com>
                Commit-Queue: Bhaskar Sharma <bhaska...@google.com>
                Reviewed-by: Simon Hangl <sim...@google.com>
                Cr-Commit-Position: refs/heads/main@{#1515953}
                Files:
                • M chrome/browser/BUILD.gn
                • M chrome/browser/ash/app_mode/isolated_web_app/kiosk_iwa_data_unittest.cc
                • M chrome/browser/ash/app_mode/test/kiosk_iwa_browsertest.cc
                • M chrome/browser/ash/app_mode/test/kiosk_iwa_device_attributes_browsertest.cc
                • M chrome/browser/ash/app_mode/test/kiosk_iwa_permissions_browsertest.cc
                • M chrome/browser/chrome_content_browser_client.cc
                • M chrome/browser/chromeos/extensions/telemetry/api/common/BUILD.gn
                • M chrome/browser/chromeos/extensions/telemetry/api/common/DEPS
                • M chrome/browser/chromeos/extensions/telemetry/api/common/util.cc
                • M chrome/browser/device_api/device_service_unittest.cc
                • M chrome/browser/devtools/BUILD.gn
                • M chrome/browser/devtools/protocol/devtools_iwa_browsertest.cc
                • M chrome/browser/devtools/protocol/pwa_handler.cc
                • M chrome/browser/direct_sockets/chrome_direct_sockets_delegate.cc
                • M chrome/browser/extensions/BUILD.gn
                • M chrome/browser/extensions/DEPS
                • M chrome/browser/extensions/api/tab_groups/BUILD.gn
                • M chrome/browser/extensions/api/tabs/tabs_api_non_android.cc
                • M chrome/browser/extensions/chrome_extensions_browser_client_non_android.cc
                • M chrome/browser/favicon/BUILD.gn
                • M chrome/browser/favicon/chrome_favicon_client.cc
                • M chrome/browser/page_load_metrics/page_load_metrics_initialize.cc
                • M chrome/browser/picture_in_picture/BUILD.gn
                • M chrome/browser/picture_in_picture/DEPS
                • M chrome/browser/picture_in_picture/picture_in_picture_window_manager.cc
                • M chrome/browser/profiles/profile_io_data.cc
                • M chrome/browser/renderer_context_menu/render_view_context_menu.cc
                • M chrome/browser/task_manager/BUILD.gn
                • M chrome/browser/task_manager/providers/web_contents/isolated_web_app_task.cc
                • M chrome/browser/task_manager/providers/web_contents/web_app_tag_browsertest.cc
                • M chrome/browser/ui/BUILD.gn
                • M chrome/browser/ui/chrome_pages.cc
                • M chrome/browser/ui/url_identity.cc
                • M chrome/browser/ui/url_identity_unittest.cc
                • M chrome/browser/ui/views/apps/app_dialog/app_uninstall_dialog_view.cc
                • M chrome/browser/ui/views/frame/picture_in_picture_browser_frame_view.cc
                • M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc
                • M chrome/browser/ui/webui/settings/site_settings_handler.cc
                • M chrome/browser/ui/webui/settings/site_settings_helper.cc
                • M chrome/browser/web_applications/BUILD.gn
                • M chrome/browser/web_applications/isolated_web_apps/signed_web_bundle_metadata_unittest.cc
                • M chrome/browser/web_applications/isolated_web_apps/window_management/window_management_content_setting_observer.cc
                • M chrome/browser/web_applications/web_app.cc
                • M chrome/browser/web_applications/web_app_registrar_unittest.cc
                • M chrome/browser/webapps/chrome_webapps_client.cc
                Change size: L
                Delta: 45 files changed, 295 insertions(+), 106 deletions(-)
                Branch: refs/heads/main
                Submit Requirements:
                • requirement satisfiedCode-Review: +1 by Simon Hangl, +1 by Olga Korokhina
                Open in Gerrit
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: merged
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: Iae80a2b7d9f0a6781e1ba666cd7f30dcca053ecd
                Gerrit-Change-Number: 6935333
                Gerrit-PatchSet: 37
                Gerrit-Owner: Bhaskar Sharma <bhaska...@google.com>
                Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
                Gerrit-Reviewer: Bhaskar Sharma <bhaska...@google.com>
                Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
                Gerrit-Reviewer: Kyle Horimoto <khor...@chromium.org>
                Gerrit-Reviewer: Olga Korokhina <koro...@google.com>
                Gerrit-Reviewer: Simon Hangl <sim...@google.com>
                Gerrit-Reviewer: Vlad Krot <vk...@google.com>
                open
                diffy
                satisfied_requirement
                Reply all
                Reply to author
                Forward
                0 new messages