Re-enable GWSAbandonedPageLoadMetricsObserver browser tests [chromium/src : main]
0 views
Skip to first unread message
Shunya Shishido (Gerrit)
Jun 10, 2026, 11:33:32 PM (8 hours ago) Jun 10
to Keita Suzuki, Yoshisato Yanagisawa, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Keita Suzuki and Yoshisato Yanagisawa
Shunya Shishido voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Keita Suzuki
- Yoshisato Yanagisawa
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoshisato Yanagisawa (Gerrit)
12:02 AM (7 hours ago) 12:02 AM
to Shunya Shishido, Keita Suzuki, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Keita Suzuki and Shunya Shishido
Yoshisato Yanagisawa voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Keita Suzuki
- Shunya Shishido
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shunya Shishido (Gerrit)
12:24 AM (7 hours ago) 12:24 AM
to Yoshisato Yanagisawa, Keita Suzuki, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Keita Suzuki
Shunya Shishido voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Keita Suzuki
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
12:27 AM (7 hours ago) 12:27 AM
to Shunya Shishido, Yoshisato Yanagisawa, Keita Suzuki, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, loading-rev...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Re-enable GWSAbandonedPageLoadMetricsObserver browser tests
With the recent default enablement of kThrottleSendingCustomUserTimings
on desktop platforms, performance.mark() IPC messages from the renderer
process are batched and throttled (sent every 100ms). Consequently,
relying on content::WaitForLoadStop() in these tests is insufficient.
This CL extends PageLoadMetricsTestWaiter to support synchronizing on
custom user timing marks (`AddCustomUserTimingMarkExpectation`). The
tests now explicitly wait for the final mark injected by the setup,
ensuring all preceding milestones are fully recorded before assertions
run.
Bug: 521907529
Change-Id: Ia5e4f5cddbd9b0540d289f7cebdf35d7eba0730f
Commit-Queue: Shunya Shishido <sisid...@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyana...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1645096}
Files:
- M chrome/browser/page_load_metrics/observers/gws_abandoned_page_load_metrics_observer_browsertest.cc
- M components/page_load_metrics/browser/page_load_metrics_test_waiter.cc
- M components/page_load_metrics/browser/page_load_metrics_test_waiter.h
Change size: M
Delta: 3 files changed, 60 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Yoshisato Yanagisawa
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages