Fix erroneous enum numbering in HtmlFastPathResult [chromium/src : main]

0 views
Skip to first unread message

Andrew Paseltiner (Gerrit)

unread,
Mar 11, 2026, 9:27:30 AM (2 days ago) Mar 11
to Mason Freed, Ian Clelland, Scott Violet, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Ian Clelland and Mason Freed

Andrew Paseltiner voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ian Clelland
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic0a64244ae556fbdc7f8b317f19a8aafcb3a82d3
Gerrit-Change-Number: 7657183
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Ian Clelland <icle...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Scott Violet <s...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Ian Clelland <icle...@chromium.org>
Gerrit-Comment-Date: Wed, 11 Mar 2026 13:27:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ian Clelland (Gerrit)

unread,
Mar 12, 2026, 9:31:19 AM (15 hours ago) Mar 12
to Andrew Paseltiner, Chromium LUCI CQ, Mason Freed, Scott Violet, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Andrew Paseltiner and Mason Freed

Ian Clelland added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ian Clelland . resolved

If 25 was previously used for *both* FailedMaxDepth and FailedBigText, then should we actually renumber both of them? Otherwise the histograms will show an unexplained drop in FailedMaxDepth when this lands

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Paseltiner
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic0a64244ae556fbdc7f8b317f19a8aafcb3a82d3
Gerrit-Change-Number: 7657183
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Ian Clelland <icle...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Scott Violet <s...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Comment-Date: Thu, 12 Mar 2026 13:31:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Ian Clelland (Gerrit)

unread,
Mar 12, 2026, 9:32:12 AM (15 hours ago) Mar 12
to Andrew Paseltiner, Chromium LUCI CQ, Mason Freed, Scott Violet, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Andrew Paseltiner and Mason Freed

Ian Clelland added 1 comment

Patchset-level comments
Ian Clelland . unresolved

If 25 was previously used for *both* FailedMaxDepth and FailedBigText, then should we actually renumber both of them? Otherwise the histograms will show an unexplained drop in FailedMaxDepth when this lands

Ian Clelland

[responding just to reset the 'resolved' bit]

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Paseltiner
  • Mason Freed
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic0a64244ae556fbdc7f8b317f19a8aafcb3a82d3
    Gerrit-Change-Number: 7657183
    Gerrit-PatchSet: 1
    Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Ian Clelland <icle...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Scott Violet <s...@chromium.org>
    Gerrit-Attention: Mason Freed <mas...@chromium.org>
    Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Comment-Date: Thu, 12 Mar 2026 13:32:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Ian Clelland <icle...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Paseltiner (Gerrit)

    unread,
    Mar 12, 2026, 9:33:26 AM (15 hours ago) Mar 12
    to Chromium LUCI CQ, Mason Freed, Ian Clelland, Scott Violet, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
    Attention needed from Ian Clelland and Mason Freed

    Andrew Paseltiner added 1 comment

    Patchset-level comments
    Ian Clelland . unresolved

    If 25 was previously used for *both* FailedMaxDepth and FailedBigText, then should we actually renumber both of them? Otherwise the histograms will show an unexplained drop in FailedMaxDepth when this lands

    Andrew Paseltiner

    Sure, we can do that, though there's going to be an unexplained discontinuity regardless. Do we want to bump the histogram version as well? I defer to the code owners here on their preferred solution.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian Clelland
    • Mason Freed
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic0a64244ae556fbdc7f8b317f19a8aafcb3a82d3
    Gerrit-Change-Number: 7657183
    Gerrit-PatchSet: 1
    Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Ian Clelland <icle...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Scott Violet <s...@chromium.org>
    Gerrit-Attention: Mason Freed <mas...@chromium.org>
    Gerrit-Attention: Ian Clelland <icle...@chromium.org>
    Gerrit-Comment-Date: Thu, 12 Mar 2026 13:33:20 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Paseltiner (Gerrit)

    unread,
    Mar 12, 2026, 11:15:24 AM (13 hours ago) Mar 12
    to Chromium LUCI CQ, Mason Freed, Ian Clelland, Scott Violet, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
    Attention needed from Ian Clelland and Mason Freed

    Andrew Paseltiner voted and added 1 comment

    Votes added by Andrew Paseltiner

    Commit-Queue+1

    1 comment

    Patchset-level comments
    Ian Clelland . unresolved

    If 25 was previously used for *both* FailedMaxDepth and FailedBigText, then should we actually renumber both of them? Otherwise the histograms will show an unexplained drop in FailedMaxDepth when this lands

    Andrew Paseltiner

    Sure, we can do that, though there's going to be an unexplained discontinuity regardless. Do we want to bump the histogram version as well? I defer to the code owners here on their preferred solution.

    Andrew Paseltiner

    Re-numbered `kFailedMaxDepth` as well. Waiting for a determination on bumping the metric itself.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ian Clelland
    • Mason Freed
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic0a64244ae556fbdc7f8b317f19a8aafcb3a82d3
    Gerrit-Change-Number: 7657183
    Gerrit-PatchSet: 4
    Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Ian Clelland <icle...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Scott Violet <s...@chromium.org>
    Gerrit-Attention: Mason Freed <mas...@chromium.org>
    Gerrit-Attention: Ian Clelland <icle...@chromium.org>
    Gerrit-Comment-Date: Thu, 12 Mar 2026 15:15:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Andrew Paseltiner <apase...@chromium.org>
    Comment-In-Reply-To: Ian Clelland <icle...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ian Clelland (Gerrit)

    unread,
    Mar 12, 2026, 4:00:49 PM (9 hours ago) Mar 12
    to Andrew Paseltiner, Chromium LUCI CQ, Mason Freed, Scott Violet, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
    Attention needed from Andrew Paseltiner and Mason Freed

    Ian Clelland voted and added 1 comment

    Votes added by Ian Clelland

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 1:
    Ian Clelland . resolved

    If 25 was previously used for *both* FailedMaxDepth and FailedBigText, then should we actually renumber both of them? Otherwise the histograms will show an unexplained drop in FailedMaxDepth when this lands

    Andrew Paseltiner

    Sure, we can do that, though there's going to be an unexplained discontinuity regardless. Do we want to bump the histogram version as well? I defer to the code owners here on their preferred solution.

    Andrew Paseltiner

    Re-numbered `kFailedMaxDepth` as well. Waiting for a determination on bumping the metric itself.

    Ian Clelland

    I'm happy with this, but I don't own the metric itself; if you're worried, you could reach out to html/parser OWNERS

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrew Paseltiner
    • Mason Freed
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic0a64244ae556fbdc7f8b317f19a8aafcb3a82d3
      Gerrit-Change-Number: 7657183
      Gerrit-PatchSet: 4
      Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
      Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
      Gerrit-Reviewer: Ian Clelland <icle...@chromium.org>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Scott Violet <s...@chromium.org>
      Gerrit-Attention: Mason Freed <mas...@chromium.org>
      Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
      Gerrit-Comment-Date: Thu, 12 Mar 2026 20:00:39 +0000
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages