Reland "[soft navs] Improve CLS test coverage." [chromium/src : main]
0 views
Skip to first unread message
Johannes Henkel (Gerrit)
May 19, 2026, 2:49:36 AM (yesterday) May 19
to Xinghui Lu, Scott Haseley, Chromium LUCI CQ, Annie Sullivan, rubber-...@appspot.gserviceaccount.com, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org
Attention needed from Annie Sullivan, Scott Haseley and Xinghui Lu
Johannes Henkel added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Johannes Henkel . resolved
Repro'd the earlier failure (sorry), and adjusted the screensize to 1024x768 in the test fixture. I also added the linux-wayland-weston-rel-tests bot, which now passes. Would like to try this again, thanks for considering.
Related details
Attention is currently required from:
- Annie Sullivan
- Scott Haseley
- Xinghui Lu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
rubber-stamper@appspot.gserviceaccount.com (Gerrit)
May 19, 2026, 2:50:22 AM (yesterday) May 19
to Johannes Henkel, Xinghui Lu, Scott Haseley, Chromium LUCI CQ, Annie Sullivan, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org
Attention needed from Annie Sullivan, Scott Haseley and Xinghui Lu
Message from rubber-...@appspot.gserviceaccount.com![]( "Open in Gerrit")
Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.
Annie Sullivan (Gerrit)
May 19, 2026, 9:36:47 AM (18 hours ago) May 19
to Johannes Henkel, Xinghui Lu, Scott Haseley, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org
Attention needed from Johannes Henkel, Scott Haseley and Xinghui Lu
Annie Sullivan voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Johannes Henkel
- Scott Haseley
- Xinghui Lu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johannes Henkel (Gerrit)
May 19, 2026, 10:42:29 AM (17 hours ago) May 19
to Annie Sullivan, Xinghui Lu, Scott Haseley, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org
Attention needed from Scott Haseley and Xinghui Lu
Johannes Henkel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Johannes Henkel
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Johannes Henkel . resolved
Thanks a lot. I'm submitting this quickly so we can see soon whether the small adjustment is sufficient.
Related details
Attention is currently required from:
- Scott Haseley
- Xinghui Lu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Haseley (Gerrit)
May 19, 2026, 11:47:12 AM (15 hours ago) May 19
to Johannes Henkel, Annie Sullivan, Xinghui Lu, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org
Attention needed from Johannes Henkel and Xinghui Lu
Scott Haseley voted and added 1 comment![]( "Open in Gerrit")
Votes added by Scott Haseley
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Johannes Henkel
- Xinghui Lu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xinghui Lu (Gerrit)
May 19, 2026, 11:52:09 AM (15 hours ago) May 19
to Johannes Henkel, Xinghui Lu, Scott Haseley, Annie Sullivan, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org
Attention needed from Johannes Henkel
Xinghui Lu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Xinghui Lu . resolved
Thanks for the investigation. The reland doesn't need gardener's review, so I'm removing myself from the reviewer list.
Related details
Attention is currently required from:
- Johannes Henkel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 19, 2026, 11:56:04 AM (15 hours ago) May 19
to Johannes Henkel, Xinghui Lu, Scott Haseley, Annie Sullivan, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, loading-rev...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Reland "[soft navs] Improve CLS test coverage."
This reverts commit a49d7dde42459da22036a6da1c473a0fa4c58884.
Reason for revert: Passes w/ adjusted screen size (see patchset 2).
Original change's description:
> Revert "[soft navs] Improve CLS test coverage."
>
> This reverts commit b12db17c1ee1f4644cdf3ef7dd90769ea20e957c.
>
> Reason for revert: caused timeout issue in linux-wayland-weston-rel-tests. https://ci.chromium.org/ui/p/chromium/builders/ci/linux-wayland-weston-rel-tests/14104/overview
>
> Original change's description:
> > [soft navs] Improve CLS test coverage.
> >
> > * Add coverage for softnav CLS after prerender and bfcache restores.
> > * Migrate CLS coverage for regular page loads
> > (SoftNavigationTest.LayoutShift) to use
> > soft_navigation_basics.html, instead of soft_navigation.html, as
> > it's drastically simpler.
> > * Due to the migration, SoftNavigationTest::GetCLSFromList is no
> > longer needed. Note that the replacement does not perform the
> > session window / gap algorithm, instead, it assumes that some
> > adjacent layout shifts are going to be expressed as their sum
> > in UKM. I think this is good enough, as the window / gap stuff
> > is tested elsewhere.
> >
> > For now, I'm doing exact comparisons (EXPECT_EQ) between the ukm CLS
> > values and the values coming from the renderer. I'm hoping that we can
> > get away with this and not see flakes (haven't seen any thus far), even
> > though the values from the renderer may have added noise and get
> > converted to integral values by rounding. But the alternative with
> > converting to double and EXPECT_NEAR like it's done in
> > layout_instability_browsertest.cc etc. seems less appealing because the
> > typical 1.0 allowed error may end up missing salient differences.
> >
> > Bug: 496610192
> > Change-Id: I2e77ce9ff8085f3677bbe8636bbc621609cca80d
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7842929
> > Reviewed-by: Scott Haseley <shas...@chromium.org>
> > Commit-Queue: Johannes Henkel <joha...@chromium.org>
> > Reviewed-by: Annie Sullivan <sull...@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1632379}
>
> Bug: 496610192
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: I44ff2a159eaad8a9fbcdc1e36c7b0e18dbeb672a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7857620
> Auto-Submit: Xinghui Lu <xing...@chromium.org>
> Owners-Override: Xinghui Lu <xing...@chromium.org>
> Commit-Queue: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>
> Bot-Commit: rubber-...@appspot.gserviceaccount.com <rubber-...@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1632462}
Bug: 496610192
Change-Id: I826fe0ced582cb4b8216de2dbaf72d3f89980787
Commit-Queue: Johannes Henkel <joha...@chromium.org>
Reviewed-by: Scott Haseley <shas...@chromium.org>
Reviewed-by: Annie Sullivan <sull...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1632863}
Files:
- M chrome/browser/page_load_metrics/integration_tests/data/soft_navigation_basics.html
- M chrome/browser/page_load_metrics/integration_tests/soft_navigation_metrics_browsertest.cc
Change size: L
Delta: 2 files changed, 342 insertions(+), 141 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Annie Sullivan, +1 by Scott Haseley
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages