Add UseCounter for cross-site iframe interaction [chromium/src : main]
0 views
Skip to first unread message
Chris Fredrickson (Gerrit)
Nov 3, 2025, 6:40:48 PM (3 days ago) Nov 3
to Jeremy Roman, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Jeremy Roman
Chris Fredrickson voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Jeremy Roman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeremy Roman (Gerrit)
Nov 4, 2025, 10:40:26 AM (2 days ago) Nov 4
to Chris Fredrickson, Jeremy Roman, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Attention needed from Chris Fredrickson
Jeremy Roman added 1 comment![]( "Open in Gerrit")
File chrome/browser/actor/actor_tab_observer.h
Line 15, Patchset 3 (Latest):
class ActorTabObserver : public content::WebContentsObserver {Jeremy Roman . unresolved
It's a little surprising to me that this code lives in /actor/ if we're recording it in general, not just for actor-controlled tabs. Why not just add this to MetricsWebContentsObserver itself, in that case?
Related details
Attention is currently required from:
- Chris Fredrickson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Fredrickson (Gerrit)
Nov 5, 2025, 4:04:56 PM (17 hours ago) Nov 5
to Jeremy Roman, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, mfoltz+wa...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org
Chris Fredrickson abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages