Issue 1448147 in chromium: Remove expired histograms Blink.Fonts.EmojiClusterBrokenness

[histogram-eraser via monorail]

Status: Untriaged
Owner: ----
CC: layou...@chromium.org, dr...@chromium.org
Labels: Hotlist-ExpiredHistograms-CodeHealthRotation
Components: Blink>Internals>Frames
Pri: 3
Type: Task

New issue 1448147 by histogra...@uma-hrd.google.com.iam.gserviceaccount.com: Remove expired histograms Blink.Fonts.EmojiClusterBrokenness
https://bugs.chromium.org/p/chromium/issues/detail?id=1448147

The following histograms are marked as expired in histograms.xml but still exist in the codebase:
- Blink.Fonts.EmojiClusterBrokenness (expired as of 2022-01-10)

The following code locations were found:

third_party/blink/renderer/core/frame/font_matching_metrics.cc:401:
UMA_HISTOGRAM_PERCENTAGE("Blink.Fonts.EmojiClusterBrokenness",

As these histograms are expired, no data for them gets collected. To reduce technical debt, the logging code for these histograms should be removed, including any supporting code. This is the recommended course of action for the majority of such histograms.

In rare cases, a histogram's code should be kept around, such as for debugging purposes. Such histograms must be clearly annotated in histograms.xml per the following instructions:
https://chromium.googlesource.com/chromium/src/+/HEAD/tools/metrics/histograms/README.md#Intentionally-expired-histograms

If you're an owner of any of the histograms, please triage this bug and either:
- If the histogram should be removed:
- Recommended: Mark the bug as Available and add the label Proj-CodeHealthRotation-Bug.
- Or, assign to yourself if you'd prefer to do the clean up yourself.
- Otherwise, annotate the histograms as intentionally expired (see above) and update the bug.
- If you believe the bug was filed in error, cc:asvi...@chromium.org and mention the problem.

Available bugs with the label Proj-CodeHealthRotation-Bug will be eligible for cleanup by participants in the code health rotation.

If the bug is left in the Untriaged state without any activity by histogram owner(s), we will consider that the histogram is not needed and it will be considered for removal.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[cbiesinger via monorail]

Updates:
Components: -Blink>Internals>Frames Blink>Fonts>Emoji

Comment #1 on issue 1448147 by cbies...@chromium.org: Remove expired histograms Blink.Fonts.EmojiClusterBrokenness
https://bugs.chromium.org/p/chromium/issues/detail?id=1448147#c1

(No comment was entered for this change.)

[drott via monorail]

Updates:
Owner: dr...@chromium.org
Status: Assigned

Comment #2 on issue 1448147 by dr...@chromium.org: Remove expired histograms Blink.Fonts.EmojiClusterBrokenness
https://bugs.chromium.org/p/chromium/issues/detail?id=1448147#c2

[tkent via monorail]

Comment #3 on issue 1448147 by tk...@chromium.org: Remove expired histograms Blink.Fonts.EmojiClusterBrokenness
https://bugs.chromium.org/p/chromium/issues/detail?id=1448147#c3

I'd like to work on this as a Code Health Rotation task.

[Git Watcher via monorail]

Comment #4 on issue 1448147 by Git Watcher: Remove expired histograms Blink.Fonts.EmojiClusterBrokenness
https://bugs.chromium.org/p/chromium/issues/detail?id=1448147#c4

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/02c90cf083688022f94b1c9836ac8ad9f1a64d09

commit 02c90cf083688022f94b1c9836ac8ad9f1a64d09
Author: Kent Tamura <tk...@chromium.org>
Date: Thu Nov 02 05:52:45 2023

Renew an expired histogram; Blink.Fonts.EmojiClusterBrokenness

Bug: 1448147
Change-Id: I2b1563f323acca6527ebf3447b9a2a48c0571501
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4988801
Commit-Queue: Kent Tamura <tk...@chromium.org>
Reviewed-by: Dominik Röttsches <dr...@chromium.org>
Reviewed-by: Takashi Toyoshima <toyo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1218647}

[modify] https://crrev.com/02c90cf083688022f94b1c9836ac8ad9f1a64d09/tools/metrics/histograms/metadata/blink/histograms.xml