Layout Team Weekly Snippets - October 2, 2017

[Emil A Eklund]

The last couple of weeks have been pretty busy between BlinkOn and
related travel. Most of us are back home by and ready to resume our
normal schedule

Updates since September 11:
- Attended BlinkOn in Tokyo and gave two talks, Next Gen enginge update
[1] (w/Naina and Chris) and Line Layout Deep Dive [2].
- Added support for emphasis mark painting to LayoutNG.
- Implemented paint-fallback on legacy layout/paint for LayoutReplaced.
- Refactored text decoration painting code to allow most of it to be
shared across LayoutNG and legacy and enabled implemented it for
LayoutNG.
- Coordination and planning with editing team.
- Started working on a set of performance tests for line layout.

This week:
- Fragment painting now works pretty well and passes a number of tests.
There are still some double paint issues though and hit testing isn't
implemented yet so we can't turn it on by default quite yet. Plan to
start looking into that this week.
- Refactor LayoutTheme for LayoutNG.
- Perf.

Please reply-all with your own update for last week and also indicate
if any of the proposed topics sounds interesting to you or if you have
another one you'd like to add to the agenda.

1: https://docs.google.com/presentation/d/11rr_vo7UNS6icihnWZMx45O4y5JiSegZKYLQKA1LAdo/view
2: https://docs.google.com/presentation/d/168Yq6dublmYDU-aAeFN59p8tWgAXieP4Scg7agfHQic/view

[David Grogan]

last week:

- Fixed 3 table-related crashing bugs, including one in column collapsing

this week:

 - table column collapsing

   - Hide relatively positioned layers in collapsed columns

   - fix dynamic column collapsing

   - remove O(n^2) column walk

   - update to latest agreed upon, but unspecified, behavior

--
You received this message because you are subscribed to the Google Groups "layout-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to layout-dev+unsubscribe@chromium.org.
To post to this group, send email to layou...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/layout-dev/CADu_oUB0D3aH%3DA6kPPgFu3ih7WZKpnpngtvYe1RWgiKeQ%3DG5VA%40mail.gmail.com.

[Steve Kobes]

[RLS]

- landed final patch for fixed backgrounds crrev.com/505493 (yay)

- meet with pdr@ about contributing in Q4 (yay)

- made categorized bug list, reviewing old bugs for status

- reviewed szager's mass-rebaseline for layerTreeAsText and layer position diffs

- fixed rwt.flag brokenness crrev.com/501119

[other]

- investigate scroll animation initial-value logic for wkorman's layer-decoupling patch

- perf

- BlinkOn

- prep / research for Life of a Pixel talk

[Koji Ishii]

Updates since September 11:

- Attended BlinkOn.

- Implemented 'unicode-bidi: plaintext'.

- Initial implementation of list-item.

- Support atomic inline fragments.

- 70% of fast/text pass.

  - Line breaker fixes.

  - Glyph bounds fixes.

This week:

- Fix atomic inline fragments crashers.

- Continue investigating visual overflow for NGPaint.

- Continue investigating baseline for NGPaint.

- Continue work on list-item.

--

You received this message because you are subscribed to the Google Groups "layout-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to layout-dev+unsubscribe@chromium.org.
To post to this group, send email to layou...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/layout-dev/CAAjAU%3Da2F1zkHFb1hCGcdnmNiakFHWq1yA9XVZaajt%3DAHLzDMw%40mail.gmail.com.

[Aleks Totic]

* Hacked on test-expectations.htm. The result made me happy, I can speedily scan results by just hitting spacebar. Colors dropper in zoom is also neat, now I can tell that all those results that looked the same are really just off by 1 errors.

Lots of work on ResizeObserver. Unfortunately, I did not make the M62 deadline (slow TAG). Only remaining task is getting to 3 LGTMs for Intent To Ship.

* Sent out Intent To Ship for ResizeObserver. 1 LGTM so far, 2 to go.

* Redid RO examples for explainer, fully featured chat scroll to bottom, iframe resize.

* RO tests have moved to w-p-t

AbsolutePosition work was mostly one big CR that should be landing any minute. Thanks Ian.

* Always handle NG inside Legacy OOF position CR. With this patch, NG elements will always be initially positioned with NG code, even when container is 

legacy. This patch will exercise NG code much more often, there is one regression that will be fixed shortly: abspos inside fixed are borked.

* OOF conflict resolution is logical, not physical  663426

There was something we talked about last week that I mentioned to Emil would be a good topic for Tuesday meeting, but I forgot what it was.

Aleks

On Mon, Oct 2, 2017 at 11:22 AM, 'Emil A Eklund' via layout-dev <layou...@chromium.org> wrote:

--
You received this message because you are subscribed to the Google Groups "layout-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to layout-dev+...@chromium.org.

To post to this group, send email to layou...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/layout-dev/CADu_oUB0D3aH%3DA6kPPgFu3ih7WZKpnpngtvYe1RWgiKeQ%3DG5VA%40mail.gmail.com.

[Karl Anders Øygard]

Last two weeks:

- Implemented the line height quirk in LayoutNG (https://crrev.com/c/664720).  The new code deviates slightly from the old behavior, but is more in line with Gecko and Edge.

- Chased down an overpainting bug (WIP: https://crrev.com/c/695109)

- Landed https://crrev.com/c/674875, which broke gerrit and was promptly reverted. \o/ . Will dig a little to see what went wrong, although the original issue is pretty unimportant.

- Did not attend BlinkOn. :(

--
You received this message because you are subscribed to the Google Groups "layout-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to layout-dev+unsubscribe@chromium.org.

To post to this group, send email to layou...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/layout-dev/CADu_oUB0D3aH%3DA6kPPgFu3ih7WZKpnpngtvYe1RWgiKeQ%3DG5VA%40mail.gmail.com.

--

 - Karl

[Xiaocheng Hu]

Last two weeks:

- BlinkOn8

- Meetings with the editing team and nektar@ with a lot of topics discussed

- Gave a presentation on offset mapping to the Tokyo Chrome team

This week:

- Update the design doc and slides of offset mapping

- Prototype some TextIterator-free editing functions on top of offset mapping directly

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/layout-dev/CAGN-iCQp0SzSf6FfQ538TAJxHZ%3D-aR-H_2Q0i6eAiD4y9qfmyg%40mail.gmail.com.

--

Regards,

Xiaocheng

[Dominik Röttsches]

Last two weeks:

• Presented about Shipping OpenType Variable Fonts at BlinkOn

• Fixed and finally landed CL for Guardian prefix bug by a partial rewrite of the inner shaping loop, should be much more readable now

• Travelled back from Tokyo

• Worked with Koji on proposal to make text-decoration-skip: ink objects; the default, discussed on api-owners-discuss and then sent Intent-to-Ship on blink-dev

• Fixed roboto weights regression on Android (ugly)

• Helped Fernando with a thread-safety issue on DWriteFontProxy

• Worked on Calibri windows spacing CL, but ran into a TSAN issue with SkString :(

• Memory analysis of variable fonts: turns out we’re creating a lot of separate word caches
  

• Discussed FontDescription object count reduction with Style team, briefed shend@, nainar@ meade@ on font matching and font resolution of FontDescription objects against web fonts and system fonts

Next:

• Land Calibri fix
• Merge roboto weights regression fix to 61
• Go through more bugs that had been piling up, approach local() matching or SimpleFontData/FontPlatformData issue

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/layout-dev/CAFqEGhZKiL3ZCiBSbhC8aXg%2B%3DM26BbNvTw9ZjQFY5st9JBk_qw%40mail.gmail.com.

[Morten Stenshorne]

Been on vacation for a couple of weeks. Apart from that, I have landed some CLs to eliminate unnecessary includes in popular header files, to speed up compilation. 

I will try to resume my NG work shortly. Column balancing, or something else to do with multicol. 

Also, for those who don't already know: I'm leaving Opera Software in two weeks. My Blink contributions will continue, though. :-) 

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/layout-dev/CAFqEGhZKiL3ZCiBSbhC8aXg%2B%3DM26BbNvTw9ZjQFY5st9JBk_qw%40mail.gmail.com.

[Yoichi Osato]

- BlinkOn8

- Discussed editing NG

- Prototyping new SelectionState marking 

2017年10月4日(水) 1:41 Morten Stenshorne <mste...@opera.com>:

To unsubscribe from this group and stop receiving emails from it, send an email to layout-dev+...@chromium.org.

To post to this group, send email to layou...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/layout-dev/CADu_oUB0D3aH%3DA6kPPgFu3ih7WZKpnpngtvYe1RWgiKeQ%3DG5VA%40mail.gmail.com.

--

 - Karl

--
You received this message because you are subscribed to the Google Groups "layout-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to layout-dev+...@chromium.org.

To post to this group, send email to layou...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/layout-dev/CAGN-iCQp0SzSf6FfQ538TAJxHZ%3D-aR-H_2Q0i6eAiD4y9qfmyg%40mail.gmail.com.

--

Regards,

Xiaocheng

--
You received this message because you are subscribed to the Google Groups "layout-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to layout-dev+...@chromium.org.

To post to this group, send email to layou...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/layout-dev/CAFqEGhZKiL3ZCiBSbhC8aXg%2B%3DM26BbNvTw9ZjQFY5st9JBk_qw%40mail.gmail.com.

--
You received this message because you are subscribed to the Google Groups "layout-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to layout-dev+...@chromium.org.

To post to this group, send email to layou...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/layout-dev/CAJpGdU_-1mEYfRjgGL%2Bwqvid-F%2BM_6Awn2Ocg9rFDQi0YW3tZQ%40mail.gmail.com.