Issue 1447162 in chromium: Remove expired histograms DirectWrite.Fonts.Proxy.LastResortFontCount, DirectWrite.Fonts.Proxy.LastResortFontFileCount, DirectWrite.Fonts.Proxy.LoaderType, DirectWrite.Fonts.Proxy.MessageFilterError

[histogram-eraser via monorail]

Status: Untriaged
Owner: ----
CC: layou...@chromium.org, dr...@chromium.org
Labels: Hotlist-ExpiredHistograms-CodeHealthRotation
Components: Internals>Core
Pri: 3
Type: Task

New issue 1447162 by histogra...@uma-hrd.google.com.iam.gserviceaccount.com: Remove expired histograms DirectWrite.Fonts.Proxy.LastResortFontCount, DirectWrite.Fonts.Proxy.LastResortFontFileCount, DirectWrite.Fonts.Proxy.LoaderType, DirectWrite.Fonts.Proxy.MessageFilterError
https://bugs.chromium.org/p/chromium/issues/detail?id=1447162

The following histograms are marked as expired in histograms.xml but still exist in the codebase:
- DirectWrite.Fonts.Proxy.LastResortFontCount (expired as of 2022-10-15)
- DirectWrite.Fonts.Proxy.LastResortFontFileCount (expired as of 2022-10-15)
- DirectWrite.Fonts.Proxy.LoaderType (expired as of 2022-12-18)
- DirectWrite.Fonts.Proxy.MessageFilterError (expired as of 2022-10-15)

The following code locations were found:

content/browser/renderer_host/dwrite_font_uma_logging_win.cc:13:
UMA_HISTOGRAM_ENUMERATION("DirectWrite.Fonts.Proxy.LoaderType", loader_type);
content/browser/renderer_host/dwrite_font_uma_logging_win.cc:17:
UMA_HISTOGRAM_COUNTS_100("DirectWrite.Fonts.Proxy.LastResortFontCount",
content/browser/renderer_host/dwrite_font_uma_logging_win.cc:22:
UMA_HISTOGRAM_COUNTS_100("DirectWrite.Fonts.Proxy.LastResortFontFileCount",
content/browser/renderer_host/dwrite_font_uma_logging_win.cc:27:
UMA_HISTOGRAM_ENUMERATION("DirectWrite.Fonts.Proxy.MessageFilterError",

As these histograms are expired, no data for them gets collected. To reduce technical debt, the logging code for these histograms should be removed, including any supporting code. This is the recommended course of action for the majority of such histograms.

In rare cases, a histogram's code should be kept around, such as for debugging purposes. Such histograms must be clearly annotated in histograms.xml per the following instructions:
https://chromium.googlesource.com/chromium/src/+/HEAD/tools/metrics/histograms/README.md#Intentionally-expired-histograms

If you're an owner of any of the histograms, please triage this bug and either:
- If the histogram should be removed:
- Recommended: Mark the bug as Available and add the label Proj=CodeHealthRotation.
- Or, assign to yourself if you'd prefer to do the clean up yourself.
- Otherwise, annotate the histograms as intentionally expired (see above) and update the bug.
- If you believe the bug was filed in error, cc:asvi...@chromium.org and mention the problem.

Available bugs with the label Proj=CodeHealthRotation will be eligible for cleanup by participants in the code health rotation.

If the bug is left in the Untriaged state without any activity by histogram owner(s), we will consider that the histogram is not needed and it will be considered for removal.

--
You received this message because:
1. You were specifically CC'd on the issue

You may adjust your notification preferences at:
https://bugs.chromium.org/hosting/settings

Reply to this email to add a comment or make updates.

[awscreen via monorail]

Updates:
Owner: awsc...@chromium.org
Status: Started

Comment #2 on issue 1447162 by awsc...@chromium.org: Remove expired histograms DirectWrite.Fonts.Proxy.LastResortFontCount, DirectWrite.Fonts.Proxy.LastResortFontFileCount, DirectWrite.Fonts.Proxy.LoaderType, DirectWrite.Fonts.Proxy.MessageFilterError
https://bugs.chromium.org/p/chromium/issues/detail?id=1447162#c2

(No comment was entered for this change.)

[Git Watcher via monorail]

Updates:
Status: Fixed

Comment #3 on issue 1447162 by Git Watcher: Remove expired histograms DirectWrite.Fonts.Proxy.LastResortFontCount, DirectWrite.Fonts.Proxy.LastResortFontFileCount, DirectWrite.Fonts.Proxy.LoaderType, DirectWrite.Fonts.Proxy.MessageFilterError
https://bugs.chromium.org/p/chromium/issues/detail?id=1447162#c3

The following revision refers to this bug:
https://chromium.googlesource.com/chromium/src/+/57a966ece36001d61fae52879abafc3f1f4828fd

commit 57a966ece36001d61fae52879abafc3f1f4828fd
Author: Alan Screen <awsc...@chromium.org>
Date: Mon Jul 10 17:52:49 2023

[CodeHealth] Drop expired DirectWrite.Fonts.Proxy histograms

Remove histograms which have long since expired:
- DirectWrite.Fonts.Proxy.LastResortFontCount
- DirectWrite.Fonts.Proxy.LastResortFontFileCount
- DirectWrite.Fonts.Proxy.LoaderType
- DirectWrite.Fonts.Proxy.MessageFilterError

OBSOLETE_HISTOGRAMS=DirectWrite.Fonts.Proxy.* No longer useful

Fixed: 1447162
Change-Id: Idfcc5e3362f0e4ac6fc32f6509e4b9fd16f27170
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4656825
Reviewed-by: Dominik Röttsches <dr...@chromium.org>
Reviewed-by: Yifan Luo <l...@chromium.org>
Commit-Queue: Alan Screen <awsc...@chromium.org>
Code-Coverage: Findit <findit...@appspot.gserviceaccount.com>
Reviewed-by: Robert Kaplow <rka...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1168198}

[modify] https://crrev.com/57a966ece36001d61fae52879abafc3f1f4828fd/content/browser/BUILD.gn
[delete] https://crrev.com/ff2e58b0e0b088bbe64408a5d554253caf6afaa4/content/browser/renderer_host/dwrite_font_uma_logging_win.h
[modify] https://crrev.com/57a966ece36001d61fae52879abafc3f1f4828fd/tools/metrics/histograms/metadata/direct/histograms.xml
[modify] https://crrev.com/57a966ece36001d61fae52879abafc3f1f4828fd/content/browser/renderer_host/dwrite_font_file_util_win.cc
[modify] https://crrev.com/57a966ece36001d61fae52879abafc3f1f4828fd/content/browser/renderer_host/dwrite_font_proxy_impl_win.cc
[delete] https://crrev.com/ff2e58b0e0b088bbe64408a5d554253caf6afaa4/content/browser/renderer_host/dwrite_font_uma_logging_win.cc