Style Guide Proposal: Ban Record Types

[Andrew Grieve]

Proposed CL:

https://chromium-review.googlesource.com/c/chromium/src/+/4980185

Will give this until ~mid next week to see if anyone has comments:

Rationale:

• To avoid dead code:
  • Records (like @AutoValue) generate equals(), hashCode(), and toString(), which R8 is unable to remove when unused.
• Supporting them requires build system work (crbug/1493366).

[Nate Fischer]

I'm OK with this style guide change. I gave some optional wording suggestions on the CL, but I'm OK with this change as-is.

Nate Fischer | Software Engineer | ntf...@google.com

--
You received this message because you are subscribed to the Google Groups "java" group.
To unsubscribe from this group and stop receiving emails from it, send an email to java+uns...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/java/CABiQX1X5jArR78yoLmDvdkaOT86_1F8x_%2BO6LuRM-RpPGSd84g%40mail.gmail.com.

[Andrew Grieve]

Since it's used as a reason to ban record types, I've also added a heading for toString():

toString()

Overriding toString() should not be done for debugging purposes, as the methods are not optimized out in release builds. It is encouraged to use custom methods (e.g. toDebugString() or getDescription()) when dynamic dispatch is not required.