crbug 989505

Daniel Libby

unread,

Sep 1, 2021, 10:24:57 PM9/1/21

to ja...@chromium.org, agr...@chromium.org

Hi – I’m looking for more information on https://crbug.com/989505. As the androidx.window support library has made it to Beta, I’ve been reviving my efforts to integrate the library in Chromium, in order to support foldable devices on the web.

After updating androidx dependencies locally, I’m hitting the _VerifyNoEmbeddedConfigs check in build/android/gyp/proguard.py for a couple of jars that I’m apparently pulling in:

Found embedded proguard config within ../../third_party/android_deps/libs/org_jetbrains_kotlinx_kotlinx_coroutines_core_jvm/kotlinx-coroutines-core-jvm-1.5.0.jar.

Embedded configs are not permitted (https://crbug.com/989505)

Found embedded proguard config within ../../third_party/android_deps/libs/org_jetbrains_kotlinx_kotlinx_coroutines_android/kotlinx-coroutines-android-1.5.0.jar.

Embedded configs are not permitted (https://crbug.com/989505)

The library was recently changed to be more usable by idiomatic Kotlin, but I’m not quite sure why this is showing up (maybe this is the first time the code is being pulled in to chrome_public_apk?), and I don’t have access to the crbug.

Are there any known workarounds for this issue? I suspect that based on the bug number, there may not be much urgency in fixing it at the moment.

Thanks for your help!

Peter Wen

unread,

Sep 2, 2021, 11:14:35 AM9/2/21

to Daniel Libby, ja...@chromium.org, agr...@chromium.org

I've opened the bug now so hopefully that additional context will help.

Peter

--
You received this message because you are subscribed to the Google Groups "java" group.
To unsubscribe from this group and stop receiving emails from it, send an email to java+uns...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/java/DM6PR00MB08570E4E2074881D863A8CDCD9CE9%40DM6PR00MB0857.namprd00.prod.outlook.com.

Daniel Libby

unread,

Sep 2, 2021, 1:36:55 PM9/2/21

to wn...@chromium.org, ja...@chromium.org, agr...@chromium.org

Thanks, that does help. If I’m reading it right, the correct way to handle this is to strip the proguard directory via BuildConfigGenerator.groovy, same as androidx_annotation_annotation. If one is lucky, the embedded proguard config can be positively identified as not necessary, so that’s all that needs to happen.

In this case, since the library usage is a transitive dependency and one of the proguard files is somewhat complicated (at least for org_jetbrains_kotlinx_kotlinx_coroutines_core_jvm), what is the right guidance? Based on my admittedly limited knowledge, I think I can add a .flags file to third_party/android_deps and add it to third_party/android_deps/buildSrc/src/main/groovy/BuildConfigGenerator.groovy, but is that the right approach?

Peter Wen

unread,

Sep 2, 2021, 1:48:11 PM9/2/21

to Daniel Libby, ja...@chromium.org, agr...@chromium.org

Hi Daniel,

Those are good questions, I'd like to take a closer look. Would you have a simple sample integration CL & steps for me to repro these failures locally?

Thanks,

Peter

Daniel Libby

unread,

Sep 2, 2021, 2:23:58 PM9/2/21

to wn...@chromium.org, ja...@chromium.org, agr...@chromium.org

I think this is the minimal repro:

https://chromium-review.googlesource.com/c/chromium/src/+/3139938

Repros locally for me building chrome_public_apk after running fetch_all_androidx.py

Thanks for looking!

Peter Wen

unread,

Sep 3, 2021, 3:03:36 PM9/3/21

to Daniel Libby, ja...@chromium.org, agr...@chromium.org

Hi Daniel,

Maybe we can take our discussion on the crbug so anyone else who looks up that bug can have this additional context. I'll reply there.