Demetrios Papadopoulos voted and added 1 comment

Demetrios Papadopoulos . resolved

Hi reviewers. PTAL as follows:

 - @sk...@chromium.org: third_party/cros-components/ and third_party/material_web_components/
 - @joelh...@chromium.org: ui/file_manager/
 - @rbpotter: Everything else
 
Thanks!

Related details

Attention is currently required from:

Joel Hockey
Rebekah Potter
Sean Kau

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Demetrios Papadopoulos (Gerrit)

unread,

Mar 30, 2026, 6:10:01 PM (6 days ago) Mar 30

to Sean Kau, Joel Hockey, Rebekah Potter, James Hawkins, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, chromium...@chromium.org, cros-essential...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, filesapp...@chromium.org, rginda...@chromium.org, hirokisa...@chromium.org, rrsilva+wat...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, anastas...@google.com, josiah...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, francisjp...@google.com, katie...@chromium.org, shannc...@chromium.org, oshima...@chromium.org, dewitt...@chromium.org

Attention needed from Demetrios Papadopoulos, Joel Hockey, Rebekah Potter and Sean Kau

Demetrios Papadopoulos voted and added 1 comment

Votes added by Demetrios Papadopoulos

Commit-Queue

+1

1 comment

Patchset-level comments

Demetrios Papadopoulos . unresolved

Hi reviewers. PTAL as follows:

 - @sk...@chromium.org: third_party/cros-components/ and third_party/material_web_components/
 - @joelh...@chromium.org: ui/file_manager/
 - @rbpotter: Everything else
 
Thanks!

Demetrios Papadopoulos

There is still an issue with `ios-simulator`, whih I thought had already been fixed. Pinged https://issues.chromium.org/issues/487338357#comment17 for help on fixing. Will resolve this comment once the iOS issue is addressed.

Related details

Attention is currently required from:

Demetrios Papadopoulos

Joel Hockey
Rebekah Potter
Sean Kau

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Joel Hockey (Gerrit)

unread,

Mar 30, 2026, 7:41:44 PM (6 days ago) Mar 30

to Demetrios Papadopoulos, Joel Hockey, Alexis Hétu, Sean Kau, Rebekah Potter, James Hawkins, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, chromium...@chromium.org, cros-essential...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, filesapp...@chromium.org, rginda...@chromium.org, hirokisa...@chromium.org, rrsilva+wat...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, anastas...@google.com, josiah...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, francisjp...@google.com, katie...@chromium.org, shannc...@chromium.org, oshima...@chromium.org, dewitt...@chromium.org

Attention needed from Demetrios Papadopoulos, Rebekah Potter and Sean Kau

Joel Hockey voted Code-Review+1

Code-Review

+1

Related details

Attention is currently required from:

Demetrios Papadopoulos
Rebekah Potter
Sean Kau

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Demetrios Papadopoulos (Gerrit)

unread,

Mar 31, 2026, 5:08:46 PM (5 days ago) Mar 31

to James Hawkins, Camden Bickel, Sean Kau, Joel Hockey, Alexis Hétu, Rebekah Potter, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, chromium...@chromium.org, cros-essential...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, filesapp...@chromium.org, rginda...@chromium.org, hirokisa...@chromium.org, rrsilva+wat...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, anastas...@google.com, josiah...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, francisjp...@google.com, katie...@chromium.org, shannc...@chromium.org, oshima...@chromium.org, dewitt...@chromium.org

Attention needed from Camden Bickel, James Hawkins, Rebekah Potter and Sean Kau

Demetrios Papadopoulos voted and added 1 comment

Votes added by Demetrios Papadopoulos

Commit-Queue

+1

1 comment

Patchset-level comments

Demetrios Papadopoulos . unresolved

Hi reviewers. PTAL as follows:

 - @sk...@chromium.org: third_party/cros-components/ and third_party/material_web_components/
 - @joelh...@chromium.org: ui/file_manager/
 - @rbpotter: Everything else
 
Thanks!

Demetrios Papadopoulos

There is still an issue with `ios-simulator`, whih I thought had already been fixed. Pinged https://issues.chromium.org/issues/487338357#comment17 for help on fixing. Will resolve this comment once the iOS issue is addressed.

Demetrios Papadopoulos

There is still an issue with ios-simulator

This is now resolved.

@skau: third_party/cros-components/ and third_party/material_web_components/

Redirecting to other reviweers since skau@ is OOO.

@jhaw...@chromium.org: PTAL at third_party/cros-components/tsconfig_base.json
@camb...@google.com: PTAL at third_party/material_web_components/tsconfig_base.json.

Related details

Attention is currently required from:

Camden Bickel
James Hawkins
Rebekah Potter
Sean Kau

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rebekah Potter (Gerrit)

unread,

Mar 31, 2026, 6:50:27 PM (5 days ago) Mar 31

to Demetrios Papadopoulos, James Hawkins, Camden Bickel, Sean Kau, Joel Hockey, Alexis Hétu, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, chromium...@chromium.org, cros-essential...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, filesapp...@chromium.org, rginda...@chromium.org, hirokisa...@chromium.org, rrsilva+wat...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, anastas...@google.com, josiah...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, francisjp...@google.com, katie...@chromium.org, shannc...@chromium.org, oshima...@chromium.org, dewitt...@chromium.org

Attention needed from Camden Bickel, Demetrios Papadopoulos, James Hawkins and Sean Kau

Rebekah Potter voted Code-Review+1

Code-Review

+1

Related details

Attention is currently required from:

Camden Bickel
Demetrios Papadopoulos
James Hawkins
Sean Kau

satisfied_requirement

unsatisfied_requirement

open

diffy

James Hawkins (Gerrit)

unread,

Mar 31, 2026, 8:36:06 PM (5 days ago) Mar 31

to Demetrios Papadopoulos, Rebekah Potter, Camden Bickel, Sean Kau, Joel Hockey, Alexis Hétu, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, chromium...@chromium.org, cros-essential...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, filesapp...@chromium.org, rginda...@chromium.org, hirokisa...@chromium.org, rrsilva+wat...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, anastas...@google.com, josiah...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, francisjp...@google.com, katie...@chromium.org, shannc...@chromium.org, oshima...@chromium.org, dewitt...@chromium.org

Attention needed from Camden Bickel, Demetrios Papadopoulos and Sean Kau

James Hawkins voted Code-Review+1

Code-Review

+1

Related details

Attention is currently required from:

Camden Bickel
Demetrios Papadopoulos
Sean Kau

satisfied_requirement

unsatisfied_requirement

open

diffy

Camden Bickel (Gerrit)

unread,

Mar 31, 2026, 9:10:12 PM (5 days ago) Mar 31

to Demetrios Papadopoulos, James Hawkins, Rebekah Potter, Sean Kau, Joel Hockey, Alexis Hétu, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, chromium...@chromium.org, cros-essential...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, filesapp...@chromium.org, rginda...@chromium.org, hirokisa...@chromium.org, rrsilva+wat...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, anastas...@google.com, josiah...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, francisjp...@google.com, katie...@chromium.org, shannc...@chromium.org, oshima...@chromium.org, dewitt...@chromium.org

Attention needed from Demetrios Papadopoulos and Sean Kau

Camden Bickel voted Code-Review+1

Code-Review

+1

Related details

Attention is currently required from:

Demetrios Papadopoulos
Sean Kau

satisfied_requirement

unsatisfied_requirement

open

diffy

Demetrios Papadopoulos (Gerrit)

unread,

Mar 31, 2026, 9:16:22 PM (5 days ago) Mar 31

to Nico Weber, Camden Bickel, James Hawkins, Rebekah Potter, Sean Kau, Joel Hockey, Alexis Hétu, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, chromium...@chromium.org, cros-essential...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, filesapp...@chromium.org, rginda...@chromium.org, hirokisa...@chromium.org, rrsilva+wat...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, anastas...@google.com, josiah...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, francisjp...@google.com, katie...@chromium.org, shannc...@chromium.org, oshima...@chromium.org, dewitt...@chromium.org

Attention needed from Nico Weber and Sean Kau

Demetrios Papadopoulos added 2 comments

Patchset-level comments

Demetrios Papadopoulos . resolved

Hi reviewers. PTAL as follows:

 - @sk...@chromium.org: third_party/cros-components/ and third_party/material_web_components/
 - @joelh...@chromium.org: ui/file_manager/
 - @rbpotter: Everything else
 
Thanks!

Demetrios Papadopoulos

There is still an issue with `ios-simulator`, whih I thought had already been fixed. Pinged https://issues.chromium.org/issues/487338357#comment17 for help on fixing. Will resolve this comment once the iOS issue is addressed.

Demetrios Papadopoulos

There is still an issue with ios-simulator
This is now resolved.
@skau: third_party/cros-components/ and third_party/material_web_components/
Redirecting to other reviweers since skau@ is OOO.
@jhaw...@chromium.org: PTAL at third_party/cros-components/tsconfig_base.json
@camb...@google.com: PTAL at third_party/material_web_components/tsconfig_base.json.

Demetrios Papadopoulos

Acknowledged

Demetrios Papadopoulos . resolved

@thakis: Could you stamp third_party/material_web_components/tsconfig_base.json ? Note that this has already been approved by camb...@google.com, but the owners file has incorrectly camb...@chromium.org (which per their word never existed?).

Related details

Attention is currently required from:

Nico Weber
Sean Kau

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Demetrios Papadopoulos (Gerrit)

unread,

Mar 31, 2026, 9:19:08 PM (5 days ago) Mar 31

to chromium-t...@google.com, Camden Bickel, James Hawkins, Rebekah Potter, Sean Kau, Joel Hockey, Alexis Hétu, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, chromium...@chromium.org, cros-essential...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, filesapp...@chromium.org, rginda...@chromium.org, hirokisa...@chromium.org, rrsilva+wat...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, anastas...@google.com, josiah...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, francisjp...@google.com, katie...@chromium.org, shannc...@chromium.org, oshima...@chromium.org, dewitt...@chromium.org

Attention needed from Sean Kau and chromium-t...@google.com

Demetrios Papadopoulos added 1 comment

Patchset-level comments

Demetrios Papadopoulos . resolved

@thakis: Could you stamp third_party/material_web_components/tsconfig_base.json ? Note that this has already been approved by camb...@google.com, but the owners file has incorrectly camb...@chromium.org (which per their word never existed?).

Demetrios Papadopoulos

Actually, thakis@ is also OOO, as well as all others from third_party/material_web_components/OWNERS.

Adding chromium-t...@google.com as a last resort to unblock this CL.

Related details

Attention is currently required from:

Sean Kau
chromium-t...@google.com

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Mar 31, 2026, 9:24:06 PM (5 days ago) Mar 31

to Demetrios Papadopoulos, chromium-t...@google.com, Dan Le Febvre, Camden Bickel, James Hawkins, Rebekah Potter, Sean Kau, Joel Hockey, Alexis Hétu, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, chromium...@chromium.org, cros-essential...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, filesapp...@chromium.org, rginda...@chromium.org, hirokisa...@chromium.org, rrsilva+wat...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, anastas...@google.com, josiah...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, francisjp...@google.com, katie...@chromium.org, shannc...@chromium.org, oshima...@chromium.org, dewitt...@chromium.org

Attention needed from Dan Le Febvre and Sean Kau

Message from gwsq

Reviewer source(s):
dlf is from oncall(chrome-ops-security)

Related details

Attention is currently required from:

Dan Le Febvre
Sean Kau

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Demetrios Papadopoulos (Gerrit)

unread,

Mar 31, 2026, 9:24:20 PM (5 days ago) Mar 31

to chromium-t...@google.com, Dan Le Febvre, Camden Bickel, James Hawkins, Rebekah Potter, Sean Kau, Joel Hockey, Alexis Hétu, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, chromium...@chromium.org, cros-essential...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, filesapp...@chromium.org, rginda...@chromium.org, hirokisa...@chromium.org, rrsilva+wat...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, anastas...@google.com, josiah...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, francisjp...@google.com, katie...@chromium.org, shannc...@chromium.org, oshima...@chromium.org, dewitt...@chromium.org

Attention needed from Dan Le Febvre and Sean Kau

Demetrios Papadopoulos voted and added 1 comment

Votes added by Demetrios Papadopoulos

Auto-Submit

+1

1 comment

Patchset-level comments

Demetrios Papadopoulos . resolved

@thakis: Could you stamp third_party/material_web_components/tsconfig_base.json ? Note that this has already been approved by camb...@google.com, but the owners file has incorrectly camb...@chromium.org (which per their word never existed?).

Demetrios Papadopoulos

Actually, thakis@ is also OOO, as well as all others from third_party/material_web_components/OWNERS.
Adding chromium-t...@google.com as a last resort to unblock this CL.

Demetrios Papadopoulos

@d...@google.com: PTAL ^

satisfied_requirement

unsatisfied_requirement

open

diffy

Dan Le Febvre (Gerrit)

unread,

Mar 31, 2026, 9:33:39 PM (5 days ago) Mar 31

to Demetrios Papadopoulos, chromium-t...@google.com, Camden Bickel, James Hawkins, Rebekah Potter, Sean Kau, Joel Hockey, Alexis Hétu, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, chromium...@chromium.org, cros-essential...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, filesapp...@chromium.org, rginda...@chromium.org, hirokisa...@chromium.org, rrsilva+wat...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, anastas...@google.com, josiah...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, francisjp...@google.com, katie...@chromium.org, shannc...@chromium.org, oshima...@chromium.org, dewitt...@chromium.org

Attention needed from Demetrios Papadopoulos and Sean Kau

Dan Le Febvre added 1 comment

Patchset-level comments

Demetrios Papadopoulos . unresolved

@thakis: Could you stamp third_party/material_web_components/tsconfig_base.json ? Note that this has already been approved by camb...@google.com, but the owners file has incorrectly camb...@chromium.org (which per their word never existed?).

Demetrios Papadopoulos

Actually, thakis@ is also OOO, as well as all others from third_party/material_web_components/OWNERS.
Adding chromium-t...@google.com as a last resort to unblock this CL.

Demetrios Papadopoulos

@d...@google.com: PTAL ^

Dan Le Febvre

Am looking, just want to check a few things.

Related details

Attention is currently required from:

Demetrios Papadopoulos
Sean Kau

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments
Review-Enforcement

satisfied_requirement

unsatisfied_requirement

open

diffy

Dan Le Febvre (Gerrit)

unread,

Mar 31, 2026, 10:02:48 PM (5 days ago) Mar 31

to Demetrios Papadopoulos, chromium-t...@google.com, Camden Bickel, James Hawkins, Rebekah Potter, Sean Kau, Joel Hockey, Alexis Hétu, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, chromium...@chromium.org, cros-essential...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, filesapp...@chromium.org, rginda...@chromium.org, hirokisa...@chromium.org, rrsilva+wat...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, anastas...@google.com, josiah...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, francisjp...@google.com, katie...@chromium.org, shannc...@chromium.org, oshima...@chromium.org, dewitt...@chromium.org

Attention needed from Demetrios Papadopoulos and Sean Kau

Dan Le Febvre added 1 comment

Patchset-level comments

Demetrios Papadopoulos . resolved

@thakis: Could you stamp third_party/material_web_components/tsconfig_base.json ? Note that this has already been approved by camb...@google.com, but the owners file has incorrectly camb...@chromium.org (which per their word never existed?).

Demetrios Papadopoulos

Actually, thakis@ is also OOO, as well as all others from third_party/material_web_components/OWNERS.
Adding chromium-t...@google.com as a last resort to unblock this CL.

Demetrios Papadopoulos

@d...@google.com: PTAL ^

Dan Le Febvre

Am looking, just want to check a few things.

Dan Le Febvre

Done

Related details

Attention is currently required from:

Demetrios Papadopoulos
Sean Kau

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

satisfied_requirement

unsatisfied_requirement

open

diffy

Dan Le Febvre (Gerrit)

unread,

Mar 31, 2026, 10:02:55 PM (5 days ago) Mar 31

to Demetrios Papadopoulos, chromium-t...@google.com, Camden Bickel, James Hawkins, Rebekah Potter, Sean Kau, Joel Hockey, Alexis Hétu, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, chromium...@chromium.org, cros-essential...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, filesapp...@chromium.org, rginda...@chromium.org, hirokisa...@chromium.org, rrsilva+wat...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, anastas...@google.com, josiah...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, francisjp...@google.com, katie...@chromium.org, shannc...@chromium.org, oshima...@chromium.org, dewitt...@chromium.org

Attention needed from Demetrios Papadopoulos and Sean Kau

Dan Le Febvre voted Owners-Override+1

Owners-Override

+1

Related details

Attention is currently required from:

Demetrios Papadopoulos
Sean Kau

Submit Requirements:

Code-Coverage
Code-Owners

satisfied_requirement

open

diffy

Demetrios Papadopoulos (Gerrit)

unread,

Apr 1, 2026, 12:56:34 PM (4 days ago) Apr 1

to Dan Le Febvre, chromium-t...@google.com, Camden Bickel, James Hawkins, Rebekah Potter, Sean Kau, Joel Hockey, Alexis Hétu, Chromium LUCI CQ, (Julie)Jeongeun Kim, AyeAye, chromium...@chromium.org, cros-essential...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, filesapp...@chromium.org, rginda...@chromium.org, hirokisa...@chromium.org, rrsilva+wat...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, anastas...@google.com, josiah...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, francisjp...@google.com, katie...@chromium.org, shannc...@chromium.org, oshima...@chromium.org, dewitt...@chromium.org

Attention needed from Sean Kau

Demetrios Papadopoulos voted Commit-Queue+2

Commit-Queue

+2

Related details

Attention is currently required from:

Sean Kau

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Apr 1, 2026, 1:01:12 PM (4 days ago) Apr 1

to Demetrios Papadopoulos, Dan Le Febvre, chromium-t...@google.com, Camden Bickel, James Hawkins, Rebekah Potter, Sean Kau, Joel Hockey, Alexis Hétu, Akihiro Ota, (Julie)Jeongeun Kim, AyeAye, chromium...@chromium.org, cros-essential...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, filesapp...@chromium.org, rginda...@chromium.org, hirokisa...@chromium.org, rrsilva+wat...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, anastas...@google.com, josiah...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, francisjp...@google.com, katie...@chromium.org, shannc...@chromium.org, oshima...@chromium.org, dewitt...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

WebUI: Update TypeScript compiler from 5.9.3 to 6.0.2.

Specifically:
 - Removing chrome/browser/resources/glic/url_pattern.d.ts since these
   are now part of TS compiler's default definitions.
 - Changing 'module' to 'namespace' in
   components/translate/ios/browser/resources/translate_ios.ts, since
   usage of the deprecated "module" now throws an error [1].
 - Updating third_party/node/patches/typescript.patch to restore the
   type of `HTMLElement#hidden` to just `boolean` instead of
   `"boolean|"until-found"` since the latter causes a lot of TS errors
   in WebUI tests. These will be addressed in a follow-up.
 - Removing newly unnecessary definitions in
   tools/typescript/definitions/pending.d.ts.

CrOS changes
 - Adding 'ignoreDeprecations' flag in CrOS targets that fail otherwise
   due to using stuff that is officially deprecated in v6:
   - chrome/browser/resources/chromeos/accessibility/
   - third_party/cros-components/
   - third_party/material_web_components/
 - Fixing newly surfaced type errors in ash/webui/media_app_ui/ and
   ui/file_manager/

[1] https://devblogs.microsoft.com/typescript/announcing-typescript-6-0/#deprecated:-legacy-module-syntax-for-namespaces

Bug: 423789047, 484345339, 468035608

Change-Id: Ic8c99564abfd8ccbe0774837e401e7dfb2cb53b8

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7405484

Commit-Queue: Demetrios Papadopoulos <dpa...@chromium.org>

Reviewed-by: Rebekah Potter <rbpo...@chromium.org>

Auto-Submit: Demetrios Papadopoulos <dpa...@chromium.org>

Owners-Override: Dan Le Febvre <d...@google.com>

Reviewed-by: Joel Hockey <joelh...@chromium.org>

Reviewed-by: James Hawkins <jhaw...@chromium.org>

Reviewed-by: Camden Bickel <camb...@google.com>

Cr-Commit-Position: refs/heads/main@{#1608613}

Files:

M DEPS
M ash/webui/media_app_ui/test/driver.ts
M chrome/browser/resources/chromeos/accessibility/tsconfig.base.json
M chrome/browser/resources/glic/BUILD.gn
D chrome/browser/resources/glic/url_pattern.d.ts
M chrome/test/data/webui/glic/BUILD.gn
M components/translate/ios/browser/resources/translate_ios.ts
M third_party/cros-components/tsconfig_base.json
M third_party/material_web_components/tsconfig_base.json
M third_party/node/node_modules.tar.gz.sha1
M third_party/node/package-lock.json
M third_party/node/package.json
M third_party/node/patches/typescript.patch
M tools/typescript/definitions/pending.d.ts
M ui/file_manager/file_manager/definitions/file_manager.d.ts

Change size: L

Delta: 15 files changed, 340 insertions(+), 340 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Camden Bickel, +1 by Joel Hockey, +1 by Rebekah Potter, +1 by James Hawkins

File-level comment, Patchset 8 (Latest):

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Ari Chivukula (Gerrit)

unread,

Apr 1, 2026, 1:23:14 PM (4 days ago) Apr 1

to Demetrios Papadopoulos, Chromium LUCI CQ, Dan Le Febvre, chromium-t...@google.com, Camden Bickel, James Hawkins, Rebekah Potter, Sean Kau, Joel Hockey, Alexis Hétu, (Julie)Jeongeun Kim, AyeAye, chromium...@chromium.org, cros-essential...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, filesapp...@chromium.org, rginda...@chromium.org, hirokisa...@chromium.org, rrsilva+wat...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, anastas...@google.com, josiah...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, francisjp...@google.com, katie...@chromium.org, shannc...@chromium.org, oshima...@chromium.org, dewitt...@chromium.org

Ari Chivukula has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chase Hartsell (Gerrit)

unread,

Apr 1, 2026, 1:23:46 PM (4 days ago) Apr 1

to Demetrios Papadopoulos, Chromium LUCI CQ, Dan Le Febvre, chromium-t...@google.com, Camden Bickel, James Hawkins, Rebekah Potter, Sean Kau, Joel Hockey, Alexis Hétu, (Julie)Jeongeun Kim, AyeAye, chromium...@chromium.org, cros-essential...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org, webauthn...@chromium.org, derinel+wat...@google.com, filesapp...@chromium.org, rginda...@chromium.org, hirokisa...@chromium.org, rrsilva+wat...@google.com, yuzo+...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, anastas...@google.com, josiah...@chromium.org, dtseng...@chromium.org, nektar...@chromium.org, francisjp...@google.com, katie...@chromium.org, shannc...@chromium.org, oshima...@chromium.org, dewitt...@chromium.org

Chase Hartsell has created a revert of this change

satisfied_requirement

open

diffy

Demetrios Papadopoulos (Gerrit)

unread,

Apr 2, 2026, 7:04:02 PM (3 days ago) Apr 2

to James Hawkins, Rebekah Potter, Dan Le Febvre, Luciano Pacheco, Camden Bickel, Joel Hockey, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, anastas...@google.com, cros-essential...@chromium.org, dewitt...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ios-r...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, oshima...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org

Attention needed from Dan Le Febvre, James Hawkins, Luciano Pacheco and Rebekah Potter

Demetrios Papadopoulos added 1 comment

Patchset-level comments

Demetrios Papadopoulos . resolved

Hi reviewers. This CL is identical to the original reverted CL at https://chromium-review.googlesource.com/c/chromium/src/+/7405484. See "Reland notes" in CL description about what has changed since.

PTAL as follows:
@luc...@chromium.org: ui/file_manager/ (previously reviewed by @joelh...@chromium.org who is OOO)
@jhaw...@chromium.org: third_party/cros-components/tsconfig_base.json
@d...@google.com: third_party/material_web_components/tsconfig_base.json (cc'ed @camb...@google.com who is an owner but without access to their chromium account).

Hopefully it sticks this time.
Thank you!

File-level comment, Patchset 8:

Related details

Attention is currently required from:

Dan Le Febvre
James Hawkins
Luciano Pacheco
Rebekah Potter

Submit Requirements:

Code-Coverage

Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Dan Le Febvre (Gerrit)

unread,

Apr 2, 2026, 7:23:03 PM (3 days ago) Apr 2

to Demetrios Papadopoulos, James Hawkins, Rebekah Potter, Luciano Pacheco, Camden Bickel, Joel Hockey, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, anastas...@google.com, cros-essential...@chromium.org, dewitt...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ios-r...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, oshima...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org

Attention needed from Camden Bickel, Demetrios Papadopoulos, James Hawkins, Luciano Pacheco and Rebekah Potter

Dan Le Febvre added 1 comment

Patchset-level comments

Demetrios Papadopoulos . unresolved

Hi reviewers. This CL is identical to the original reverted CL at https://chromium-review.googlesource.com/c/chromium/src/+/7405484. See "Reland notes" in CL description about what has changed since.
PTAL as follows:
@luc...@chromium.org: ui/file_manager/ (previously reviewed by @joelh...@chromium.org who is OOO)
@jhaw...@chromium.org: third_party/cros-components/tsconfig_base.json
@d...@google.com: third_party/material_web_components/tsconfig_base.json (cc'ed @camb...@google.com who is an owner but without access to their chromium account).
Hopefully it sticks this time.
Thank you!

Dan Le Febvre

Can we just fix the OWNERS file for third_party/material_web_components/tsconfig_base.json ? I don't want to keep owners overriding this. @camb...@google.com can you please craft a CL swapping your @chromium with your @google ?

File-level comment, Patchset 8:

Related details

Attention is currently required from:

Camden Bickel
Demetrios Papadopoulos

James Hawkins
Luciano Pacheco
Rebekah Potter

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Demetrios Papadopoulos (Gerrit)

unread,

Apr 2, 2026, 8:01:59 PM (3 days ago) Apr 2

to James Hawkins, Rebekah Potter, Dan Le Febvre, Luciano Pacheco, Camden Bickel, Joel Hockey, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, anastas...@google.com, cros-essential...@chromium.org, dewitt...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ios-r...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, oshima...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org

Attention needed from Camden Bickel, Dan Le Febvre, James Hawkins, Luciano Pacheco and Rebekah Potter

Demetrios Papadopoulos voted and added 1 comment

Votes added by Demetrios Papadopoulos

Commit-Queue

+1

1 comment

Patchset-level comments

Demetrios Papadopoulos . unresolved

Hi reviewers. This CL is identical to the original reverted CL at https://chromium-review.googlesource.com/c/chromium/src/+/7405484. See "Reland notes" in CL description about what has changed since.
PTAL as follows:
@luc...@chromium.org: ui/file_manager/ (previously reviewed by @joelh...@chromium.org who is OOO)
@jhaw...@chromium.org: third_party/cros-components/tsconfig_base.json
@d...@google.com: third_party/material_web_components/tsconfig_base.json (cc'ed @camb...@google.com who is an owner but without access to their chromium account).
Hopefully it sticks this time.
Thank you!

Dan Le Febvre

Can we just fix the OWNERS file for third_party/material_web_components/tsconfig_base.json ? I don't want to keep owners overriding this. @camb...@google.com can you please craft a CL swapping your @chromium with your @google ?

Demetrios Papadopoulos

Sent separate CL at https://chromium-review.googlesource.com/c/chromium/src/+/7728026. Will update reviewers in this CL once it lands. (Leaving unresolved for now)

File-level comment, Patchset 8:

Related details

Attention is currently required from:

Camden Bickel
Dan Le Febvre

satisfied_requirement

unsatisfied_requirement

open

diffy

Demetrios Papadopoulos (Gerrit)

unread,

Apr 2, 2026, 8:40:31 PM (3 days ago) Apr 2

to Camden Bickel, Dan Le Febvre, James Hawkins, Rebekah Potter, Luciano Pacheco, Joel Hockey, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, anastas...@google.com, cros-essential...@chromium.org, dewitt...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ios-r...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, oshima...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org

Attention needed from Camden Bickel, Dan Le Febvre, Demetrios Papadopoulos, James Hawkins, Luciano Pacheco and Rebekah Potter

Demetrios Papadopoulos voted and added 1 comment

Votes added by Demetrios Papadopoulos

Commit-Queue

+1

1 comment

Patchset-level comments

Demetrios Papadopoulos . resolved

Hi reviewers. This CL is identical to the original reverted CL at https://chromium-review.googlesource.com/c/chromium/src/+/7405484. See "Reland notes" in CL description about what has changed since.
PTAL as follows:
@luc...@chromium.org: ui/file_manager/ (previously reviewed by @joelh...@chromium.org who is OOO)
@jhaw...@chromium.org: third_party/cros-components/tsconfig_base.json
@d...@google.com: third_party/material_web_components/tsconfig_base.json (cc'ed @camb...@google.com who is an owner but without access to their chromium account).
Hopefully it sticks this time.
Thank you!

Dan Le Febvre

Can we just fix the OWNERS file for third_party/material_web_components/tsconfig_base.json ? I don't want to keep owners overriding this. @camb...@google.com can you please craft a CL swapping your @chromium with your @google ?

Demetrios Papadopoulos

Sent separate CL at https://chromium-review.googlesource.com/c/chromium/src/+/7728026. Will update reviewers in this CL once it lands. (Leaving unresolved for now)

Demetrios Papadopoulos

The CL above landed, updated reviewers.

Related details

Attention is currently required from:

Camden Bickel
Dan Le Febvre

Demetrios Papadopoulos

James Hawkins
Luciano Pacheco
Rebekah Potter

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rebekah Potter (Gerrit)

unread,

Apr 3, 2026, 1:34:11 PM (2 days ago) Apr 3

to Demetrios Papadopoulos, Camden Bickel, Dan Le Febvre, James Hawkins, Luciano Pacheco, Joel Hockey, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, anastas...@google.com, cros-essential...@chromium.org, dewitt...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ios-r...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, oshima...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org

Attention needed from Camden Bickel, Demetrios Papadopoulos, James Hawkins and Luciano Pacheco

Rebekah Potter voted Code-Review+1

Code-Review

+1

Related details

Attention is currently required from:

Camden Bickel

Demetrios Papadopoulos
James Hawkins
Luciano Pacheco

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Camden Bickel (Gerrit)

unread,

Apr 3, 2026, 1:40:59 PM (2 days ago) Apr 3

to Demetrios Papadopoulos, Rebekah Potter, Dan Le Febvre, James Hawkins, Luciano Pacheco, Joel Hockey, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, anastas...@google.com, cros-essential...@chromium.org, dewitt...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ios-r...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, oshima...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org

Attention needed from Demetrios Papadopoulos, James Hawkins and Luciano Pacheco

Camden Bickel voted Code-Review+1

Code-Review

+1

File-level comment, Patchset 9 (Latest):

Related details

Attention is currently required from:

satisfied_requirement

unsatisfied_requirement

open

diffy

Demetrios Papadopoulos (Gerrit)

unread,

Apr 3, 2026, 3:48:21 PM (2 days ago) Apr 3

to François Degros, Luciano Pacheco, Camden Bickel, Rebekah Potter, Dan Le Febvre, James Hawkins, Joel Hockey, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, anastas...@google.com, cros-essential...@chromium.org, dewitt...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ios-r...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, oshima...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org

Attention needed from François Degros, James Hawkins and Luciano Pacheco

Demetrios Papadopoulos added 1 comment

Patchset-level comments

Demetrios Papadopoulos . resolved

@fdegros: PTAL at ui/file_manager/ change (both lucmult@ and joelhockey@ are OOO). Thanks!

Related details

Attention is currently required from:

François Degros
James Hawkins
Luciano Pacheco

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

James Hawkins (Gerrit)

unread,

Apr 3, 2026, 3:50:54 PM (2 days ago) Apr 3

to Demetrios Papadopoulos, François Degros, Luciano Pacheco, Camden Bickel, Rebekah Potter, Dan Le Febvre, Joel Hockey, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, anastas...@google.com, cros-essential...@chromium.org, dewitt...@chromium.org, dtseng...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ios-r...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, oshima...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org

Attention needed from Demetrios Papadopoulos, François Degros and Luciano Pacheco

James Hawkins voted Code-Review+1

Code-Review

+1