Fix AllForms/FormStructureBrowserTest.DataDrivenHeuristics/* [chromium/src : main]
0 views
Skip to first unread message
Dominic Battre (Gerrit)
Jan 5, 2026, 7:55:56 AMJan 5
to Chromium LUCI CQ, AyeAye, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org
Attention needed from Christoph Schwering
Dominic Battre voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Christoph Schwering
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christoph Schwering (Gerrit)
Jan 5, 2026, 8:12:40 AMJan 5
to Dominic Battre, Chromium LUCI CQ, AyeAye, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org
Attention needed from Dominic Battre
Christoph Schwering voted and added 1 comment![]( "Open in Gerrit")
Votes added by Christoph Schwering
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Dominic Battre
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominic Battre (Gerrit)
Jan 5, 2026, 11:06:15 AMJan 5
to Chromium LUCI CQ, AyeAye, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org
Dominic Battre voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 5, 2026, 11:09:12 AMJan 5
to Dominic Battre, AyeAye, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Fix AllForms/FormStructureBrowserTest.DataDrivenHeuristics/*
Fix AllForms/FormStructureBrowserTest.DataDrivenHeuristics/{181,182} on
all platforms:
On new year often these tests break because the choice of expiration
years of credit cards become implausible. This CL hardcodes a date.
Fix AllForms/FormStructureBrowserTest.DataDrivenHeuristics/* on iOS:
autofill::FormStructureBrowserTest::TearDown() freed the web::WebState()
which was still referenced by the autofill::TestAutofillManagerInjector.
This CL ensures a proper destruction order.
Bug: 473467160
Fixed: 472755511,432460380
Change-Id: I04e6b3700e781eedaeb7b13ce287cf926a6a6964
Reviewed-by: Christoph Schwering <schw...@google.com>
Commit-Queue: Dominic Battre <bat...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1564384}
Files:
- M chrome/browser/autofill/form_structure_browsertest.cc
- M ios/chrome/browser/autofill/model/form_structure_browsertest.mm
Change size: S
Delta: 2 files changed, 36 insertions(+), 12 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Christoph Schwering
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ahmad Rayono (Gerrit)
Feb 24, 2026, 12:01:10 PM (14 hours ago) Feb 24
to Dominic Battre, Chromium LUCI CQ, AyeAye, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org, browser-comp...@chromium.org
Ahmad Rayono added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages