Update save card and cvc-save only to use wallet icon [chromium/src : main]
Olivia Saul (Gerrit)
Olivia Saul added 1 comment![]( "Open in Gerrit")
Screenshot: https://screenshot.googleplex.com/54wqgrXEH5qME2zWrong logo -- I think it's supposed to be the mono one [here](https://logos.teams.x20web.corp.google.com/#/?icon.query=wallet&icon.platform=web), see [slide](https://docs.google.com/presentation/d/1zBjR263p_dJOhttw4yDI7giDFQOzdSyTrMYuqniLuLw/edit?slide=id.g3b7ce1c3321_0_490#slide=id.g3b7ce1c3321_0_490)
Related details
- Qihui Zhao
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Qihui Zhao (Gerrit)
Qihui Zhao added 1 comment![]( "Open in Gerrit")
Wrong logo -- I think it's supposed to be the mono one [here](https://logos.teams.x20web.corp.google.com/#/?icon.query=wallet&icon.platform=web), see [slide](https://docs.google.com/presentation/d/1zBjR263p_dJOhttw4yDI7giDFQOzdSyTrMYuqniLuLw/edit?slide=id.g3b7ce1c3321_0_490#slide=id.g3b7ce1c3321_0_490)
I think it's the building issue, I added the svg file in [this](https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/8924070) CL and the preview looks good: https://screenshot.googleplex.com/BjjNKhRXqsLc986
It's because that the view is built under the flag: https://screenshot.googleplex.com/5PEwcZmrmhgHedr.
So I have to manual edit the icon.
Related details
- Olivia Saul
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivia Saul (Gerrit)
Olivia Saul added 1 comment![]( "Open in Gerrit")
Qihui ZhaoWrong logo -- I think it's supposed to be the mono one [here](https://logos.teams.x20web.corp.google.com/#/?icon.query=wallet&icon.platform=web), see [slide](https://docs.google.com/presentation/d/1zBjR263p_dJOhttw4yDI7giDFQOzdSyTrMYuqniLuLw/edit?slide=id.g3b7ce1c3321_0_490#slide=id.g3b7ce1c3321_0_490)
I think it's the building issue, I added the svg file in [this](https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/8924070) CL and the preview looks good: https://screenshot.googleplex.com/BjjNKhRXqsLc986
It's because that the view is built under the flag: https://screenshot.googleplex.com/5PEwcZmrmhgHedr.
So I have to manual edit the icon.
Sorry, I don't understand, and I don't know what these two screenshots show. What do you mean by manually edit the icon? We should be able to insert (separately) the Wallet logo and use that without needing to modify it at all, AFAIK.
Related details
- Qihui Zhao
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Qihui Zhao (Gerrit)
Qihui Zhao added 1 comment![]( "Open in Gerrit")
Screenshot: https://screenshot.googleplex.com/54wqgrXEH5qME2zQihui ZhaoWrong logo -- I think it's supposed to be the mono one [here](https://logos.teams.x20web.corp.google.com/#/?icon.query=wallet&icon.platform=web), see [slide](https://docs.google.com/presentation/d/1zBjR263p_dJOhttw4yDI7giDFQOzdSyTrMYuqniLuLw/edit?slide=id.g3b7ce1c3321_0_490#slide=id.g3b7ce1c3321_0_490)
Olivia SaulI think it's the building issue, I added the svg file in [this](https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/8924070) CL and the preview looks good: https://screenshot.googleplex.com/BjjNKhRXqsLc986
It's because that the view is built under the flag: https://screenshot.googleplex.com/5PEwcZmrmhgHedr.
So I have to manual edit the icon.
Sorry, I don't understand, and I don't know what these two screenshots show. What do you mean by manually edit the icon? We should be able to insert (separately) the Wallet logo and use that without needing to modify it at all, AFAIK.
I mean I'm using the logo I added [here](https://screenshot.googleplex.com/8QG8ZZ8bELmiDDd) in [this](https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/8924070) CL, so it should be the correct one.
I just think it's because of local build (like if I build local Chrome on Linux, I cannot always see GPay logo, but instead, it's showing a grey credit card icon).
Let me remove the screenshot to avoid confusion.
Related details
- Olivia Saul
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Olivia Saul (Gerrit)
Olivia Saul added 1 comment![]( "Open in Gerrit")
Qihui ZhaoWrong logo -- I think it's supposed to be the mono one [here](https://logos.teams.x20web.corp.google.com/#/?icon.query=wallet&icon.platform=web), see [slide](https://docs.google.com/presentation/d/1zBjR263p_dJOhttw4yDI7giDFQOzdSyTrMYuqniLuLw/edit?slide=id.g3b7ce1c3321_0_490#slide=id.g3b7ce1c3321_0_490)
Olivia SaulI think it's the building issue, I added the svg file in [this](https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/8924070) CL and the preview looks good: https://screenshot.googleplex.com/BjjNKhRXqsLc986
It's because that the view is built under the flag: https://screenshot.googleplex.com/5PEwcZmrmhgHedr.
So I have to manual edit the icon.
Qihui ZhaoSorry, I don't understand, and I don't know what these two screenshots show. What do you mean by manually edit the icon? We should be able to insert (separately) the Wallet logo and use that without needing to modify it at all, AFAIK.
I mean I'm using the logo I added [here](https://screenshot.googleplex.com/8QG8ZZ8bELmiDDd) in [this](https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/8924070) CL, so it should be the correct one.
I just think it's because of local build (like if I build local Chrome on Linux, I cannot always see GPay logo, but instead, it's showing a grey credit card icon).
Let me remove the screenshot to avoid confusion.
*I mean I'm using the logo I added here in this CL, so it should be the correct one.*
That's not the correct one, though. That's the wide logo with text, you want the [icon-only one](https://logos.teams.x20web.corp.google.com/#/?icon.query=wallet&icon.platform=web).
Related details
- Qihui Zhao
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Slobodan Pejic (Gerrit)
Slobodan Pejic added 1 comment![]( "Open in Gerrit")
Qihui ZhaoWrong logo -- I think it's supposed to be the mono one [here](https://logos.teams.x20web.corp.google.com/#/?icon.query=wallet&icon.platform=web), see [slide](https://docs.google.com/presentation/d/1zBjR263p_dJOhttw4yDI7giDFQOzdSyTrMYuqniLuLw/edit?slide=id.g3b7ce1c3321_0_490#slide=id.g3b7ce1c3321_0_490)
Olivia SaulI think it's the building issue, I added the svg file in [this](https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/8924070) CL and the preview looks good: https://screenshot.googleplex.com/BjjNKhRXqsLc986
It's because that the view is built under the flag: https://screenshot.googleplex.com/5PEwcZmrmhgHedr.
So I have to manual edit the icon.
Qihui ZhaoSorry, I don't understand, and I don't know what these two screenshots show. What do you mean by manually edit the icon? We should be able to insert (separately) the Wallet logo and use that without needing to modify it at all, AFAIK.
Olivia SaulI mean I'm using the logo I added [here](https://screenshot.googleplex.com/8QG8ZZ8bELmiDDd) in [this](https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/8924070) CL, so it should be the correct one.
I just think it's because of local build (like if I build local Chrome on Linux, I cannot always see GPay logo, but instead, it's showing a grey credit card icon).
Let me remove the screenshot to avoid confusion.
*I mean I'm using the logo I added here in this CL, so it should be the correct one.*
That's not the correct one, though. That's the wide logo with text, you want the [icon-only one](https://logos.teams.x20web.corp.google.com/#/?icon.query=wallet&icon.platform=web).
drive-by: FYI & only if needed, it is possible to build the branded Chrome for iOS build locally. go/building-chrome-ios#building-official-chrome
Related details
- Qihui Zhao
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |