[iOS] Actor's GetSupportedCapabilities checks for Finch disabled tools [chromium/src : main]

0 views
Skip to first unread message

Nicolas MacBeth (Gerrit)

unread,
Apr 2, 2026, 6:12:05 PM (3 days ago) Apr 2
to Kirubel Aklilu, Chromium LUCI CQ, chromium...@chromium.org, bling-ai-found...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Kirubel Aklilu

Nicolas MacBeth voted and added 1 comment

Votes added by Nicolas MacBeth

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Nicolas MacBeth . resolved

ptal, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Kirubel Aklilu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I318fdf4aff84848bfb46d91f5c1efe57a75a8cc1
Gerrit-Change-Number: 7726610
Gerrit-PatchSet: 2
Gerrit-Owner: Nicolas MacBeth <nicolas...@google.com>
Gerrit-Reviewer: Kirubel Aklilu <kak...@chromium.org>
Gerrit-Reviewer: Nicolas MacBeth <nicolas...@google.com>
Gerrit-Attention: Kirubel Aklilu <kak...@chromium.org>
Gerrit-Comment-Date: Thu, 02 Apr 2026 22:12:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kirubel Aklilu (Gerrit)

unread,
Apr 3, 2026, 10:30:42 AM (2 days ago) Apr 3
to Nicolas MacBeth, Chromium LUCI CQ, chromium...@chromium.org, bling-ai-found...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Nicolas MacBeth

Kirubel Aklilu voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nicolas MacBeth
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I318fdf4aff84848bfb46d91f5c1efe57a75a8cc1
    Gerrit-Change-Number: 7726610
    Gerrit-PatchSet: 4
    Gerrit-Owner: Nicolas MacBeth <nicolas...@google.com>
    Gerrit-Reviewer: Kirubel Aklilu <kak...@chromium.org>
    Gerrit-Reviewer: Nicolas MacBeth <nicolas...@google.com>
    Gerrit-Attention: Nicolas MacBeth <nicolas...@google.com>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 14:30:33 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Nicolas MacBeth (Gerrit)

    unread,
    Apr 3, 2026, 11:44:18 AM (2 days ago) Apr 3
    to Kirubel Aklilu, Chromium LUCI CQ, chromium...@chromium.org, bling-ai-found...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

    Nicolas MacBeth voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I318fdf4aff84848bfb46d91f5c1efe57a75a8cc1
    Gerrit-Change-Number: 7726610
    Gerrit-PatchSet: 4
    Gerrit-Owner: Nicolas MacBeth <nicolas...@google.com>
    Gerrit-Reviewer: Kirubel Aklilu <kak...@chromium.org>
    Gerrit-Reviewer: Nicolas MacBeth <nicolas...@google.com>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 15:44:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Nicolas MacBeth (Gerrit)

    unread,
    Apr 3, 2026, 11:44:53 AM (2 days ago) Apr 3
    to Kirubel Aklilu, Chromium LUCI CQ, chromium...@chromium.org, bling-ai-found...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

    Nicolas MacBeth voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I318fdf4aff84848bfb46d91f5c1efe57a75a8cc1
    Gerrit-Change-Number: 7726610
    Gerrit-PatchSet: 4
    Gerrit-Owner: Nicolas MacBeth <nicolas...@google.com>
    Gerrit-Reviewer: Kirubel Aklilu <kak...@chromium.org>
    Gerrit-Reviewer: Nicolas MacBeth <nicolas...@google.com>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 15:44:47 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Nicolas MacBeth (Gerrit)

    unread,
    Apr 3, 2026, 11:46:22 AM (2 days ago) Apr 3
    to Kirubel Aklilu, Chromium LUCI CQ, chromium...@chromium.org, bling-ai-found...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

    Nicolas MacBeth voted Commit-Queue+0

    Commit-Queue+0
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I318fdf4aff84848bfb46d91f5c1efe57a75a8cc1
    Gerrit-Change-Number: 7726610
    Gerrit-PatchSet: 4
    Gerrit-Owner: Nicolas MacBeth <nicolas...@google.com>
    Gerrit-Reviewer: Kirubel Aklilu <kak...@chromium.org>
    Gerrit-Reviewer: Nicolas MacBeth <nicolas...@google.com>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 15:46:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Nicolas MacBeth (Gerrit)

    unread,
    Apr 3, 2026, 11:47:08 AM (2 days ago) Apr 3
    to Kirubel Aklilu, Chromium LUCI CQ, chromium...@chromium.org, bling-ai-found...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

    Nicolas MacBeth voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I318fdf4aff84848bfb46d91f5c1efe57a75a8cc1
    Gerrit-Change-Number: 7726610
    Gerrit-PatchSet: 4
    Gerrit-Owner: Nicolas MacBeth <nicolas...@google.com>
    Gerrit-Reviewer: Kirubel Aklilu <kak...@chromium.org>
    Gerrit-Reviewer: Nicolas MacBeth <nicolas...@google.com>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 15:47:02 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 3, 2026, 12:31:54 PM (2 days ago) Apr 3
    to Nicolas MacBeth, Kirubel Aklilu, chromium...@chromium.org, bling-ai-found...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [iOS] Actor's GetSupportedCapabilities checks for Finch disabled tools

    NO_IFTTT=IFTTT added after tool landed, rebase missed the IFTTT
    Fixed: 499065683
    Change-Id: I318fdf4aff84848bfb46d91f5c1efe57a75a8cc1
    Commit-Queue: Nicolas MacBeth <nicolas...@google.com>
    Reviewed-by: Kirubel Aklilu <kak...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1609821}
    Files:
    Change size: S
    Delta: 3 files changed, 43 insertions(+), 2 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kirubel Aklilu
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I318fdf4aff84848bfb46d91f5c1efe57a75a8cc1
    Gerrit-Change-Number: 7726610
    Gerrit-PatchSet: 5
    Gerrit-Owner: Nicolas MacBeth <nicolas...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kirubel Aklilu <kak...@chromium.org>
    Gerrit-Reviewer: Nicolas MacBeth <nicolas...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages