[iOS] Exit fullscreen on non-same-document navigation [chromium/src : main]
0 views
Skip to first unread message
Hira Mahmood (Gerrit)
Apr 3, 2026, 4:15:19 PM (2 days ago) Apr 3
to Scott Yoder, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Scott Yoder
Hira Mahmood voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hira Mahmood
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Scott Yoder
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Yoder (Gerrit)
Apr 3, 2026, 4:30:42 PM (2 days ago) Apr 3
to Hira Mahmood, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Hira Mahmood
Scott Yoder voted and added 1 comment![]( "Open in Gerrit")
Votes added by Scott Yoder
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Hira Mahmood
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hira Mahmood (Gerrit)
Apr 3, 2026, 5:56:24 PM (2 days ago) Apr 3
to Scott Yoder, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Hira Mahmood voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 3, 2026, 6:03:51 PM (2 days ago) Apr 3
to Hira Mahmood, Scott Yoder, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Exit fullscreen on non-same-document navigation
This aligns with the legacy fullscreen behavior where fullscreen is
exited for most page navigations.
Same Document:
https://screencast.googleplex.com/cast/NjQzMzA0NDU4NzA4NTgyNHw4YmY4N2QyNy1iMw
Non-same Document:
https://screencast.googleplex.com/cast/NjYyOTQwMTM2NTA1MzQ0MHw0OGU2YmY5Yy03Mw
Fixed: 499332199
Change-Id: Id451e0699dfa21addea62ee55650d94ce19bc440
Reviewed-by: Scott Yoder <scott...@google.com>
Commit-Queue: Hira Mahmood <hiram...@google.com>
Cr-Commit-Position: refs/heads/main@{#1609986}
Files:
- M ios/chrome/browser/fullscreen/coordinator/fullscreen_mediator.mm
Change size: XS
Delta: 1 file changed, 8 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Scott Yoder
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages