Cliff Smolinsky (Gerrit)

unread,

Mar 31, 2026, 9:57:04 PM (5 days ago) Mar 31

to Tom Lukaszewicz, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, Lei Zhang, James Maclean, (Julie)Jeongeun Kim, Tommy Li, Kevin McNee, Raphael Kubo da Costa, Peter Beverloo, Todd Reifsteck, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, spang...@chromium.org, nona+...@chromium.org, cros-ed...@google.com, shuche...@chromium.org, tranbaod...@chromium.org, mfoltz+wa...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, chfreme...@chromium.org, keithle...@chromium.org, tracing...@chromium.org, ydago...@chromium.org, chromeos-ca...@google.com, cc-...@chromium.org, dtraino...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, chromiumme...@microsoft.com, akingsb+wat...@google.com, abigailbk...@google.com, nektar...@chromium.org, julietlevesque...@google.com, yhanad...@chromium.org, odejesu...@chromium.org, kyungjunle...@google.com, ajayramamurthy...@google.com, khmel...@chromium.org, djacob...@chromium.org, cros-enterpris...@chromium.org, msrame...@chromium.org, kinuko+...@chromium.org, feature-me...@chromium.org, jackshira+wa...@google.com, asvitki...@chromium.org, alandin...@chromium.org, josiah...@chromium.org, mtomas...@chromium.org, toyosh...@chromium.org, jackshira+wat...@google.com, francisjp...@google.com, hansberry+wa...@chromium.org, toshikikikuch...@chromium.org, dullweb...@chromium.org, phshah...@chromium.org, mattreyno...@chromium.org, dibyapal+wa...@chromium.org, crisrael+wa...@google.com, net-r...@chromium.org, hirokisa...@chromium.org, yuzo+...@chromium.org, oshima...@chromium.org, arc-review...@google.com, browser-comp...@chromium.org, cbe-cep-eng...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, dmurph+wat...@chromium.org, dtseng...@chromium.org, eic+...@google.com, extension...@chromium.org, filesapp...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jdeblas...@chromium.org, jimmyxgong+watch-shor...@chromium.org, longbowei+watch-shor...@google.com, marq+...@chromium.org, rrsilva+wat...@google.com, sloboda...@chromium.org, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Tom Lukaszewicz

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Tom Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Colin Blundell (Gerrit)

unread,

Apr 3, 2026, 2:42:47 AM (3 days ago) Apr 3

to Cliff Smolinsky, Colin Blundell, Tom Lukaszewicz, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, Lei Zhang, James Maclean, (Julie)Jeongeun Kim, Tommy Li, Kevin McNee, Raphael Kubo da Costa, Peter Beverloo, Todd Reifsteck, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, spang...@chromium.org, nona+...@chromium.org, cros-ed...@google.com, shuche...@chromium.org, tranbaod...@chromium.org, mfoltz+wa...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, chfreme...@chromium.org, keithle...@chromium.org, tracing...@chromium.org, ydago...@chromium.org, chromeos-ca...@google.com, cc-...@chromium.org, dtraino...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, chromiumme...@microsoft.com, akingsb+wat...@google.com, abigailbk...@google.com, nektar...@chromium.org, julietlevesque...@google.com, yhanad...@chromium.org, odejesu...@chromium.org, kyungjunle...@google.com, ajayramamurthy...@google.com, khmel...@chromium.org, djacob...@chromium.org, cros-enterpris...@chromium.org, msrame...@chromium.org, kinuko+...@chromium.org, feature-me...@chromium.org, jackshira+wa...@google.com, asvitki...@chromium.org, alandin...@chromium.org, josiah...@chromium.org, mtomas...@chromium.org, toyosh...@chromium.org, jackshira+wat...@google.com, francisjp...@google.com, hansberry+wa...@chromium.org, toshikikikuch...@chromium.org, dullweb...@chromium.org, phshah...@chromium.org, mattreyno...@chromium.org, dibyapal+wa...@chromium.org, crisrael+wa...@google.com, net-r...@chromium.org, hirokisa...@chromium.org, yuzo+...@chromium.org, oshima...@chromium.org, arc-review...@google.com, browser-comp...@chromium.org, cbe-cep-eng...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, dmurph+wat...@chromium.org, dtseng...@chromium.org, eic+...@google.com, extension...@chromium.org, filesapp...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jdeblas...@chromium.org, jimmyxgong+watch-shor...@chromium.org, longbowei+watch-shor...@google.com, marq+...@chromium.org, rrsilva+wat...@google.com, sloboda...@chromium.org, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Cliff Smolinsky and Tom Lukaszewicz

Colin Blundell added 1 comment

Commit Message

Line 14, Patchset 22 (Latest):Across all files, there are only 2 non-trivial destructors:

Colin Blundell . unresolved

Thanks! As per the email thread, could you move these out to their own CLs and then rebase this CL on top of those ones?

It looks like you already have a standalone CL for IdentityManagerFactory, so just need to do the rebase part for that one?

Open in Gerrit

Related details

Attention is currently required from:

Cliff Smolinsky
Tom Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Cliff Smolinsky (Gerrit)

unread,

Apr 3, 2026, 11:31:48 AM (2 days ago) Apr 3

to Colin Blundell, Tom Lukaszewicz, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, Lei Zhang, James Maclean, (Julie)Jeongeun Kim, Tommy Li, Kevin McNee, Raphael Kubo da Costa, Peter Beverloo, Todd Reifsteck, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, spang...@chromium.org, nona+...@chromium.org, cros-ed...@google.com, shuche...@chromium.org, tranbaod...@chromium.org, mfoltz+wa...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, chfreme...@chromium.org, keithle...@chromium.org, tracing...@chromium.org, ydago...@chromium.org, chromeos-ca...@google.com, cc-...@chromium.org, dtraino...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, chromiumme...@microsoft.com, akingsb+wat...@google.com, abigailbk...@google.com, nektar...@chromium.org, julietlevesque...@google.com, yhanad...@chromium.org, odejesu...@chromium.org, kyungjunle...@google.com, ajayramamurthy...@google.com, khmel...@chromium.org, djacob...@chromium.org, cros-enterpris...@chromium.org, msrame...@chromium.org, kinuko+...@chromium.org, feature-me...@chromium.org, jackshira+wa...@google.com, asvitki...@chromium.org, alandin...@chromium.org, josiah...@chromium.org, mtomas...@chromium.org, toyosh...@chromium.org, jackshira+wat...@google.com, francisjp...@google.com, hansberry+wa...@chromium.org, toshikikikuch...@chromium.org, dullweb...@chromium.org, phshah...@chromium.org, mattreyno...@chromium.org, dibyapal+wa...@chromium.org, crisrael+wa...@google.com, net-r...@chromium.org, hirokisa...@chromium.org, yuzo+...@chromium.org, oshima...@chromium.org, arc-review...@google.com, browser-comp...@chromium.org, cbe-cep-eng...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, dmurph+wat...@chromium.org, dtseng...@chromium.org, eic+...@google.com, extension...@chromium.org, filesapp...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jdeblas...@chromium.org, jimmyxgong+watch-shor...@chromium.org, longbowei+watch-shor...@google.com, marq+...@chromium.org, rrsilva+wat...@google.com, sloboda...@chromium.org, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Colin Blundell and Tom Lukaszewicz

Cliff Smolinsky added 1 comment

Commit Message

Line 14, Patchset 22 (Latest):Across all files, there are only 2 non-trivial destructors:

Colin Blundell . unresolved

Thanks! As per the email thread, could you move these out to their own CLs and then rebase this CL on top of those ones?
It looks like you already have a standalone CL for IdentityManagerFactory, so just need to do the rebase part for that one?

Cliff Smolinsky

Yeah, the first one already went in, just need the second to as well, then I'll rebase this which will remove the changes from here.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Tom Lukaszewicz

satisfied_requirement

unsatisfied_requirement

open

diffy

Colin Blundell (Gerrit)

unread,

Apr 3, 2026, 11:34:06 AM (2 days ago) Apr 3

to Cliff Smolinsky, Colin Blundell, Tom Lukaszewicz, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, Lei Zhang, James Maclean, (Julie)Jeongeun Kim, Tommy Li, Kevin McNee, Raphael Kubo da Costa, Peter Beverloo, Todd Reifsteck, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, spang...@chromium.org, nona+...@chromium.org, cros-ed...@google.com, shuche...@chromium.org, tranbaod...@chromium.org, mfoltz+wa...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, chfreme...@chromium.org, keithle...@chromium.org, tracing...@chromium.org, ydago...@chromium.org, chromeos-ca...@google.com, cc-...@chromium.org, dtraino...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, chromiumme...@microsoft.com, akingsb+wat...@google.com, abigailbk...@google.com, nektar...@chromium.org, julietlevesque...@google.com, yhanad...@chromium.org, odejesu...@chromium.org, kyungjunle...@google.com, ajayramamurthy...@google.com, khmel...@chromium.org, djacob...@chromium.org, cros-enterpris...@chromium.org, msrame...@chromium.org, kinuko+...@chromium.org, feature-me...@chromium.org, jackshira+wa...@google.com, asvitki...@chromium.org, alandin...@chromium.org, josiah...@chromium.org, mtomas...@chromium.org, toyosh...@chromium.org, jackshira+wat...@google.com, francisjp...@google.com, hansberry+wa...@chromium.org, toshikikikuch...@chromium.org, dullweb...@chromium.org, phshah...@chromium.org, mattreyno...@chromium.org, dibyapal+wa...@chromium.org, crisrael+wa...@google.com, net-r...@chromium.org, hirokisa...@chromium.org, yuzo+...@chromium.org, oshima...@chromium.org, arc-review...@google.com, browser-comp...@chromium.org, cbe-cep-eng...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, dmurph+wat...@chromium.org, dtseng...@chromium.org, eic+...@google.com, extension...@chromium.org, filesapp...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jdeblas...@chromium.org, jimmyxgong+watch-shor...@chromium.org, longbowei+watch-shor...@google.com, marq+...@chromium.org, rrsilva+wat...@google.com, sloboda...@chromium.org, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Cliff Smolinsky and Tom Lukaszewicz

Colin Blundell added 1 comment

Commit Message

Line 14, Patchset 22 (Latest):Across all files, there are only 2 non-trivial destructors:

Colin Blundell . unresolved

Thanks! As per the email thread, could you move these out to their own CLs and then rebase this CL on top of those ones?
It looks like you already have a standalone CL for IdentityManagerFactory, so just need to do the rebase part for that one?

Cliff Smolinsky

Yeah, the first one already went in, just need the second to as well, then I'll rebase this which will remove the changes from here.

Colin Blundell

Could you reping once that's done? (If you want you can make this into a CL chain and then you don't need to wait for the predecessor CLs to land for this one to be in the final form you want to be in and hence ready for review).

I'm ending my workday and will be OOO Monday, so no urgency here in any case.

Open in Gerrit

Related details

Attention is currently required from:

Cliff Smolinsky
Tom Lukaszewicz

satisfied_requirement

unsatisfied_requirement

open

diffy

Cliff Smolinsky (Gerrit)

unread,

Apr 3, 2026, 12:38:59 PM (2 days ago) Apr 3

to Colin Blundell, Tom Lukaszewicz, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, Lei Zhang, James Maclean, (Julie)Jeongeun Kim, Tommy Li, Kevin McNee, Raphael Kubo da Costa, Peter Beverloo, Todd Reifsteck, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, spang...@chromium.org, nona+...@chromium.org, cros-ed...@google.com, shuche...@chromium.org, tranbaod...@chromium.org, mfoltz+wa...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, chfreme...@chromium.org, keithle...@chromium.org, tracing...@chromium.org, ydago...@chromium.org, chromeos-ca...@google.com, cc-...@chromium.org, dtraino...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, chromiumme...@microsoft.com, akingsb+wat...@google.com, abigailbk...@google.com, nektar...@chromium.org, julietlevesque...@google.com, yhanad...@chromium.org, odejesu...@chromium.org, kyungjunle...@google.com, ajayramamurthy...@google.com, khmel...@chromium.org, djacob...@chromium.org, cros-enterpris...@chromium.org, msrame...@chromium.org, kinuko+...@chromium.org, feature-me...@chromium.org, jackshira+wa...@google.com, asvitki...@chromium.org, alandin...@chromium.org, josiah...@chromium.org, mtomas...@chromium.org, toyosh...@chromium.org, jackshira+wat...@google.com, francisjp...@google.com, hansberry+wa...@chromium.org, toshikikikuch...@chromium.org, dullweb...@chromium.org, phshah...@chromium.org, mattreyno...@chromium.org, dibyapal+wa...@chromium.org, crisrael+wa...@google.com, net-r...@chromium.org, hirokisa...@chromium.org, yuzo+...@chromium.org, oshima...@chromium.org, arc-review...@google.com, browser-comp...@chromium.org, cbe-cep-eng...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, dmurph+wat...@chromium.org, dtseng...@chromium.org, eic+...@google.com, extension...@chromium.org, filesapp...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jdeblas...@chromium.org, jimmyxgong+watch-shor...@chromium.org, longbowei+watch-shor...@google.com, marq+...@chromium.org, rrsilva+wat...@google.com, sloboda...@chromium.org, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, yhanada+...@chromium.org

Attention needed from Colin Blundell and Tom Lukaszewicz

Cliff Smolinsky added 1 comment

Commit Message

Line 14, Patchset 22:Across all files, there are only 2 non-trivial destructors:

Colin Blundell . resolved

Thanks! As per the email thread, could you move these out to their own CLs and then rebase this CL on top of those ones?
It looks like you already have a standalone CL for IdentityManagerFactory, so just need to do the rebase part for that one?

Cliff Smolinsky

Yeah, the first one already went in, just need the second to as well, then I'll rebase this which will remove the changes from here.

Colin Blundell

Could you reping once that's done? (If you want you can make this into a CL chain and then you don't need to wait for the predecessor CLs to land for this one to be in the final form you want to be in and hence ready for review).
I'm ending my workday and will be OOO Monday, so no urgency here in any case.

Cliff Smolinsky

rebase completed!

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
Tom Lukaszewicz

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Migrate keyed service factories from Singleton to NoDestructor [chromium/src : main]

Cliff Smolinsky (Gerrit)

New activity on the change

Related details

Colin Blundell (Gerrit)

Colin Blundell added 1 comment

Related details

Cliff Smolinsky (Gerrit)

Cliff Smolinsky added 1 comment

Related details

Colin Blundell (Gerrit)

Colin Blundell added 1 comment

Related details

Cliff Smolinsky (Gerrit)

Cliff Smolinsky added 1 comment

Related details