[iOS] Remove blur overlay on Reading Mode distillation timeout. [chromium/src : main]

0 views

Skip to first unread message

Nohemi Fernandez (Gerrit)

unread,

10:49 AM (2 hours ago) 10:49 AM

to Olivier Robin, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Olivier Robin

Nohemi Fernandez voted and added 1 comment

Votes added by Nohemi Fernandez

Commit-Queue

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Nohemi Fernandez . resolved

As discussed this is the more targeted approach to remove the blur overlay after a timeout to avoid blocking the app UI.

Open in Gerrit

Related details

Attention is currently required from:

Olivier Robin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Olivier Robin (Gerrit)

unread,

10:58 AM (2 hours ago) 10:58 AM

to Nohemi Fernandez, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Nohemi Fernandez

Olivier Robin voted and added 1 comment

Votes added by Olivier Robin

Code-Review

1 comment

File ios/chrome/browser/reader_mode/model/reader_mode_tab_helper.mm

Line 431, Patchset 1 (Latest): reader_mode_blur_timer_.Start(

Olivier Robin . unresolved

this should probably be stopped on some events.