Move CCSM and credit_card_import_type_ into PaymentsFDI [chromium/src : main]

0 views
Skip to first unread message

Vinny Persky (Gerrit)

unread,
Feb 23, 2026, 5:23:15 PM (yesterday) Feb 23
to Olivia Saul, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tmartino+tran...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, armalhotra+a...@google.com, vinnypersky+...@google.com, siyua+aut...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, osaul+aut...@google.com, browser-comp...@chromium.org
Attention needed from Olivia Saul

Vinny Persky added 1 comment

Patchset-level comments
File-level comment, Patchset 9 (Latest):
Vinny Persky . resolved

Hi Olivia,

PTAL! Thanks

Open in Gerrit

Related details

Attention is currently required from:
  • Olivia Saul
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie3ce2b7787a80f19c9c1305cb111c644c418c9f1
Gerrit-Change-Number: 7599738
Gerrit-PatchSet: 9
Gerrit-Owner: Vinny Persky <vinny...@google.com>
Gerrit-Reviewer: Olivia Saul <os...@google.com>
Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
Gerrit-Attention: Olivia Saul <os...@google.com>
Gerrit-Comment-Date: Mon, 23 Feb 2026 22:23:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Olivia Saul (Gerrit)

unread,
Feb 23, 2026, 6:28:19 PM (23 hours ago) Feb 23
to Vinny Persky, Olivia Saul, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tmartino+tran...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, armalhotra+a...@google.com, vinnypersky+...@google.com, siyua+aut...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, osaul+aut...@google.com, browser-comp...@chromium.org
Attention needed from Vinny Persky

Olivia Saul voted and added 3 comments

Votes added by Olivia Saul

Code-Review+1

3 comments

Patchset-level comments
Olivia Saul . resolved

LGTM % minor comments

File components/autofill/core/browser/form_import/form_data_importer.cc
Line 91, Patchset 9 (Latest): // TODO(crbug.com/481379161): Figure out a way to move this into
Olivia Saul . unresolved

Three new TODOs with "see if this is possible" are "this will likely never get resolved" red flags to me, becoming a source of new dead code. Didn't the design go in-depth in what the plan was here?

File components/autofill/core/browser/form_import/payments/payments_form_data_importer.cc
Line 32, Patchset 9 (Latest): ,
Olivia Saul . unresolved

Can this go above the `iban_save_manager_` instantiation to keep it and `client_` together and avoid the dangling comma, or is the order important here?

Open in Gerrit

Related details

Attention is currently required from:
  • Vinny Persky
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie3ce2b7787a80f19c9c1305cb111c644c418c9f1
    Gerrit-Change-Number: 7599738
    Gerrit-PatchSet: 9
    Gerrit-Owner: Vinny Persky <vinny...@google.com>
    Gerrit-Reviewer: Olivia Saul <os...@google.com>
    Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
    Gerrit-Attention: Vinny Persky <vinny...@google.com>
    Gerrit-Comment-Date: Mon, 23 Feb 2026 23:28:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vinny Persky (Gerrit)

    unread,
    3:55 AM (14 hours ago) 3:55 AM
    to Olivia Saul, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tmartino+tran...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, armalhotra+a...@google.com, vinnypersky+...@google.com, siyua+aut...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, osaul+aut...@google.com, browser-comp...@chromium.org

    Vinny Persky added 3 comments

    Patchset-level comments
    File-level comment, Patchset 10 (Latest):
    Vinny Persky . resolved

    Thanks!

    File components/autofill/core/browser/form_import/form_data_importer.cc
    Line 91, Patchset 9: // TODO(crbug.com/481379161): Figure out a way to move this into
    Olivia Saul . resolved

    Three new TODOs with "see if this is possible" are "this will likely never get resolved" red flags to me, becoming a source of new dead code. Didn't the design go in-depth in what the plan was here?

    Vinny Persky

    I didn't realize that the details of how to do this would be more complicated and not no-ops than they were. I'd rather put that in a separate CL once the rest of the functions are moved.

    Chatted offline with florian and he's aligned with this approach.

    File components/autofill/core/browser/form_import/payments/payments_form_data_importer.cc
    Line 32, Patchset 9: ,
    Olivia Saul . resolved

    Can this go above the `iban_save_manager_` instantiation to keep it and `client_` together and avoid the dangling comma, or is the order important here?

    Vinny Persky

    This is fine since CreditCardSaveManager does not hold a reference to IbanSaveManager. Done

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie3ce2b7787a80f19c9c1305cb111c644c418c9f1
      Gerrit-Change-Number: 7599738
      Gerrit-PatchSet: 10
      Gerrit-Owner: Vinny Persky <vinny...@google.com>
      Gerrit-Reviewer: Olivia Saul <os...@google.com>
      Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
      Gerrit-Comment-Date: Tue, 24 Feb 2026 08:54:58 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Olivia Saul <os...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Vinny Persky (Gerrit)

      unread,
      3:55 AM (14 hours ago) 3:55 AM
      to Florian Leimgruber, Olivia Saul, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tmartino+tran...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, armalhotra+a...@google.com, vinnypersky+...@google.com, siyua+aut...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, osaul+aut...@google.com, browser-comp...@chromium.org
      Attention needed from Florian Leimgruber

      Vinny Persky added 1 comment

      Patchset-level comments
      Vinny Persky . resolved

      Hi Florian,

      PTAL! Thanks

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Florian Leimgruber
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie3ce2b7787a80f19c9c1305cb111c644c418c9f1
      Gerrit-Change-Number: 7599738
      Gerrit-PatchSet: 10
      Gerrit-Owner: Vinny Persky <vinny...@google.com>
      Gerrit-Reviewer: Florian Leimgruber <fleim...@google.com>
      Gerrit-Reviewer: Olivia Saul <os...@google.com>
      Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
      Gerrit-Attention: Florian Leimgruber <fleim...@google.com>
      Gerrit-Comment-Date: Tue, 24 Feb 2026 08:55:07 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Vinny Persky (Gerrit)

      unread,
      4:04 AM (14 hours ago) 4:04 AM
      to Olivia Saul, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tmartino+tran...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, armalhotra+a...@google.com, vinnypersky+...@google.com, siyua+aut...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, osaul+aut...@google.com, browser-comp...@chromium.org
      Attention needed from Vinny Persky

      Vinny Persky voted Commit-Queue+1

      Commit-Queue+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Vinny Persky
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie3ce2b7787a80f19c9c1305cb111c644c418c9f1
      Gerrit-Change-Number: 7599738
      Gerrit-PatchSet: 10
      Gerrit-Owner: Vinny Persky <vinny...@google.com>
      Gerrit-Reviewer: Olivia Saul <os...@google.com>
      Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
      Gerrit-Attention: Vinny Persky <vinny...@google.com>
      Gerrit-Comment-Date: Tue, 24 Feb 2026 09:04:09 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Vinny Persky (Gerrit)

      unread,
      4:16 AM (14 hours ago) 4:16 AM
      to Florian Leimgruber, Olivia Saul, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tmartino+tran...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, armalhotra+a...@google.com, vinnypersky+...@google.com, siyua+aut...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, osaul+aut...@google.com, browser-comp...@chromium.org
      Attention needed from Florian Leimgruber

      Vinny Persky added 1 comment

      Vinny Persky . resolved

      Hi Florian,

      PTAL! Thanks

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Florian Leimgruber
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie3ce2b7787a80f19c9c1305cb111c644c418c9f1
      Gerrit-Change-Number: 7599738
      Gerrit-PatchSet: 11
      Gerrit-Owner: Vinny Persky <vinny...@google.com>
      Gerrit-Reviewer: Florian Leimgruber <fleim...@google.com>
      Gerrit-Reviewer: Olivia Saul <os...@google.com>
      Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
      Gerrit-Attention: Florian Leimgruber <fleim...@google.com>
      Gerrit-Comment-Date: Tue, 24 Feb 2026 09:16:03 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Florian Leimgruber (Gerrit)

      unread,
      5:59 AM (12 hours ago) 5:59 AM
      to Vinny Persky, Olivia Saul, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tmartino+tran...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, armalhotra+a...@google.com, vinnypersky+...@google.com, siyua+aut...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, osaul+aut...@google.com, browser-comp...@chromium.org
      Attention needed from Vinny Persky

      Florian Leimgruber voted and added 1 comment

      Votes added by Florian Leimgruber

      Code-Review+1

      1 comment

      File chrome/browser/ui/views/autofill/payments/save_card_bubble_views_browsertest.cc
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Vinny Persky
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ie3ce2b7787a80f19c9c1305cb111c644c418c9f1
        Gerrit-Change-Number: 7599738
        Gerrit-PatchSet: 11
        Gerrit-Owner: Vinny Persky <vinny...@google.com>
        Gerrit-Reviewer: Florian Leimgruber <fleim...@google.com>
        Gerrit-Reviewer: Olivia Saul <os...@google.com>
        Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
        Gerrit-Attention: Vinny Persky <vinny...@google.com>
        Gerrit-Comment-Date: Tue, 24 Feb 2026 10:59:37 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Vinny Persky (Gerrit)

        unread,
        8:18 AM (10 hours ago) 8:18 AM
        to Allen Bauer, Tommy Martino, Florian Leimgruber, Olivia Saul, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tmartino+tran...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, armalhotra+a...@google.com, vinnypersky+...@google.com, siyua+aut...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, osaul+aut...@google.com, browser-comp...@chromium.org
        Attention needed from Allen Bauer, Florian Leimgruber, Olivia Saul and Tommy Martino

        Vinny Persky added 1 comment

        Patchset-level comments
        File-level comment, Patchset 12 (Latest):
        Vinny Persky . resolved

        Thanks Florian + Olivia!

        Allen - Can you PTAL at chrome/browser/ui/views/frame/browser_frame_view_browsertest.cc

        Tommy - Can you PTAL at ios/chrome/browser/autofill/ui_bundled/autofill_app_interface.mm?

        Thanks so much!

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Allen Bauer
        • Florian Leimgruber
        • Olivia Saul
        • Tommy Martino
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedNo-Unresolved-Comments
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ie3ce2b7787a80f19c9c1305cb111c644c418c9f1
          Gerrit-Change-Number: 7599738
          Gerrit-PatchSet: 12
          Gerrit-Owner: Vinny Persky <vinny...@google.com>
          Gerrit-Reviewer: Allen Bauer <kyl...@chromium.org>
          Gerrit-Reviewer: Florian Leimgruber <fleim...@google.com>
          Gerrit-Reviewer: Olivia Saul <os...@google.com>
          Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
          Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
          Gerrit-Attention: Allen Bauer <kyl...@chromium.org>
          Gerrit-Attention: Florian Leimgruber <fleim...@google.com>
          Gerrit-Attention: Tommy Martino <tmar...@chromium.org>
          Gerrit-Attention: Olivia Saul <os...@google.com>
          Gerrit-Comment-Date: Tue, 24 Feb 2026 13:17:56 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Vinny Persky (Gerrit)

          unread,
          8:18 AM (10 hours ago) 8:18 AM
          to Allen Bauer, Tommy Martino, Florian Leimgruber, Olivia Saul, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tmartino+tran...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, armalhotra+a...@google.com, vinnypersky+...@google.com, siyua+aut...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, osaul+aut...@google.com, browser-comp...@chromium.org
          Attention needed from Allen Bauer, Florian Leimgruber, Olivia Saul and Tommy Martino

          Vinny Persky added 1 comment

          File chrome/browser/ui/views/autofill/payments/save_card_bubble_views_browsertest.cc
          Line 301, Patchset 11: .GetCreditCardSaveManager()
          Florian Leimgruber . resolved
          Vinny Persky

          Done

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Allen Bauer
          • Florian Leimgruber
          • Olivia Saul
          • Tommy Martino
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement is not satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            • requirement is not satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Ie3ce2b7787a80f19c9c1305cb111c644c418c9f1
            Gerrit-Change-Number: 7599738
            Gerrit-PatchSet: 12
            Gerrit-Owner: Vinny Persky <vinny...@google.com>
            Gerrit-Reviewer: Allen Bauer <kyl...@chromium.org>
            Gerrit-Reviewer: Florian Leimgruber <fleim...@google.com>
            Gerrit-Reviewer: Olivia Saul <os...@google.com>
            Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
            Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
            Gerrit-Attention: Allen Bauer <kyl...@chromium.org>
            Gerrit-Attention: Florian Leimgruber <fleim...@google.com>
            Gerrit-Attention: Tommy Martino <tmar...@chromium.org>
            Gerrit-Attention: Olivia Saul <os...@google.com>
            Gerrit-Comment-Date: Tue, 24 Feb 2026 13:18:04 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: No
            Comment-In-Reply-To: Florian Leimgruber <fleim...@google.com>
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Tommy Martino (Gerrit)

            unread,
            10:53 AM (7 hours ago) 10:53 AM
            to Vinny Persky, Allen Bauer, Florian Leimgruber, Olivia Saul, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tmartino+tran...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, armalhotra+a...@google.com, vinnypersky+...@google.com, siyua+aut...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, osaul+aut...@google.com, browser-comp...@chromium.org
            Attention needed from Allen Bauer, Florian Leimgruber, Olivia Saul and Vinny Persky

            Tommy Martino voted and added 1 comment

            Votes added by Tommy Martino

            Code-Review+1

            1 comment

            Patchset-level comments
            Tommy Martino . resolved

            ios lgtm

            Open in Gerrit

            Related details

            Attention is currently required from:
            • Allen Bauer
            • Florian Leimgruber
            • Olivia Saul
            • Vinny Persky
            Submit Requirements:
              • requirement satisfiedCode-Coverage
              • requirement is not satisfiedCode-Owners
              • requirement satisfiedCode-Review
              • requirement satisfiedReview-Enforcement
              Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
              Gerrit-MessageType: comment
              Gerrit-Project: chromium/src
              Gerrit-Branch: main
              Gerrit-Change-Id: Ie3ce2b7787a80f19c9c1305cb111c644c418c9f1
              Gerrit-Change-Number: 7599738
              Gerrit-PatchSet: 12
              Gerrit-Owner: Vinny Persky <vinny...@google.com>
              Gerrit-Reviewer: Allen Bauer <kyl...@chromium.org>
              Gerrit-Reviewer: Florian Leimgruber <fleim...@google.com>
              Gerrit-Reviewer: Olivia Saul <os...@google.com>
              Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
              Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
              Gerrit-Attention: Vinny Persky <vinny...@google.com>
              Gerrit-Attention: Allen Bauer <kyl...@chromium.org>
              Gerrit-Attention: Florian Leimgruber <fleim...@google.com>
              Gerrit-Attention: Olivia Saul <os...@google.com>
              Gerrit-Comment-Date: Tue, 24 Feb 2026 15:53:40 +0000
              Gerrit-HasComments: Yes
              Gerrit-Has-Labels: Yes
              satisfied_requirement
              unsatisfied_requirement
              open
              diffy

              Florian Leimgruber (Gerrit)

              unread,
              11:28 AM (6 hours ago) 11:28 AM
              to Vinny Persky, Tommy Martino, Allen Bauer, Olivia Saul, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tmartino+tran...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, armalhotra+a...@google.com, vinnypersky+...@google.com, siyua+aut...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, osaul+aut...@google.com, browser-comp...@chromium.org
              Attention needed from Allen Bauer, Olivia Saul and Vinny Persky

              Florian Leimgruber voted and added 1 comment

              Votes added by Florian Leimgruber

              Code-Review+1

              1 comment

              File components/autofill/core/browser/payments/credit_card_save_manager.h
              Line 42, Patchset 12 (Latest):// save logic. Owned by PaymentsFormDataImporter.
              Florian Leimgruber . unresolved

              nitty nit: Remove one space

              Open in Gerrit

              Related details

              Attention is currently required from:
              • Allen Bauer
              • Olivia Saul
              • Vinny Persky
              Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement is not satisfiedCode-Owners
                • requirement satisfiedCode-Review
                • requirement is not satisfiedNo-Unresolved-Comments
                • requirement satisfiedReview-Enforcement
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: Ie3ce2b7787a80f19c9c1305cb111c644c418c9f1
                Gerrit-Change-Number: 7599738
                Gerrit-PatchSet: 12
                Gerrit-Owner: Vinny Persky <vinny...@google.com>
                Gerrit-Reviewer: Allen Bauer <kyl...@chromium.org>
                Gerrit-Reviewer: Florian Leimgruber <fleim...@google.com>
                Gerrit-Reviewer: Olivia Saul <os...@google.com>
                Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
                Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
                Gerrit-Attention: Vinny Persky <vinny...@google.com>
                Gerrit-Attention: Allen Bauer <kyl...@chromium.org>
                Gerrit-Attention: Olivia Saul <os...@google.com>
                Gerrit-Comment-Date: Tue, 24 Feb 2026 16:28:14 +0000
                Gerrit-HasComments: Yes
                Gerrit-Has-Labels: Yes
                satisfied_requirement
                unsatisfied_requirement
                open
                diffy

                Allen Bauer (Gerrit)

                unread,
                12:28 PM (5 hours ago) 12:28 PM
                to Vinny Persky, Florian Leimgruber, Tommy Martino, Olivia Saul, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tmartino+tran...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, armalhotra+a...@google.com, vinnypersky+...@google.com, siyua+aut...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, osaul+aut...@google.com, browser-comp...@chromium.org
                Attention needed from Olivia Saul and Vinny Persky

                Allen Bauer voted and added 1 comment

                Votes added by Allen Bauer

                Code-Review+1

                1 comment

                Patchset-level comments
                Allen Bauer . resolved

                lgtm

                Open in Gerrit

                Related details

                Attention is currently required from:
                • Olivia Saul
                • Vinny Persky
                Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement satisfiedCode-Owners
                • requirement satisfiedCode-Review
                • requirement is not satisfiedNo-Unresolved-Comments
                • requirement satisfiedReview-Enforcement
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: Ie3ce2b7787a80f19c9c1305cb111c644c418c9f1
                Gerrit-Change-Number: 7599738
                Gerrit-PatchSet: 12
                Gerrit-Owner: Vinny Persky <vinny...@google.com>
                Gerrit-Reviewer: Allen Bauer <kyl...@chromium.org>
                Gerrit-Reviewer: Florian Leimgruber <fleim...@google.com>
                Gerrit-Reviewer: Olivia Saul <os...@google.com>
                Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
                Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
                Gerrit-Attention: Vinny Persky <vinny...@google.com>
                Gerrit-Attention: Olivia Saul <os...@google.com>
                Gerrit-Comment-Date: Tue, 24 Feb 2026 17:28:35 +0000
                Gerrit-HasComments: Yes
                Gerrit-Has-Labels: Yes
                satisfied_requirement
                unsatisfied_requirement
                open
                diffy

                Vinny Persky (Gerrit)

                unread,
                1:31 PM (4 hours ago) 1:31 PM
                to Allen Bauer, Florian Leimgruber, Tommy Martino, Olivia Saul, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tmartino+tran...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, armalhotra+a...@google.com, vinnypersky+...@google.com, siyua+aut...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, osaul+aut...@google.com, browser-comp...@chromium.org
                Attention needed from Olivia Saul

                Vinny Persky added 1 comment

                File components/autofill/core/browser/payments/credit_card_save_manager.h
                Line 42, Patchset 12:// save logic. Owned by PaymentsFormDataImporter.
                Florian Leimgruber . resolved

                nitty nit: Remove one space

                Vinny Persky

                Done

                Open in Gerrit

                Related details

                Attention is currently required from:
                • Olivia Saul
                Submit Requirements:
                  • requirement satisfiedCode-Coverage
                  • requirement satisfiedCode-Owners
                  • requirement satisfiedCode-Review
                  • requirement satisfiedReview-Enforcement
                  Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                  Gerrit-MessageType: comment
                  Gerrit-Project: chromium/src
                  Gerrit-Branch: main
                  Gerrit-Change-Id: Ie3ce2b7787a80f19c9c1305cb111c644c418c9f1
                  Gerrit-Change-Number: 7599738
                  Gerrit-PatchSet: 13
                  Gerrit-Owner: Vinny Persky <vinny...@google.com>
                  Gerrit-Reviewer: Allen Bauer <kyl...@chromium.org>
                  Gerrit-Reviewer: Florian Leimgruber <fleim...@google.com>
                  Gerrit-Reviewer: Olivia Saul <os...@google.com>
                  Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
                  Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
                  Gerrit-Attention: Olivia Saul <os...@google.com>
                  Gerrit-Comment-Date: Tue, 24 Feb 2026 18:31:41 +0000
                  satisfied_requirement
                  open
                  diffy

                  Olivia Saul (Gerrit)

                  unread,
                  1:55 PM (4 hours ago) 1:55 PM
                  to Vinny Persky, Olivia Saul, Allen Bauer, Florian Leimgruber, Tommy Martino, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tmartino+tran...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, armalhotra+a...@google.com, vinnypersky+...@google.com, siyua+aut...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, osaul+aut...@google.com, browser-comp...@chromium.org
                  Attention needed from Vinny Persky

                  Olivia Saul voted and added 1 comment

                  Votes added by Olivia Saul

                  Code-Review+1

                  1 comment

                  Patchset-level comments
                  File-level comment, Patchset 13 (Latest):
                  Olivia Saul . resolved

                  PS 9->13 LGTM

                  Open in Gerrit

                  Related details

                  Attention is currently required from:
                  • Vinny Persky
                  Submit Requirements:
                  • requirement satisfiedCode-Coverage
                  • requirement satisfiedCode-Owners
                  • requirement satisfiedCode-Review
                  • requirement satisfiedReview-Enforcement
                  Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                  Gerrit-MessageType: comment
                  Gerrit-Project: chromium/src
                  Gerrit-Branch: main
                  Gerrit-Change-Id: Ie3ce2b7787a80f19c9c1305cb111c644c418c9f1
                  Gerrit-Change-Number: 7599738
                  Gerrit-PatchSet: 13
                  Gerrit-Owner: Vinny Persky <vinny...@google.com>
                  Gerrit-Reviewer: Allen Bauer <kyl...@chromium.org>
                  Gerrit-Reviewer: Florian Leimgruber <fleim...@google.com>
                  Gerrit-Reviewer: Olivia Saul <os...@google.com>
                  Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
                  Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
                  Gerrit-Attention: Vinny Persky <vinny...@google.com>
                  Gerrit-Comment-Date: Tue, 24 Feb 2026 18:55:14 +0000
                  Gerrit-HasComments: Yes
                  Gerrit-Has-Labels: Yes
                  satisfied_requirement
                  open
                  diffy

                  Vinny Persky (Gerrit)

                  unread,
                  1:55 PM (4 hours ago) 1:55 PM
                  to Olivia Saul, Allen Bauer, Florian Leimgruber, Tommy Martino, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tmartino+tran...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, armalhotra+a...@google.com, vinnypersky+...@google.com, siyua+aut...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, osaul+aut...@google.com, browser-comp...@chromium.org

                  Vinny Persky voted Commit-Queue+2

                  Commit-Queue+2
                  Open in Gerrit

                  Related details

                  Attention set is empty
                  Submit Requirements:
                  • requirement satisfiedCode-Coverage
                  • requirement satisfiedCode-Owners
                  • requirement satisfiedCode-Review
                  • requirement satisfiedReview-Enforcement
                  Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                  Gerrit-MessageType: comment
                  Gerrit-Project: chromium/src
                  Gerrit-Branch: main
                  Gerrit-Change-Id: Ie3ce2b7787a80f19c9c1305cb111c644c418c9f1
                  Gerrit-Change-Number: 7599738
                  Gerrit-PatchSet: 13
                  Gerrit-Owner: Vinny Persky <vinny...@google.com>
                  Gerrit-Reviewer: Allen Bauer <kyl...@chromium.org>
                  Gerrit-Reviewer: Florian Leimgruber <fleim...@google.com>
                  Gerrit-Reviewer: Olivia Saul <os...@google.com>
                  Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
                  Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
                  Gerrit-Comment-Date: Tue, 24 Feb 2026 18:55:40 +0000
                  Gerrit-HasComments: No
                  Gerrit-Has-Labels: Yes
                  satisfied_requirement
                  open
                  diffy

                  Chromium LUCI CQ (Gerrit)

                  unread,
                  3:09 PM (3 hours ago) 3:09 PM
                  to Vinny Persky, Olivia Saul, Allen Bauer, Florian Leimgruber, Tommy Martino, AyeAye, chromium...@chromium.org, tmartino+tran...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org, armalhotra+a...@google.com, vinnypersky+...@google.com, siyua+aut...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, osaul+aut...@google.com, browser-comp...@chromium.org

                  Chromium LUCI CQ submitted the change

                  Change information

                  Commit message:
                  Move CCSM and credit_card_import_type_ into PaymentsFDI

                  This CL moves CreditCardSaveManager and credit_card_import_type_ into
                  PaymentsFormDataImporter.

                  This CL is a no-op.
                  DD: go/formdataimporter-subdirectory-refactor-design
                  Bug: 481379161
                  Change-Id: Ie3ce2b7787a80f19c9c1305cb111c644c418c9f1
                  Reviewed-by: Allen Bauer <kyl...@chromium.org>
                  Reviewed-by: Olivia Saul <os...@google.com>
                  Commit-Queue: Vinny Persky <vinny...@google.com>
                  Reviewed-by: Tommy Martino <tmar...@chromium.org>
                  Reviewed-by: Florian Leimgruber <fleim...@google.com>
                  Cr-Commit-Position: refs/heads/main@{#1589618}
                  Files:
                  • M chrome/browser/ui/views/autofill/payments/save_card_bubble_views_browsertest.cc
                  • M chrome/browser/ui/views/frame/browser_frame_view_browsertest.cc
                  • M components/autofill/core/browser/form_import/form_data_importer.cc
                  • M components/autofill/core/browser/form_import/form_data_importer.h
                  • M components/autofill/core/browser/form_import/form_data_importer_test_api.h
                  • M components/autofill/core/browser/form_import/form_data_importer_unittest.cc
                  • M components/autofill/core/browser/form_import/payments/payments_form_data_importer.cc
                  • M components/autofill/core/browser/form_import/payments/payments_form_data_importer.h
                  • M components/autofill/core/browser/form_import/payments/payments_form_data_importer_test_api.h
                  • M components/autofill/core/browser/foundations/browser_autofill_manager_unittest.cc
                  • M components/autofill/core/browser/metrics/autofill_metrics_test_base.cc
                  • M components/autofill/core/browser/payments/credit_card_save_manager.h
                  • M components/autofill/core/browser/payments/credit_card_save_manager_unittest.cc
                  • M ios/chrome/browser/autofill/ui_bundled/autofill_app_interface.mm
                  Change size: M
                  Delta: 14 files changed, 135 insertions(+), 104 deletions(-)
                  Branch: refs/heads/main
                  Submit Requirements:
                  • requirement satisfiedCode-Review: +1 by Tommy Martino, +1 by Olivia Saul, +1 by Florian Leimgruber, +1 by Allen Bauer
                  Open in Gerrit
                  Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                  Gerrit-MessageType: merged
                  Gerrit-Project: chromium/src
                  Gerrit-Branch: main
                  Gerrit-Change-Id: Ie3ce2b7787a80f19c9c1305cb111c644c418c9f1
                  Gerrit-Change-Number: 7599738
                  Gerrit-PatchSet: 14
                  Gerrit-Owner: Vinny Persky <vinny...@google.com>
                  Gerrit-Reviewer: Allen Bauer <kyl...@chromium.org>
                  Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
                  Gerrit-Reviewer: Florian Leimgruber <fleim...@google.com>
                  Gerrit-Reviewer: Olivia Saul <os...@google.com>
                  Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
                  Gerrit-Reviewer: Vinny Persky <vinny...@google.com>
                  open
                  diffy
                  satisfied_requirement
                  Reply all
                  Reply to author
                  Forward
                  0 new messages