[iOS] Remove the dispatcher from VoiceSearch [chromium/src : main]
0 views
Skip to first unread message
Gauthier Ambard (Gerrit)
3:32 AM (9 hours ago) 3:32 AM
to Ewann Pellé, Christian Xu, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Christian Xu and Ewann Pellé
Gauthier Ambard voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Christian Xu
- Ewann Pellé
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ewann Pellé (Gerrit)
3:52 AM (9 hours ago) 3:52 AM
to Gauthier Ambard, Chromium LUCI CQ, Christian Xu, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Christian Xu and Gauthier Ambard
Ewann Pellé voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Christian Xu
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christian Xu (Gerrit)
4:47 AM (8 hours ago) 4:47 AM
to Gauthier Ambard, Ewann Pellé, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard
Christian Xu voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gauthier Ambard (Gerrit)
9:26 AM (4 hours ago) 9:26 AM
to Christian Xu, Ewann Pellé, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Gauthier Ambard voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
10:27 AM (3 hours ago) 10:27 AM
to Gauthier Ambard, Christian Xu, Ewann Pellé, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[iOS] Remove the dispatcher from VoiceSearch
The dispatcher is no longer necessary.
To be landed after crrev.com/i/8944556 before crrev.com/i/8944656
Bug: 472279443
Change-Id: Ia1d35543e0272d2756d210981bad320d9f27fdfa
Reviewed-by: Ewann Pellé <ewa...@chromium.org>
Commit-Queue: Gauthier Ambard <gam...@chromium.org>
Reviewed-by: Christian Xu <chris...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1572307}
Files:
- M ios/chrome/browser/browser_view/ui_bundled/browser_coordinator.mm
- M ios/chrome/browser/browser_view/ui_bundled/browser_view_controller.mm
- M ios/chrome/browser/composebox/coordinator/composebox_input_plate_coordinator.mm
- M ios/public/provider/chrome/browser/voice_search/voice_search_controller.h
Change size: S
Delta: 4 files changed, 0 insertions(+), 11 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ewann Pellé, +1 by Christian Xu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages