[Autofill] Initialize strike DBs in CreditCardSaveManager eagerly [chromium/src : main]

0 views

Skip to first unread message

Christoph Schwering (Gerrit)

unread,

10:57 AM (2 hours ago) 10:57 AM

to Jan Keitel, Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

Attention needed from Jan Keitel

Christoph Schwering added 1 comment

File ios/web_view/internal/autofill/web_view_autofill_client_ios.mm

Line 78, Patchset 1 (Parent): form_data_importer_(

Christoph Schwering . unresolved

The new order is to fix a dependency FormDataImporter() --> CreditCardSaveManager() --> AutofillClient::GetStrikeDatabase().

Probably the better way would be to initialize FormDataIMporter lazily like ChromeAutofillClient does.

Open in Gerrit

Related details

Attention is currently required from:

Jan Keitel

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Jan Keitel (Gerrit)

unread,

10:59 AM (2 hours ago) 10:59 AM

to Chromium LUCI CQ, chromium...@chromium.org, armalhotra+a...@google.com, browser-comp...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, vinnypersky+...@google.com

Attention needed from Christoph Schwering

Jan Keitel voted and added 2 comments

Votes added by Jan Keitel

Code-Review

2 comments

Commit Message

Line 10, Patchset 1:CvcStorageStrikeDatabase. The lazi initialization is not needed and

Jan Keitel . unresolved

lazy

File ios/web_view/internal/autofill/web_view_autofill_client_ios.mm

Line 78, Patchset 1 (Parent): form_data_importer_(

Christoph Schwering . resolved

The new order is to fix a dependency FormDataImporter() --> CreditCardSaveManager() --> AutofillClient::GetStrikeDatabase().
Probably the better way would be to initialize FormDataIMporter lazily like ChromeAutofillClient does.

Jan Keitel

Acknowledged