[iOS] Handle x-platform notifications on iOS [chromium/src : main]

0 views
Skip to first unread message

Briana McClure (Gerrit)

unread,
1:58 PM (6 hours ago) 1:58 PM
to Hira Mahmood, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Hira Mahmood

Briana McClure added 1 comment

Patchset-level comments
File-level comment, Patchset 13 (Latest):
Briana McClure . resolved

Hey Hira, PTAL at this change to add Tab Groups and Price Tracking to the CrossPlatformNotificationClient. Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Hira Mahmood
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7ce70e58d26280b8ac2ede6bec99ba01b194a254
Gerrit-Change-Number: 7523608
Gerrit-PatchSet: 13
Gerrit-Owner: Briana McClure <bmcc...@google.com>
Gerrit-Reviewer: Briana McClure <bmcc...@google.com>
Gerrit-Reviewer: Hira Mahmood <hiram...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Hira Mahmood <hiram...@google.com>
Gerrit-Comment-Date: Tue, 24 Feb 2026 18:58:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hira Mahmood (Gerrit)

unread,
2:03 PM (5 hours ago) 2:03 PM
to Briana McClure, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Briana McClure

Hira Mahmood voted and added 1 comment

Votes added by Hira Mahmood

Code-Review+1

1 comment

Patchset-level comments
Hira Mahmood . resolved

lgtm, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Briana McClure
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7ce70e58d26280b8ac2ede6bec99ba01b194a254
    Gerrit-Change-Number: 7523608
    Gerrit-PatchSet: 13
    Gerrit-Owner: Briana McClure <bmcc...@google.com>
    Gerrit-Reviewer: Briana McClure <bmcc...@google.com>
    Gerrit-Reviewer: Hira Mahmood <hiram...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Briana McClure <bmcc...@google.com>
    Gerrit-Comment-Date: Tue, 24 Feb 2026 19:03:53 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Briana McClure (Gerrit)

    unread,
    2:09 PM (5 hours ago) 2:09 PM
    to Scott Yoder, Hira Mahmood, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Scott Yoder

    Briana McClure added 1 comment

    Patchset-level comments
    Briana McClure . resolved

    Hey Scott, PTAL a look at this change to add new TipsNotificationTypes to add Tab Groups and Price Tracking to the CrossPlatformPromosNotificationClient.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Scott Yoder
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7ce70e58d26280b8ac2ede6bec99ba01b194a254
    Gerrit-Change-Number: 7523608
    Gerrit-PatchSet: 13
    Gerrit-Owner: Briana McClure <bmcc...@google.com>
    Gerrit-Reviewer: Briana McClure <bmcc...@google.com>
    Gerrit-Reviewer: Hira Mahmood <hiram...@google.com>
    Gerrit-Reviewer: Scott Yoder <scott...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Scott Yoder <scott...@google.com>
    Gerrit-Comment-Date: Tue, 24 Feb 2026 19:09:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Scott Yoder (Gerrit)

    unread,
    2:20 PM (5 hours ago) 2:20 PM
    to Briana McClure, Hira Mahmood, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Briana McClure

    Scott Yoder voted and added 1 comment

    Votes added by Scott Yoder

    Code-Review+1

    1 comment

    Patchset-level comments
    Scott Yoder . resolved

    LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Briana McClure
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7ce70e58d26280b8ac2ede6bec99ba01b194a254
    Gerrit-Change-Number: 7523608
    Gerrit-PatchSet: 13
    Gerrit-Owner: Briana McClure <bmcc...@google.com>
    Gerrit-Reviewer: Briana McClure <bmcc...@google.com>
    Gerrit-Reviewer: Hira Mahmood <hiram...@google.com>
    Gerrit-Reviewer: Scott Yoder <scott...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Briana McClure <bmcc...@google.com>
    Gerrit-Comment-Date: Tue, 24 Feb 2026 19:20:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Briana McClure (Gerrit)

    unread,
    2:26 PM (5 hours ago) 2:26 PM
    to Scott Yoder, Hira Mahmood, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

    Briana McClure added 1 comment

    Patchset-level comments
    Briana McClure . resolved

    Hey Ginny, PTAL at tools/metrics/histograms/metadata/ios/enums.xml, thanks!

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7ce70e58d26280b8ac2ede6bec99ba01b194a254
    Gerrit-Change-Number: 7523608
    Gerrit-PatchSet: 13
    Gerrit-Owner: Briana McClure <bmcc...@google.com>
    Gerrit-Reviewer: Briana McClure <bmcc...@google.com>
    Gerrit-Reviewer: Hira Mahmood <hiram...@google.com>
    Gerrit-Reviewer: Scott Yoder <scott...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Comment-Date: Tue, 24 Feb 2026 19:26:35 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ginny Huang (Gerrit)

    unread,
    2:27 PM (5 hours ago) 2:27 PM
    to Briana McClure, Scott Yoder, Hira Mahmood, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Briana McClure

    Ginny Huang voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Briana McClure
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7ce70e58d26280b8ac2ede6bec99ba01b194a254
    Gerrit-Change-Number: 7523608
    Gerrit-PatchSet: 13
    Gerrit-Owner: Briana McClure <bmcc...@google.com>
    Gerrit-Reviewer: Briana McClure <bmcc...@google.com>
    Gerrit-Reviewer: Ginny Huang <ginny...@chromium.org>
    Gerrit-Reviewer: Hira Mahmood <hiram...@google.com>
    Gerrit-Reviewer: Scott Yoder <scott...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Briana McClure <bmcc...@google.com>
    Gerrit-Comment-Date: Tue, 24 Feb 2026 19:27:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Briana McClure (Gerrit)

    unread,
    2:28 PM (5 hours ago) 2:28 PM
    to Ginny Huang, Scott Yoder, Hira Mahmood, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

    Briana McClure voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7ce70e58d26280b8ac2ede6bec99ba01b194a254
    Gerrit-Change-Number: 7523608
    Gerrit-PatchSet: 13
    Gerrit-Owner: Briana McClure <bmcc...@google.com>
    Gerrit-Reviewer: Briana McClure <bmcc...@google.com>
    Gerrit-Reviewer: Ginny Huang <ginny...@chromium.org>
    Gerrit-Reviewer: Hira Mahmood <hiram...@google.com>
    Gerrit-Reviewer: Scott Yoder <scott...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Comment-Date: Tue, 24 Feb 2026 19:28:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    2:32 PM (5 hours ago) 2:32 PM
    to Briana McClure, Ginny Huang, Scott Yoder, Hira Mahmood, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [iOS] Handle x-platform notifications on iOS

    This change configures the CrossPlatformPromosNotificationClient to
    receive the Tab Groups and Price Tracking x-platform promo notifications
    on iOS.

    Related Changes:
    * create the Tab Groups and Price Tracking NotificationType
    * create the Tab Groups and Price Tracking TipsNotificationType
    * updates the TipsNotificationCriteria
    * creates stubs for presenting the Tab Groups and Price Tracking promos that will be created in follow up changes
    Fixed: 482043403
    Change-Id: I7ce70e58d26280b8ac2ede6bec99ba01b194a254
    Reviewed-by: Hira Mahmood <hiram...@google.com>
    Commit-Queue: Briana McClure <bmcc...@google.com>
    Reviewed-by: Scott Yoder <scott...@google.com>
    Reviewed-by: Ginny Huang <ginny...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1589593}
    Files:
    Change size: M
    Delta: 10 files changed, 64 insertions(+), 6 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Ginny Huang, +1 by Hira Mahmood, +1 by Scott Yoder
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7ce70e58d26280b8ac2ede6bec99ba01b194a254
    Gerrit-Change-Number: 7523608
    Gerrit-PatchSet: 14
    Gerrit-Owner: Briana McClure <bmcc...@google.com>
    Gerrit-Reviewer: Briana McClure <bmcc...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Ginny Huang <ginny...@chromium.org>
    Gerrit-Reviewer: Hira Mahmood <hiram...@google.com>
    Gerrit-Reviewer: Scott Yoder <scott...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages