[iOS] Handle x-platform notifications on iOS [chromium/src : main]
0 views
Skip to first unread message
Briana McClure (Gerrit)
1:58 PM (6 hours ago) 1:58 PM
to Hira Mahmood, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Hira Mahmood
Briana McClure added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 13 (Latest):
Briana McClure . resolved
Hey Hira, PTAL at this change to add Tab Groups and Price Tracking to the CrossPlatformNotificationClient. Thanks!
Related details
Attention is currently required from:
- Hira Mahmood
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Hira Mahmood (Gerrit)
2:03 PM (5 hours ago) 2:03 PM
to Briana McClure, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Briana McClure
Hira Mahmood voted and added 1 comment![]( "Open in Gerrit")
Votes added by Hira Mahmood
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Briana McClure
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Briana McClure (Gerrit)
2:09 PM (5 hours ago) 2:09 PM
to Scott Yoder, Hira Mahmood, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Scott Yoder
Briana McClure added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Briana McClure . resolved
Hey Scott, PTAL a look at this change to add new TipsNotificationTypes to add Tab Groups and Price Tracking to the CrossPlatformPromosNotificationClient.
Related details
Attention is currently required from:
- Scott Yoder
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Yoder (Gerrit)
2:20 PM (5 hours ago) 2:20 PM
to Briana McClure, Hira Mahmood, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Briana McClure
Scott Yoder voted and added 1 comment![]( "Open in Gerrit")
Votes added by Scott Yoder
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Briana McClure
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Briana McClure (Gerrit)
2:26 PM (5 hours ago) 2:26 PM
to Scott Yoder, Hira Mahmood, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Briana McClure added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Briana McClure . resolved
Hey Ginny, PTAL at tools/metrics/histograms/metadata/ios/enums.xml, thanks!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ginny Huang (Gerrit)
2:27 PM (5 hours ago) 2:27 PM
to Briana McClure, Scott Yoder, Hira Mahmood, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Briana McClure
Ginny Huang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Briana McClure
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Briana McClure (Gerrit)
2:28 PM (5 hours ago) 2:28 PM
to Ginny Huang, Scott Yoder, Hira Mahmood, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Briana McClure voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
2:32 PM (5 hours ago) 2:32 PM
to Briana McClure, Ginny Huang, Scott Yoder, Hira Mahmood, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Handle x-platform notifications on iOS
This change configures the CrossPlatformPromosNotificationClient to
receive the Tab Groups and Price Tracking x-platform promo notifications
on iOS.
Related Changes:
* create the Tab Groups and Price Tracking NotificationType
* create the Tab Groups and Price Tracking TipsNotificationType
* updates the TipsNotificationCriteria
* creates stubs for presenting the Tab Groups and Price Tracking promos that will be created in follow up changes
Fixed: 482043403
Change-Id: I7ce70e58d26280b8ac2ede6bec99ba01b194a254
Reviewed-by: Hira Mahmood <hiram...@google.com>
Commit-Queue: Briana McClure <bmcc...@google.com>
Reviewed-by: Scott Yoder <scott...@google.com>
Reviewed-by: Ginny Huang <ginny...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1589593}
Files:
- M ios/chrome/browser/cross_platform_promos/model/cross_platform_promos_notification_client.mm
- M ios/chrome/browser/cross_platform_promos/model/cross_platform_promos_service.h
- M ios/chrome/browser/cross_platform_promos/model/cross_platform_promos_service.mm
- M ios/chrome/browser/push_notification/model/constants.h
- M ios/chrome/browser/tips_notifications/model/tips_notification_criteria.mm
- M ios/chrome/browser/tips_notifications/model/tips_notification_presenter.h
- M ios/chrome/browser/tips_notifications/model/tips_notification_presenter.mm
- M ios/chrome/browser/tips_notifications/model/utils.h
- M ios/chrome/browser/tips_notifications/model/utils.mm
- M tools/metrics/histograms/metadata/ios/enums.xml
Change size: M
Delta: 10 files changed, 64 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ginny Huang, +1 by Hira Mahmood, +1 by Scott Yoder
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages