[iOS] Use the normal badge workflow for next [chromium/src : main]

0 views
Skip to first unread message

Gauthier Ambard (Gerrit)

unread,
Apr 3, 2026, 3:59:46 AM (2 days ago) Apr 3
to Ibrahim Kanouche, chromium...@chromium.org, christia...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Ibrahim Kanouche

Gauthier Ambard voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ibrahim Kanouche
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie3ef26456fa3f56f4c7f361d8b793aecb46ad75a
Gerrit-Change-Number: 7726242
Gerrit-PatchSet: 1
Gerrit-Owner: Gauthier Ambard <gam...@chromium.org>
Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>
Gerrit-Reviewer: Ibrahim Kanouche <kano...@google.com>
Gerrit-Attention: Ibrahim Kanouche <kano...@google.com>
Gerrit-Comment-Date: Fri, 03 Apr 2026 07:59:34 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ibrahim Kanouche (Gerrit)

unread,
Apr 3, 2026, 6:23:24 PM (2 days ago) Apr 3
to Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard

Ibrahim Kanouche voted and added 2 comments

Votes added by Ibrahim Kanouche

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Ibrahim Kanouche . resolved

LGTM with one nit! Thanks!

File ios/chrome/browser/location_bar/ui_bundled/location_bar_coordinator.mm
Line 355, Patchset 2 (Latest): if (isIncognito && !IsChromeNextIaEnabled()) {
Ibrahim Kanouche . unresolved

Nit: Incognito badge suppression lacks explanatory comment

Open in Gerrit

Related details

Attention is currently required from:
  • Gauthier Ambard
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie3ef26456fa3f56f4c7f361d8b793aecb46ad75a
    Gerrit-Change-Number: 7726242
    Gerrit-PatchSet: 2
    Gerrit-Owner: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Reviewer: Ibrahim Kanouche <kano...@google.com>
    Gerrit-Attention: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 22:23:13 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages