[iOS] Use the normal badge workflow for next [chromium/src : main]

0 views

Skip to first unread message

Gauthier Ambard (Gerrit)

unread,

Apr 3, 2026, 3:59:46 AM (2 days ago) Apr 3

to Ibrahim Kanouche, chromium...@chromium.org, christia...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Ibrahim Kanouche

Gauthier Ambard voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Ibrahim Kanouche

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ibrahim Kanouche (Gerrit)

unread,

Apr 3, 2026, 6:23:24 PM (2 days ago) Apr 3

to Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Gauthier Ambard

Ibrahim Kanouche voted and added 2 comments

Votes added by Ibrahim Kanouche

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Ibrahim Kanouche . resolved

LGTM with one nit! Thanks!

File ios/chrome/browser/location_bar/ui_bundled/location_bar_coordinator.mm

Line 355, Patchset 2 (Latest): if (isIncognito && !IsChromeNextIaEnabled()) {

Ibrahim Kanouche . unresolved

Nit: Incognito badge suppression lacks explanatory comment