[iOS] Update InvalidateInsetRange() invocations [chromium/src : main]

0 views
Skip to first unread message

Hira Mahmood (Gerrit)

unread,
Apr 3, 2026, 4:14:57 PM (2 days ago) Apr 3
to Scott Yoder, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, marq+...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org
Attention needed from Scott Yoder

Hira Mahmood added 1 comment

Patchset-level comments
File-level comment, Patchset 6 (Latest):
Hira Mahmood . resolved

PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Scott Yoder
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0c408cfff9961e580a347dfa7965210731cb203a
Gerrit-Change-Number: 7726612
Gerrit-PatchSet: 6
Gerrit-Owner: Hira Mahmood <hiram...@google.com>
Gerrit-Reviewer: Hira Mahmood <hiram...@google.com>
Gerrit-Reviewer: Scott Yoder <scott...@google.com>
Gerrit-Attention: Scott Yoder <scott...@google.com>
Gerrit-Comment-Date: Fri, 03 Apr 2026 20:14:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Scott Yoder (Gerrit)

unread,
Apr 3, 2026, 4:29:42 PM (2 days ago) Apr 3
to Hira Mahmood, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, marq+...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org
Attention needed from Hira Mahmood

Scott Yoder voted and added 2 comments

Votes added by Scott Yoder

Code-Review+1

2 comments

Patchset-level comments
Scott Yoder . resolved

LGTM, but I think the test is failing.

File ios/chrome/browser/fullscreen/coordinator/fullscreen_mediator.mm
Line 299, Patchset 6 (Latest): _browserAgent->InvalidateInsetRange(PassKey());
Scott Yoder . unresolved

nit: one use case I'm not sure how to improve is if the user has a bottom omnibox, a rotation causes an omnibox position change too, so this would get called twice. I would say we can investigate that later though.

Open in Gerrit

Related details

Attention is currently required from:
  • Hira Mahmood
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I0c408cfff9961e580a347dfa7965210731cb203a
Gerrit-Change-Number: 7726612
Gerrit-PatchSet: 6
Gerrit-Owner: Hira Mahmood <hiram...@google.com>
Gerrit-Reviewer: Hira Mahmood <hiram...@google.com>
Gerrit-Reviewer: Scott Yoder <scott...@google.com>
Gerrit-Attention: Hira Mahmood <hiram...@google.com>
Gerrit-Comment-Date: Fri, 03 Apr 2026 20:29:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Scott Yoder (Gerrit)

unread,
Apr 3, 2026, 4:31:20 PM (2 days ago) Apr 3
to Hira Mahmood, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, marq+...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, ios-r...@chromium.org
Attention needed from Hira Mahmood

Scott Yoder added 1 comment

File ios/chrome/browser/fullscreen/coordinator/fullscreen_mediator.mm
Line 20, Patchset 6 (Latest):#import "ios/web/public/navigation/navigation_context.h"
Scott Yoder . unresolved

I'm not sure it matters, but this import is only needed for your other CL, I think?

Gerrit-Comment-Date: Fri, 03 Apr 2026 20:31:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages