[iOS] Make PageContextWrapper one time use by CHECKing on double extract [chromium/src : main]
0 views
Skip to first unread message
Nicolas MacBeth (Gerrit)
1:34 PM (6 hours ago) 1:34 PM
to Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Adam Arcaro
Nicolas MacBeth added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Adam Arcaro
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Adam Arcaro (Gerrit)
3:48 PM (4 hours ago) 3:48 PM
to Nicolas MacBeth, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Nicolas MacBeth
Adam Arcaro voted and added 1 comment![]( "Open in Gerrit")
Votes added by Adam Arcaro
| Code-Review | +1 |
1 comment
Patchset-level comments
Adam Arcaro . unresolved
I assume this won't fail for the case where multiple features generate page context concurrently (e.g. base Helios and ZSS), since it's only if the same wrapper triggers extraction twice?
Related details
Attention is currently required from:
- Nicolas MacBeth
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolas MacBeth (Gerrit)
4:48 PM (3 hours ago) 4:48 PM
to Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Nicolas MacBeth added 2 comments![]( "Open in Gerrit")
Patchset-level comments
I assume this won't fail for the case where multiple features generate page context concurrently (e.g. base Helios and ZSS), since it's only if the same wrapper triggers extraction twice?
Nicolas MacBeth
correct, it's specifically to stop clients from doing the latter.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nicolas MacBeth (Gerrit)
4:48 PM (3 hours ago) 4:48 PM
to Adam Arcaro, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Nicolas MacBeth voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
5:47 PM (2 hours ago) 5:47 PM
to Nicolas MacBeth, Adam Arcaro, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ios/chrome/browser/intelligence/proto_wrappers/page_context_wrapper.mm
Insertions: 1, Deletions: 1.
@@ -291,7 +291,7 @@
}
- (void)populatePageContextFieldsAsyncWithTimeout:(base::TimeDelta)timeout {
- CHECK(!_executionStarted);
+ CHECK(!_executionStarted) << "A PageContextWrapper should only be used once.";
_executionStarted = YES;
if (_isLowPriorityExtraction) {
```
Change information
Commit message:
[iOS] Make PageContextWrapper one time use by CHECKing on double extract
Fixed: 487264526
Change-Id: I60ae6b5bd49b3431ce293a2ad8c517f100bd9569
Commit-Queue: Nicolas MacBeth <nicolas...@google.com>
Reviewed-by: Adam Arcaro <ada...@google.com>
Cr-Commit-Position: refs/heads/main@{#1589721}
Files:
- M ios/chrome/browser/intelligence/proto_wrappers/page_context_wrapper.mm
- M ios/chrome/browser/intelligence/proto_wrappers/page_context_wrapper_unittest.mm
Change size: S
Delta: 2 files changed, 18 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Adam Arcaro
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages