Update JS Error Report params [chromium/src : main]
0 views
Skip to first unread message
Mike Dougherty (Gerrit)
Feb 23, 2026, 6:37:20 PM (23 hours ago) Feb 23
to Alexandra Pereira, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Alexandra Pereira
Mike Dougherty voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Alexandra Pereira
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexandra Pereira (Gerrit)
12:56 PM (5 hours ago) 12:56 PM
to Mike Dougherty, Chromium LUCI CQ, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Mike Dougherty
Alexandra Pereira voted and added 2 comments![]( "Open in Gerrit")
Votes added by Alexandra Pereira
| Code-Review | +1 |
2 comments
Patchset-level comments
File ios/web/js_messaging/web_frame_impl.mm
Line 84, Patchset 1 (Latest):
NSString* ns_exception = error.userInfo[@"WKJavaScriptExceptionMessage"];Alexandra Pereira . unresolved
nit: can you please move this line into the if block?
Related details
Attention is currently required from:
- Mike Dougherty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike Dougherty (Gerrit)
1:29 PM (5 hours ago) 1:29 PM
to Alexandra Pereira, Chromium LUCI CQ, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Alexandra Pereira
Mike Dougherty added 1 comment![]( "Open in Gerrit")
File ios/web/js_messaging/web_frame_impl.mm
Line 84, Patchset 1 (Latest):
NSString* ns_exception = error.userInfo[@"WKJavaScriptExceptionMessage"];Alexandra Pereira . unresolved
nit: can you please move this line into the if block?
Mike Dougherty
This string is used on line 115, so I left it here instead of putting it into the block since that condition is usually going to be checked as well. wdyt about leaving it here?
Related details
Attention is currently required from:
- Alexandra Pereira
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexandra Pereira (Gerrit)
1:56 PM (4 hours ago) 1:56 PM
to Mike Dougherty, Chromium LUCI CQ, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Mike Dougherty
Alexandra Pereira added 1 comment![]( "Open in Gerrit")
File ios/web/js_messaging/web_frame_impl.mm
Line 84, Patchset 1 (Latest):
NSString* ns_exception = error.userInfo[@"WKJavaScriptExceptionMessage"];Alexandra Pereira . resolved
Mike Doughertynit: can you please move this line into the if block?
This string is used on line 115, so I left it here instead of putting it into the block since that condition is usually going to be checked as well. wdyt about leaving it here?
Attention is currently required from:
- Mike Dougherty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alexandra Pereira (Gerrit)
1:56 PM (4 hours ago) 1:56 PM
to Mike Dougherty, Chromium LUCI CQ, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Mike Dougherty
Alexandra Pereira voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Mike Dougherty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
2:00 PM (4 hours ago) 2:00 PM
to Mike Dougherty, Alexandra Pereira, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Update JS Error Report params
- Replace url with page_url to allow better grouping of reports
- Add url filename extension to report (if available). This isn't as
reliable as MIME type, but it does provide some context about the larger
URL since only the scheme and host are available in the URL.
- Add error domain and code to native reports to assist with better
grouping because error messages are localized.
Bug: 482086863
Change-Id: I9d41beae11c240aef944ab43518f54c6d0611f06
Reviewed-by: Alexandra Pereira <alexa...@google.com>
Commit-Queue: Alexandra Pereira <alexa...@google.com>
Cr-Commit-Position: refs/heads/main@{#1589565}
Files:
- M ios/web/js_features/window_error/ios_javascript_error_report.h
- M ios/web/js_features/window_error/web_js_error_report_processor.h
- M ios/web/js_features/window_error/web_js_error_report_processor.mm
- M ios/web/js_messaging/web_frame_impl.mm
Change size: M
Delta: 4 files changed, 62 insertions(+), 21 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alexandra Pereira
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages