[ios] Fix typo in obscuredInsets property [chromium/src : main]
0 views
Skip to first unread message
Scott Yoder (Gerrit)
Apr 3, 2026, 4:02:44 PM (2 days ago) Apr 3
to Gauthier Ambard, Aliona Dangla, Chromium LUCI CQ, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Gauthier Ambard
Scott Yoder added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Scott Yoder . resolved
Please take a look. I wish I could take credit for spotting this, but Jetski found this when I asked it why setting obscuredInsets wasn't causing sticky bottom elements to position properly with the refactor (that part of the refactor hasn't made it into a CL yet, but hopefully next week).
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Yoder (Gerrit)
Apr 3, 2026, 4:07:19 PM (2 days ago) Apr 3
to Mike Dougherty, Gauthier Ambard, Aliona Dangla, Chromium LUCI CQ, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Gauthier Ambard and Mike Dougherty
Scott Yoder added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Gauthier Ambard
- Mike Dougherty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike Dougherty (Gerrit)
Apr 3, 2026, 4:26:55 PM (2 days ago) Apr 3
to Scott Yoder, Gauthier Ambard, Aliona Dangla, Chromium LUCI CQ, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Gauthier Ambard and Scott Yoder
Mike Dougherty voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Gauthier Ambard
- Scott Yoder
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Yoder (Gerrit)
Apr 3, 2026, 4:27:56 PM (2 days ago) Apr 3
to Mike Dougherty, Gauthier Ambard, Aliona Dangla, Chromium LUCI CQ, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Attention needed from Gauthier Ambard
Scott Yoder voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Gauthier Ambard
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 3, 2026, 5:33:04 PM (2 days ago) Apr 3
to Scott Yoder, Mike Dougherty, Gauthier Ambard, Aliona Dangla, chromium...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[ios] Fix typo in obscuredInsets property
This typo didn't cause any compiler issues because the `obscuredInsets`
property is already defined and its getter and setter would have been
generated. But because of the typo, the actual WebKit API was never
being called.
Change-Id: Ic9f54b0a2714c568111b6620428c5217ea31d670
Reviewed-by: Mike Dougherty <mich...@chromium.org>
Commit-Queue: Scott Yoder <scott...@google.com>
Cr-Commit-Position: refs/heads/main@{#1609955}
Files:
- M ios/web/web_state/ui/crw_web_view_content_view.mm
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mike Dougherty
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages