Add base class for *_java_script_feature_unittest.mm. [chromium/src : main]
Kirubel Aklilu (Gerrit)
Message from Kirubel Aklilu![]( "Open in Gerrit")
Set Ready For Review
Related details
- Kirubel Aklilu
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kirubel Aklilu (Gerrit)
Kirubel Aklilu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kirubel Aklilu
| Commit-Queue | +1 |
1 comment
ginnyhuang@, can you review this CL?
This will make the scroll_tool_java_script_feature_unittest.mm simpler in the child CL. I plan to refactor the click_tool_java_script_feature_unittest.mm and type_tool_java_script_feature_unittest.mm onto this base class going forward.
Related details
- Ginny Huang
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ginny Huang (Gerrit)
Ginny Huang voted and added 2 comments![]( "Open in Gerrit")
Votes added by Ginny Huang
| Code-Review | +1 |
2 comments
// https://chromium-review.git.corp.google.com/c/chromium/src/+/7619313/comment/35fa164c_4cdd1f96/Maybe use "https://chromium-review.googlesource.com/"? Or even better, summarize the comment thread instead of providing a link.
Related details
- Kirubel Aklilu
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kirubel Aklilu (Gerrit)
Kirubel Aklilu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kirubel Aklilu
| Commit-Queue | +2 |
1 comment
Maybe use "https://chromium-review.googlesource.com/"? Or even better, summarize the comment thread instead of providing a link.
Added a summary. Unfortunately, looks like you can't link to comments on `chromium-review.googlesource.com/"` for some reason.
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ginny Huang (Gerrit)
Ginny Huang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ginny Huang
| Code-Review | +1 |
1 comment
Kirubel AkliluMaybe use "https://chromium-review.googlesource.com/"? Or even better, summarize the comment thread instead of providing a link.
Added a summary. Unfortunately, looks like you can't link to comments on `chromium-review.googlesource.com/"` for some reason.
New comment LGTM except a super-duper nit: s/Javascript/JavaScript/g (Too hard to un-notice once I see it, sorry)
The unlinkable-comment issue you mentioned looks like a corp/non-corp redirect bug 🤷♀️ It will work if you aren't logged into your corp account (I just tried on a different browser)
Related details
- Kirubel Aklilu
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kirubel Aklilu (Gerrit)
Kirubel Aklilu voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kirubel Aklilu
| Commit-Queue | +2 |
1 comment
Kirubel AkliluMaybe use "https://chromium-review.googlesource.com/"? Or even better, summarize the comment thread instead of providing a link.
Ginny HuangAdded a summary. Unfortunately, looks like you can't link to comments on `chromium-review.googlesource.com/"` for some reason.
New comment LGTM except a super-duper nit: s/Javascript/JavaScript/g (Too hard to un-notice once I see it, sorry)
The unlinkable-comment issue you mentioned looks like a corp/non-corp redirect bug 🤷♀️ It will work if you aren't logged into your corp account (I just tried on a different browser)
Good point, renamed
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ios/chrome/browser/intelligence/actor/tools/model/actor_tool_java_script_feature_test_base.mm
Insertions: 2, Deletions: 2.
@@ -17,9 +17,9 @@
namespace actor {
-// This base class uses the real ChromeWebClient so that the required Javascript
+// This base class uses the real ChromeWebClient so that the required JavaScript
// files are loaded. If the FakeWebClient is used, all calls to the underlying
-// Javascript files must be mocked with MockJsFunction.
+// JavaScript files must be mocked with MockJsFunction.
ActorToolJavaScriptFeatureTestBase::ActorToolJavaScriptFeatureTestBase()
: IOSChromeTestWithWebState(WebClientMode::kChromeWebClient) {
scoped_feature_list_.InitWithFeatures(
```
Change information
Add base class for *_java_script_feature_unittest.mm.
There is some code that can be shared and to reduce complexity
in each test.
- M ios/chrome/browser/intelligence/actor/tools/model/BUILD.gn
- A ios/chrome/browser/intelligence/actor/tools/model/actor_tool_java_script_feature_test_base.h
- A ios/chrome/browser/intelligence/actor/tools/model/actor_tool_java_script_feature_test_base.mm
Code-Review: +1 by Ginny Huang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |