feat: Use appropriate computation state in the browser agent [chromium/src : main]

0 views
Skip to first unread message

Nicolas MacBeth (Gerrit)

unread,
Jan 16, 2026, 3:26:00 PM (5 days ago) Jan 16
to Francis Beauchamp, Chromium LUCI CQ, Adam Arcaro, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Adam Arcaro and Francis Beauchamp

Nicolas MacBeth added 4 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Nicolas MacBeth . resolved

thanks PTAL at these comments

File ios/chrome/browser/intelligence/bwg/model/bwg_browser_agent.mm
Line 237, Patchset 3 (Latest): ios::provider::BWGPageContextComputationState::kSuccess, entry_point);
Nicolas MacBeth . unresolved

what about this call site? should it also have the check?

Line 294, Patchset 3 (Latest): if (tab_helper) {
gemini_page_context.BWGPageContextComputationState =
tab_helper->GetIsGeminiEligible()
? ios::provider::BWGPageContextComputationState::kSuccess
: ios::provider::BWGPageContextComputationState::kBlocked;
}
Nicolas MacBeth . unresolved

nit: prefer early return instead of nesting this code

Line 559, Patchset 3 (Latest): ios::provider::BWGPageContextComputationState::kSuccess, entry_point,
Nicolas MacBeth . unresolved

Ditto: what about this call site? should it also have the check?

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Arcaro
  • Francis Beauchamp
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I56760923f219184e0d6b251561f386acc5effb6f
Gerrit-Change-Number: 7464659
Gerrit-PatchSet: 3
Gerrit-Owner: Francis Beauchamp <fbeau...@google.com>
Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
Gerrit-Reviewer: Francis Beauchamp <fbeau...@google.com>
Gerrit-Reviewer: Nicolas MacBeth <nicolas...@google.com>
Gerrit-Attention: Adam Arcaro <ada...@google.com>
Gerrit-Attention: Francis Beauchamp <fbeau...@google.com>
Gerrit-Comment-Date: Fri, 16 Jan 2026 20:25:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Francis Beauchamp (Gerrit)

unread,
Jan 19, 2026, 3:53:08 PM (2 days ago) Jan 19
to Chromium LUCI CQ, Adam Arcaro, Nicolas MacBeth, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Adam Arcaro

Francis Beauchamp added 2 comments

File ios/chrome/browser/intelligence/bwg/model/bwg_browser_agent.mm
Line 237, Patchset 3 (Latest): ios::provider::BWGPageContextComputationState::kSuccess, entry_point);
Nicolas MacBeth . unresolved

what about this call site? should it also have the check?

Francis Beauchamp

Similarly here, it is bound by the `IsGeminiImmediateOverlayEnabled` check being `false`. Do we want that path supported too @ada...@google.com?

Line 559, Patchset 3 (Latest): ios::provider::BWGPageContextComputationState::kSuccess, entry_point,
Nicolas MacBeth . unresolved

Ditto: what about this call site? should it also have the check?

Francis Beauchamp

I think this is for the synchronous path. I wasn't certain if we wanted to update this one as well @ada...@google.com?

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Arcaro
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I56760923f219184e0d6b251561f386acc5effb6f
Gerrit-Change-Number: 7464659
Gerrit-PatchSet: 3
Gerrit-Owner: Francis Beauchamp <fbeau...@google.com>
Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
Gerrit-Reviewer: Francis Beauchamp <fbeau...@google.com>
Gerrit-Reviewer: Nicolas MacBeth <nicolas...@google.com>
Gerrit-Attention: Adam Arcaro <ada...@google.com>
Gerrit-Comment-Date: Mon, 19 Jan 2026 20:53:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicolas MacBeth <nicolas...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Adam Arcaro (Gerrit)

unread,
Jan 19, 2026, 4:06:54 PM (2 days ago) Jan 19
to Francis Beauchamp, Chromium LUCI CQ, Nicolas MacBeth, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Francis Beauchamp and Nicolas MacBeth

Adam Arcaro added 2 comments

File ios/chrome/browser/intelligence/bwg/model/bwg_browser_agent.mm
Line 237, Patchset 3 (Latest): ios::provider::BWGPageContextComputationState::kSuccess, entry_point);
Nicolas MacBeth . resolved

what about this call site? should it also have the check?

Francis Beauchamp

Similarly here, it is bound by the `IsGeminiImmediateOverlayEnabled` check being `false`. Do we want that path supported too @ada...@google.com?

Adam Arcaro

We don't need to support this since we'll be launching immediate overlay in M144

Line 559, Patchset 3 (Latest): ios::provider::BWGPageContextComputationState::kSuccess, entry_point,
Nicolas MacBeth . unresolved

Ditto: what about this call site? should it also have the check?

Francis Beauchamp

I think this is for the synchronous path. I wasn't certain if we wanted to update this one as well @ada...@google.com?

Adam Arcaro

I believe this is only called with immediate overlay disabled, so we don't need to support this path either

Open in Gerrit

Related details

Attention is currently required from:
  • Francis Beauchamp
  • Nicolas MacBeth
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I56760923f219184e0d6b251561f386acc5effb6f
Gerrit-Change-Number: 7464659
Gerrit-PatchSet: 3
Gerrit-Owner: Francis Beauchamp <fbeau...@google.com>
Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
Gerrit-Reviewer: Francis Beauchamp <fbeau...@google.com>
Gerrit-Reviewer: Nicolas MacBeth <nicolas...@google.com>
Gerrit-Attention: Nicolas MacBeth <nicolas...@google.com>
Gerrit-Attention: Francis Beauchamp <fbeau...@google.com>
Gerrit-Comment-Date: Mon, 19 Jan 2026 21:06:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nicolas MacBeth <nicolas...@google.com>
Comment-In-Reply-To: Francis Beauchamp <fbeau...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Francis Beauchamp (Gerrit)

unread,
10:32 AM (2 hours ago) 10:32 AM
to Chromium LUCI CQ, Adam Arcaro, Nicolas MacBeth, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Adam Arcaro

Francis Beauchamp added 3 comments

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Francis Beauchamp . resolved

Updated the CL so it now uses the `std::optional` instead of the original `bool` value.

File ios/chrome/browser/intelligence/bwg/model/bwg_browser_agent.mm
Line 294, Patchset 3: if (tab_helper) {

gemini_page_context.BWGPageContextComputationState =
tab_helper->GetIsGeminiEligible()
? ios::provider::BWGPageContextComputationState::kSuccess
: ios::provider::BWGPageContextComputationState::kBlocked;
}
Nicolas MacBeth . resolved

nit: prefer early return instead of nesting this code

Francis Beauchamp

Done

Line 559, Patchset 3: ios::provider::BWGPageContextComputationState::kSuccess, entry_point,
Nicolas MacBeth . resolved

Ditto: what about this call site? should it also have the check?

Francis Beauchamp

I think this is for the synchronous path. I wasn't certain if we wanted to update this one as well @ada...@google.com?

Adam Arcaro

I believe this is only called with immediate overlay disabled, so we don't need to support this path either

Francis Beauchamp

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Adam Arcaro
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I56760923f219184e0d6b251561f386acc5effb6f
    Gerrit-Change-Number: 7464659
    Gerrit-PatchSet: 5
    Gerrit-Owner: Francis Beauchamp <fbeau...@google.com>
    Gerrit-Reviewer: Adam Arcaro <ada...@google.com>
    Gerrit-Reviewer: Francis Beauchamp <fbeau...@google.com>
    Gerrit-Reviewer: Nicolas MacBeth <nicolas...@google.com>
    Gerrit-Attention: Adam Arcaro <ada...@google.com>
    Gerrit-Comment-Date: Wed, 21 Jan 2026 15:32:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Nicolas MacBeth <nicolas...@google.com>
    Comment-In-Reply-To: Adam Arcaro <ada...@google.com>
    Comment-In-Reply-To: Francis Beauchamp <fbeau...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages