[iOS] Fix duplicate tabs when allowing blocked popups [chromium/src : main]
0 views
Skip to first unread message
Chris Lu (Gerrit)
Apr 3, 2026, 11:48:18 AM (2 days ago) Apr 3
to Xiaobin Cui, Leo Zhao, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Leo Zhao and Xiaobin Cui
Chris Lu voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Leo Zhao
- Xiaobin Cui
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Leo Zhao (Gerrit)
Apr 4, 2026, 10:44:07 AM (yesterday) Apr 4
to Xiaobin Cui, Chris Lu, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Xiaobin Cui
Leo Zhao voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Xiaobin Cui
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaobin Cui (Gerrit)
Apr 4, 2026, 8:11:51 PM (19 hours ago) Apr 4
to Leo Zhao, Chris Lu, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Xiaobin Cui voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 4, 2026, 10:08:24 PM (17 hours ago) Apr 4
to Xiaobin Cui, Leo Zhao, Chris Lu, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Fix duplicate tabs when allowing blocked popups
Fix by storing the InfobarType in the handler and guarding
MainButtonTapped and BannerVisibilityChanged with a type check,
matching the pattern already used by
DefaultInfobarBannerInteractionHandler.
Bug: 499103609
Change-Id: I7c3ff3bc09ac0a625d13465c8df9b057f31489d7
Reviewed-by: Chris Lu <thegre...@chromium.org>
Commit-Queue: Xiaobin Cui <xiaob...@microsoft.com>
Reviewed-by: Leo Zhao <leo...@google.com>
Cr-Commit-Position: refs/heads/main@{#1610154}
Files:
- M ios/chrome/browser/infobars/model/overlays/browser_agent/infobar_overlay_browser_agent_util.mm
- M ios/chrome/browser/infobars/model/overlays/browser_agent/interaction_handlers/confirm/confirm_infobar_banner_interaction_handler.h
- M ios/chrome/browser/infobars/model/overlays/browser_agent/interaction_handlers/confirm/confirm_infobar_banner_interaction_handler.mm
- M ios/chrome/browser/infobars/model/overlays/browser_agent/interaction_handlers/confirm/confirm_infobar_banner_interaction_handler_unittest.mm
Change size: S
Delta: 4 files changed, 19 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Chris Lu, +1 by Leo Zhao
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages