[iOS] Fix duplicate tabs when allowing blocked popups [chromium/src : main]

0 views
Skip to first unread message

Chris Lu (Gerrit)

unread,
Apr 3, 2026, 11:48:18 AM (2 days ago) Apr 3
to Xiaobin Cui, Leo Zhao, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Leo Zhao and Xiaobin Cui

Chris Lu voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Leo Zhao
  • Xiaobin Cui
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7c3ff3bc09ac0a625d13465c8df9b057f31489d7
Gerrit-Change-Number: 7728683
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaobin Cui <xiaob...@microsoft.com>
Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
Gerrit-Reviewer: Leo Zhao <leo...@google.com>
Gerrit-Reviewer: Xiaobin Cui <xiaob...@microsoft.com>
Gerrit-Attention: Leo Zhao <leo...@google.com>
Gerrit-Attention: Xiaobin Cui <xiaob...@microsoft.com>
Gerrit-Comment-Date: Fri, 03 Apr 2026 15:48:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Leo Zhao (Gerrit)

unread,
Apr 4, 2026, 10:44:07 AM (yesterday) Apr 4
to Xiaobin Cui, Chris Lu, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Xiaobin Cui

Leo Zhao voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Xiaobin Cui
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7c3ff3bc09ac0a625d13465c8df9b057f31489d7
Gerrit-Change-Number: 7728683
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaobin Cui <xiaob...@microsoft.com>
Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
Gerrit-Reviewer: Leo Zhao <leo...@google.com>
Gerrit-Reviewer: Xiaobin Cui <xiaob...@microsoft.com>
Gerrit-Attention: Xiaobin Cui <xiaob...@microsoft.com>
Gerrit-Comment-Date: Sat, 04 Apr 2026 14:43:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Xiaobin Cui (Gerrit)

unread,
Apr 4, 2026, 8:11:51 PM (19 hours ago) Apr 4
to Leo Zhao, Chris Lu, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Xiaobin Cui voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7c3ff3bc09ac0a625d13465c8df9b057f31489d7
Gerrit-Change-Number: 7728683
Gerrit-PatchSet: 2
Gerrit-Owner: Xiaobin Cui <xiaob...@microsoft.com>
Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
Gerrit-Reviewer: Leo Zhao <leo...@google.com>
Gerrit-Reviewer: Xiaobin Cui <xiaob...@microsoft.com>
Gerrit-Comment-Date: Sun, 05 Apr 2026 00:11:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 4, 2026, 10:08:24 PM (17 hours ago) Apr 4
to Xiaobin Cui, Leo Zhao, Chris Lu, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[iOS] Fix duplicate tabs when allowing blocked popups

Fix by storing the InfobarType in the handler and guarding
MainButtonTapped and BannerVisibilityChanged with a type check,
matching the pattern already used by
DefaultInfobarBannerInteractionHandler.
Bug: 499103609
Change-Id: I7c3ff3bc09ac0a625d13465c8df9b057f31489d7
Reviewed-by: Chris Lu <thegre...@chromium.org>
Commit-Queue: Xiaobin Cui <xiaob...@microsoft.com>
Reviewed-by: Leo Zhao <leo...@google.com>
Cr-Commit-Position: refs/heads/main@{#1610154}
Files:
Change size: S
Delta: 4 files changed, 19 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Chris Lu, +1 by Leo Zhao
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7c3ff3bc09ac0a625d13465c8df9b057f31489d7
Gerrit-Change-Number: 7728683
Gerrit-PatchSet: 3
Gerrit-Owner: Xiaobin Cui <xiaob...@microsoft.com>
Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Leo Zhao <leo...@google.com>
Gerrit-Reviewer: Xiaobin Cui <xiaob...@microsoft.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages