[iOS] Fix BVC flash in new tab grid transitions [chromium/src : main]

0 views

Skip to first unread message

Gauthier Ambard (Gerrit)

unread,

Mar 31, 2026, 8:29:06 AM (5 days ago) Mar 31

to Nicolas MacBeth, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Gauthier Ambard added 1 comment

File ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/transitions/tab_grid_transition_handler.mm

Line 230, Patchset 2 (Latest): atIndex:0];

Gauthier Ambard . unresolved

Could you udpate the frame to be in the right coordinates?
Also, update the comment to explain why we need this (with details of the issue: -viewWillAppear -viewDidDisappear are called during the snapshot)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Nicolas MacBeth (Gerrit)

unread,

Apr 4, 2026, 11:12:51 AM (yesterday) Apr 4

to Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Gauthier Ambard

Nicolas MacBeth added 2 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Nicolas MacBeth . resolved

thanks! PTAL and confirm the rebase resolution is OK too, this was added as an IA next crash fix, which I'm removing

```
   } else {
      [appContentGuide addSubview:browserLayout.view];
   }
```

File ios/chrome/browser/tab_switcher/ui_bundled/tab_grid/transitions/tab_grid_transition_handler.mm

Line 230, Patchset 2: atIndex:0];

Gauthier Ambard . resolved

Could you udpate the frame to be in the right coordinates?
Also, update the comment to explain why we need this (with details of the issue: -viewWillAppear -viewDidDisappear are called during the snapshot)

Nicolas MacBeth

Done.

Open in Gerrit

Related details

Attention is currently required from:

Gauthier Ambard

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages