[iOS] Add Get Active Content Area User to DataControls Utils [chromium/src : main]

0 views
Skip to first unread message

Ernesto Izquierdo Clua (Gerrit)

unread,
Feb 20, 2026, 10:33:46 AM (4 days ago) Feb 20
to Yixi Wu, Chromium LUCI CQ, Xu Li, chromium...@chromium.org, cbe-cep-eng...@google.com, eic+...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Xu Li and Yixi Wu

Ernesto Izquierdo Clua voted and added 3 comments

Votes added by Ernesto Izquierdo Clua

Code-Review+1

3 comments

File ios/chrome/browser/enterprise/data_controls/utils/ios_clipboard_context.h
Line 38, Patchset 2 (Latest): raw_ptr<ProfileIOS> destination_profile_;
Ernesto Izquierdo Clua . unresolved

Thanks for fixing the name. Can you have the rename in a separate CL? We try to do separate refactors from changes in behavior so it is easier to review.

File ios/chrome/browser/enterprise/data_controls/utils/ios_clipboard_context.mm
Line 97, Patchset 2 (Latest): signin::IdentityManager* identity_manager =
Ernesto Izquierdo Clua . unresolved

Incgonito profiles will have null identity manager. Does `GetActiveContentAreaUser` handles this?

Line 109, Patchset 2 (Latest): signin::IdentityManager* identity_manager =
Ernesto Izquierdo Clua . unresolved

same question as above.

Open in Gerrit

Related details

Attention is currently required from:
  • Xu Li
  • Yixi Wu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4eac3c384e906a30748e26eaaad79a954df98c5d
Gerrit-Change-Number: 7596021
Gerrit-PatchSet: 2
Gerrit-Owner: Yixi Wu <yix...@google.com>
Gerrit-Reviewer: Ernesto Izquierdo Clua <e...@google.com>
Gerrit-Reviewer: Xu Li <mx...@google.com>
Gerrit-Reviewer: Yixi Wu <yix...@google.com>
Gerrit-Attention: Yixi Wu <yix...@google.com>
Gerrit-Attention: Xu Li <mx...@google.com>
Gerrit-Comment-Date: Fri, 20 Feb 2026 15:33:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Yixi Wu (Gerrit)

unread,
Feb 20, 2026, 10:43:57 AM (4 days ago) Feb 20
to Ernesto Izquierdo Clua, Chromium LUCI CQ, Xu Li, chromium...@chromium.org, cbe-cep-eng...@google.com, eic+...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Ernesto Izquierdo Clua and Xu Li

Yixi Wu added 3 comments

File ios/chrome/browser/enterprise/data_controls/utils/ios_clipboard_context.h
Line 38, Patchset 2: raw_ptr<ProfileIOS> destination_profile_;
Ernesto Izquierdo Clua . resolved

Thanks for fixing the name. Can you have the rename in a separate CL? We try to do separate refactors from changes in behavior so it is easier to review.

Yixi Wu

I'll fix the name in a different CL.

File ios/chrome/browser/enterprise/data_controls/utils/ios_clipboard_context.mm
Line 97, Patchset 2: signin::IdentityManager* identity_manager =
Ernesto Izquierdo Clua . resolved

Incgonito profiles will have null identity manager. Does `GetActiveContentAreaUser` handles this?

Line 109, Patchset 2: signin::IdentityManager* identity_manager =
Ernesto Izquierdo Clua . resolved

same question as above.

Yixi Wu

Marked as resolved.

Open in Gerrit

Related details

Attention is currently required from:
  • Ernesto Izquierdo Clua
  • Xu Li
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4eac3c384e906a30748e26eaaad79a954df98c5d
    Gerrit-Change-Number: 7596021
    Gerrit-PatchSet: 3
    Gerrit-Owner: Yixi Wu <yix...@google.com>
    Gerrit-Reviewer: Ernesto Izquierdo Clua <e...@google.com>
    Gerrit-Reviewer: Xu Li <mx...@google.com>
    Gerrit-Reviewer: Yixi Wu <yix...@google.com>
    Gerrit-Attention: Xu Li <mx...@google.com>
    Gerrit-Attention: Ernesto Izquierdo Clua <e...@google.com>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 15:43:52 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Ernesto Izquierdo Clua <e...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Xu Li (Gerrit)

    unread,
    Feb 23, 2026, 11:26:19 PM (17 hours ago) Feb 23
    to Yixi Wu, Ernesto Izquierdo Clua, Chromium LUCI CQ, chromium...@chromium.org, cbe-cep-eng...@google.com, eic+...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Ernesto Izquierdo Clua and Yixi Wu

    Xu Li voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ernesto Izquierdo Clua
    • Yixi Wu
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4eac3c384e906a30748e26eaaad79a954df98c5d
      Gerrit-Change-Number: 7596021
      Gerrit-PatchSet: 3
      Gerrit-Owner: Yixi Wu <yix...@google.com>
      Gerrit-Reviewer: Ernesto Izquierdo Clua <e...@google.com>
      Gerrit-Reviewer: Xu Li <mx...@google.com>
      Gerrit-Reviewer: Yixi Wu <yix...@google.com>
      Gerrit-Attention: Yixi Wu <yix...@google.com>
      Gerrit-Attention: Ernesto Izquierdo Clua <e...@google.com>
      Gerrit-Comment-Date: Tue, 24 Feb 2026 04:25:50 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Ernesto Izquierdo Clua (Gerrit)

      unread,
      1:56 PM (3 hours ago) 1:56 PM
      to Yixi Wu, Xu Li, Chromium LUCI CQ, chromium...@chromium.org, cbe-cep-eng...@google.com, eic+...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
      Attention needed from Yixi Wu

      Ernesto Izquierdo Clua voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Yixi Wu
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I4eac3c384e906a30748e26eaaad79a954df98c5d
        Gerrit-Change-Number: 7596021
        Gerrit-PatchSet: 3
        Gerrit-Owner: Yixi Wu <yix...@google.com>
        Gerrit-Reviewer: Ernesto Izquierdo Clua <e...@google.com>
        Gerrit-Reviewer: Xu Li <mx...@google.com>
        Gerrit-Reviewer: Yixi Wu <yix...@google.com>
        Gerrit-Attention: Yixi Wu <yix...@google.com>
        Gerrit-Comment-Date: Tue, 24 Feb 2026 18:56:45 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Yixi Wu (Gerrit)

        unread,
        1:58 PM (3 hours ago) 1:58 PM
        to Ernesto Izquierdo Clua, Xu Li, Chromium LUCI CQ, chromium...@chromium.org, cbe-cep-eng...@google.com, eic+...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

        Yixi Wu voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I4eac3c384e906a30748e26eaaad79a954df98c5d
        Gerrit-Change-Number: 7596021
        Gerrit-PatchSet: 3
        Gerrit-Owner: Yixi Wu <yix...@google.com>
        Gerrit-Reviewer: Ernesto Izquierdo Clua <e...@google.com>
        Gerrit-Reviewer: Xu Li <mx...@google.com>
        Gerrit-Reviewer: Yixi Wu <yix...@google.com>
        Gerrit-Comment-Date: Tue, 24 Feb 2026 18:58:46 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        2:53 PM (2 hours ago) 2:53 PM
        to Yixi Wu, Ernesto Izquierdo Clua, Xu Li, chromium...@chromium.org, cbe-cep-eng...@google.com, eic+...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        [iOS] Add Get Active Content Area User to DataControls Utils

        Implemented source_active_user() and destination_active_user() from
        ios_clipboard_context, utilizing the GetActiveContentAreaUser from the
        components folder.
        Bug: 452926435
        Change-Id: I4eac3c384e906a30748e26eaaad79a954df98c5d
        Commit-Queue: Yixi Wu <yix...@google.com>
        Reviewed-by: Ernesto Izquierdo Clua <e...@google.com>
        Reviewed-by: Xu Li <mx...@google.com>
        Cr-Commit-Position: refs/heads/main@{#1589605}
        Files:
        • M ios/chrome/browser/enterprise/data_controls/DEPS
        • M ios/chrome/browser/enterprise/data_controls/utils/BUILD.gn
        • M ios/chrome/browser/enterprise/data_controls/utils/ios_clipboard_context.mm
        Change size: S
        Delta: 3 files changed, 22 insertions(+), 6 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Ernesto Izquierdo Clua, +1 by Xu Li
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I4eac3c384e906a30748e26eaaad79a954df98c5d
        Gerrit-Change-Number: 7596021
        Gerrit-PatchSet: 4
        Gerrit-Owner: Yixi Wu <yix...@google.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Ernesto Izquierdo Clua <e...@google.com>
        Gerrit-Reviewer: Xu Li <mx...@google.com>
        Gerrit-Reviewer: Yixi Wu <yix...@google.com>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages