[iOS] Remove URLLoading command [chromium/src : main]

0 views

Skip to first unread message

Gauthier Ambard (Gerrit)

unread,

11:12 AM (2 hours ago) 11:12 AM

to Chromium LUCI CQ, Ewann Pellé, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Ewann Pellé

Gauthier Ambard voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Ewann Pellé

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ewann Pellé (Gerrit)

unread,

11:41 AM (1 hour ago) 11:41 AM

to Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, christia...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Gauthier Ambard

Ewann Pellé added 3 comments

File ios/chrome/browser/omnibox/coordinator/omnibox_coordinator.mm

Line 169, Patchset 7 (Latest):


  mediator.sceneState = browser->GetSceneState();

Ewann Pellé . unresolved

Looks like the new line is not needed.

File ios/chrome/browser/omnibox/coordinator/omnibox_mediator.h

Line 19, Patchset 7 (Latest):@protocol OmniboxConsumer;

Ewann Pellé . unresolved

same line 18.

File ios/chrome/browser/omnibox/coordinator/omnibox_mediator.mm

Line 344, Patchset 7 (Latest): if (weakSelf.URLLoadingBrowserAgent) {

Ewann Pellé . unresolved

You should probably use the strong self pattern here as URLLoadingBrowserAgent is a c++ object. Same below.

Open in Gerrit

Related details

Attention is currently required from:

Gauthier Ambard

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages