[iOS] Integrate Picture-in-Picture into all Default Browser entry points [chromium/src : main]

[Guillaume Jenkins (Gerrit)]

Attention needed from Cheick Cisse

Guillaume Jenkins voted and added 3 comments

Votes added by Guillaume Jenkins

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 6 (Latest):

Guillaume Jenkins . resolved

LGTM but please double check the other files I had changed in my CL that you didn't change here

Commit Message

Line 18, Patchset 6 (Latest):- Non-modal Promo

Guillaume Jenkins . unresolved

Based on my own [CL here](https://chromium-review.googlesource.com/c/chromium/src/+/6897046) you may be missing a few spots, can you double check:

• default_browser_instructions_view_controller.mm
• default_browser_generic_promo_mediator.mm
• default_browser_animated_screen_view_controller.mm
• default_browser_screen_coordinator.mm
• default_browser_screen_view_controller.mm

Not all of them have a call to OpenIOSDefaultBrowserSettings, but some of them DO show the Lottie animation, so we need to check the PiP variant to know which Lottie animation (app-specific settings or Default Apps) to show

File ios/chrome/browser/content_suggestions/set_up_list/coordinator/set_up_list_default_browser_promo_coordinator.mm

Line 139, Patchset 6 (Latest): _viewController = [[DefaultBrowserScreenViewController alloc] init];

Guillaume Jenkins . resolved

I thought we had changed this to instead go to Overflow Menu > Settings > Default Browser to unify all DB entry points?

I guess we can do it later so that we isolate as much as possible the impact of PiP in our study

Open in Gerrit

Related details

Attention is currently required from:

• Cheick Cisse

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id3d384e25055a5ef20883e9e6a49f315f1aad542

Gerrit-Change-Number: 7587613

Gerrit-PatchSet: 6

Gerrit-Owner: Cheick Cisse <cheic...@google.com>

Gerrit-Reviewer: Cheick Cisse <cheic...@google.com>

Gerrit-Reviewer: Guillaume Jenkins <gu...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Cheick Cisse <cheic...@google.com>

Gerrit-Comment-Date: Tue, 24 Feb 2026 01:51:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Cheick Cisse (Gerrit)]

Attention needed from Guillaume Jenkins

Cheick Cisse added 2 comments

Commit Message

Line 18, Patchset 6 (Latest):- Non-modal Promo

Guillaume Jenkins . unresolved

Based on my own [CL here](https://chromium-review.googlesource.com/c/chromium/src/+/6897046) you may be missing a few spots, can you double check:

• default_browser_instructions_view_controller.mm
• default_browser_generic_promo_mediator.mm
• default_browser_animated_screen_view_controller.mm
• default_browser_screen_coordinator.mm
• default_browser_screen_view_controller.mm

Not all of them have a call to OpenIOSDefaultBrowserSettings, but some of them DO show the Lottie animation, so we need to check the PiP variant to know which Lottie animation (app-specific settings or Default Apps) to show

Cheick Cisse

Ah good idea to compare.

• default_browser_instructions_view_controller.mm is used by many db promos but does not implement any actions.
• default_browser_generic_promo_mediator.mm we skip since we have [1].
• default_browser_animated_screen_view_controller.mm, default_browser_screen_coordinator.mm and default_browser_screen_view_controller.mm are FRE. Do we experiment PiP with the DB FRE too?

[1]https://source.chromium.org/chromium/chromium/src/+/main:ios/chrome/browser/default_browser/promo/generic/coordinator/default_browser_generic_promo_coordinator.mm;l=106

File ios/chrome/browser/content_suggestions/set_up_list/coordinator/set_up_list_default_browser_promo_coordinator.mm

Line 139, Patchset 6 (Latest): _viewController = [[DefaultBrowserScreenViewController alloc] init];

Guillaume Jenkins . resolved

I thought we had changed this to instead go to Overflow Menu > Settings > Default Browser to unify all DB entry points?

I guess we can do it later so that we isolate as much as possible the impact of PiP in our study

Cheick Cisse

Ah, good catch! This actually goes through the BD settings [1], but it's behind a flag (PIP). So, I guess this one isn't needed, since it won't be called when the PIP flag is enabled.

[1]https://source.chromium.org/chromium/chromium/src/+/main:ios/chrome/browser/content_suggestions/coordinator/content_suggestions_coordinator.mm;l=1264;drc=542eedeaf4606aec2003451a8365ac5a0269e33e;bpv=0;bpt=1

Open in Gerrit

Related details

Attention is currently required from:

• Guillaume Jenkins

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id3d384e25055a5ef20883e9e6a49f315f1aad542

Gerrit-Change-Number: 7587613

Gerrit-PatchSet: 6

Gerrit-Owner: Cheick Cisse <cheic...@google.com>

Gerrit-Reviewer: Cheick Cisse <cheic...@google.com>

Gerrit-Reviewer: Guillaume Jenkins <gu...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Guillaume Jenkins <gu...@google.com>

Gerrit-Comment-Date: Tue, 24 Feb 2026 02:31:24 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Guillaume Jenkins <gu...@google.com>

[Guillaume Jenkins (Gerrit)]

Attention needed from Cheick Cisse

Guillaume Jenkins added 1 comment

Commit Message

Line 18, Patchset 6:- Non-modal Promo

Guillaume Jenkins . unresolved

Based on my own [CL here](https://chromium-review.googlesource.com/c/chromium/src/+/6897046) you may be missing a few spots, can you double check:

• default_browser_instructions_view_controller.mm
• default_browser_generic_promo_mediator.mm
• default_browser_animated_screen_view_controller.mm
• default_browser_screen_coordinator.mm
• default_browser_screen_view_controller.mm

Not all of them have a call to OpenIOSDefaultBrowserSettings, but some of them DO show the Lottie animation, so we need to check the PiP variant to know which Lottie animation (app-specific settings or Default Apps) to show

Cheick Cisse

Ah good idea to compare.

• default_browser_instructions_view_controller.mm is used by many db promos but does not implement any actions.
• default_browser_generic_promo_mediator.mm we skip since we have [1].
• default_browser_animated_screen_view_controller.mm, default_browser_screen_coordinator.mm and default_browser_screen_view_controller.mm are FRE. Do we experiment PiP with the DB FRE too?

[1]https://source.chromium.org/chromium/chromium/src/+/main:ios/chrome/browser/default_browser/promo/generic/coordinator/default_browser_generic_promo_coordinator.mm;l=106

Guillaume Jenkins

Discussed offline:

• Need to update the Settings page to configure the instructions view with the right animation based on the PiP variant
• We will ignore FRE entry points for now

Open in Gerrit

Related details

Attention is currently required from:

• Cheick Cisse

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id3d384e25055a5ef20883e9e6a49f315f1aad542

Gerrit-Change-Number: 7587613

Gerrit-PatchSet: 7

Gerrit-Owner: Cheick Cisse <cheic...@google.com>

Gerrit-Reviewer: Cheick Cisse <cheic...@google.com>

Gerrit-Reviewer: Guillaume Jenkins <gu...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Cheick Cisse <cheic...@google.com>

Gerrit-Comment-Date: Tue, 24 Feb 2026 18:07:07 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Guillaume Jenkins <gu...@google.com>

Comment-In-Reply-To: Cheick Cisse <cheic...@google.com>

[Cheick Cisse (Gerrit)]

Attention needed from Guillaume Jenkins

Cheick Cisse added 1 comment

Commit Message

Line 18, Patchset 6:- Non-modal Promo

Guillaume Jenkins . resolved

Based on my own [CL here](https://chromium-review.googlesource.com/c/chromium/src/+/6897046) you may be missing a few spots, can you double check:

• default_browser_instructions_view_controller.mm
• default_browser_generic_promo_mediator.mm
• default_browser_animated_screen_view_controller.mm
• default_browser_screen_coordinator.mm
• default_browser_screen_view_controller.mm

Not all of them have a call to OpenIOSDefaultBrowserSettings, but some of them DO show the Lottie animation, so we need to check the PiP variant to know which Lottie animation (app-specific settings or Default Apps) to show

Cheick Cisse

Ah good idea to compare.

• default_browser_instructions_view_controller.mm is used by many db promos but does not implement any actions.
• default_browser_generic_promo_mediator.mm we skip since we have [1].
• default_browser_animated_screen_view_controller.mm, default_browser_screen_coordinator.mm and default_browser_screen_view_controller.mm are FRE. Do we experiment PiP with the DB FRE too?

[1]https://source.chromium.org/chromium/chromium/src/+/main:ios/chrome/browser/default_browser/promo/generic/coordinator/default_browser_generic_promo_coordinator.mm;l=106

Guillaume Jenkins

Discussed offline:

• Need to update the Settings page to configure the instructions view with the right animation based on the PiP variant
• We will ignore FRE entry points for now

Cheick Cisse

Also noticed a bug in default_browser_generic_promo_coordinator.mm that I fixed.

Open in Gerrit

Related details

Attention is currently required from:

• Guillaume Jenkins

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id3d384e25055a5ef20883e9e6a49f315f1aad542

Gerrit-Change-Number: 7587613

Gerrit-PatchSet: 8

Gerrit-Owner: Cheick Cisse <cheic...@google.com>

Gerrit-Reviewer: Cheick Cisse <cheic...@google.com>

Gerrit-Reviewer: Guillaume Jenkins <gu...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Guillaume Jenkins <gu...@google.com>

Gerrit-Comment-Date: Tue, 24 Feb 2026 19:48:58 +0000

[Cheick Cisse (Gerrit)]

Attention needed from Gauthier Ambard and Guillaume Jenkins

Cheick Cisse added 1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Cheick Cisse . resolved

+ gambard@

Open in Gerrit

Related details

Attention is currently required from:

• Gauthier Ambard
• Guillaume Jenkins

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id3d384e25055a5ef20883e9e6a49f315f1aad542

Gerrit-Change-Number: 7587613

Gerrit-PatchSet: 8

Gerrit-Owner: Cheick Cisse <cheic...@google.com>

Gerrit-Reviewer: Cheick Cisse <cheic...@google.com>

Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>

Gerrit-Reviewer: Guillaume Jenkins <gu...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Guillaume Jenkins <gu...@google.com>

Gerrit-Attention: Gauthier Ambard <gam...@chromium.org>

Gerrit-Comment-Date: Tue, 24 Feb 2026 19:50:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Guillaume Jenkins (Gerrit)]

Attention needed from Cheick Cisse and Gauthier Ambard

Guillaume Jenkins voted and added 1 comment

Votes added by Guillaume Jenkins

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Guillaume Jenkins . resolved

Latest patchset still LGTM

Open in Gerrit

Related details

Attention is currently required from:

• Cheick Cisse
• Gauthier Ambard

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Id3d384e25055a5ef20883e9e6a49f315f1aad542

Gerrit-Change-Number: 7587613

Gerrit-PatchSet: 8

Gerrit-Owner: Cheick Cisse <cheic...@google.com>

Gerrit-Reviewer: Cheick Cisse <cheic...@google.com>

Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>

Gerrit-Reviewer: Guillaume Jenkins <gu...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Cheick Cisse <cheic...@google.com>

Gerrit-Attention: Gauthier Ambard <gam...@chromium.org>

Gerrit-Comment-Date: Tue, 24 Feb 2026 20:56:34 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes