[iOS] Merge Private Pragmas in NTPHeaderViewController [chromium/src : main]

0 views
Skip to first unread message

Eric Ekey (Gerrit)

unread,
Apr 3, 2026, 10:45:01 AM (2 days ago) Apr 3
to Chris Lu, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org
Attention needed from Chris Lu

Eric Ekey voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Chris Lu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7b710923e362c7f987fe682bb83680e616e4d43f
Gerrit-Change-Number: 7728223
Gerrit-PatchSet: 3
Gerrit-Owner: Eric Ekey <eric...@google.com>
Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
Gerrit-Reviewer: Eric Ekey <eric...@google.com>
Gerrit-Attention: Chris Lu <thegre...@chromium.org>
Gerrit-Comment-Date: Fri, 03 Apr 2026 14:44:56 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Chris Lu (Gerrit)

unread,
Apr 3, 2026, 11:49:08 AM (2 days ago) Apr 3
to Eric Ekey, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org
Attention needed from Eric Ekey

Chris Lu voted and added 1 comment

Votes added by Chris Lu

Code-Review+1

1 comment

Commit Message
Line 9, Patchset 3 (Latest):THe NewTabPageHeaderViewController has methods under two different
Chris Lu . unresolved

super nit: The

Open in Gerrit

Related details

Attention is currently required from:
  • Eric Ekey
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7b710923e362c7f987fe682bb83680e616e4d43f
Gerrit-Change-Number: 7728223
Gerrit-PatchSet: 3
Gerrit-Owner: Eric Ekey <eric...@google.com>
Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
Gerrit-Reviewer: Eric Ekey <eric...@google.com>
Gerrit-Attention: Eric Ekey <eric...@google.com>
Gerrit-Comment-Date: Fri, 03 Apr 2026 15:48:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Eric Ekey (Gerrit)

unread,
Apr 3, 2026, 11:49:45 AM (2 days ago) Apr 3
to Chris Lu, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org

Eric Ekey voted and added 1 comment

Votes added by Eric Ekey

Auto-Submit+1
Commit-Queue+2

1 comment

Commit Message
Line 9, Patchset 3:THe NewTabPageHeaderViewController has methods under two different
Chris Lu . resolved

super nit: The

Eric Ekey

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7b710923e362c7f987fe682bb83680e616e4d43f
    Gerrit-Change-Number: 7728223
    Gerrit-PatchSet: 4
    Gerrit-Owner: Eric Ekey <eric...@google.com>
    Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
    Gerrit-Reviewer: Eric Ekey <eric...@google.com>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 15:49:39 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Chris Lu <thegre...@chromium.org>
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 3, 2026, 11:59:09 AM (2 days ago) Apr 3
    to Eric Ekey, Chris Lu, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, thegreenf...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    3 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    [iOS] Merge Private Pragmas in NTPHeaderViewController

    The NewTabPageHeaderViewController has methods under two different
    `Private` pragma markers. This change combines them at the bottom of the
    file.
    Bug: 497819911
    Change-Id: I7b710923e362c7f987fe682bb83680e616e4d43f
    Reviewed-by: Chris Lu <thegre...@chromium.org>
    Auto-Submit: Eric Ekey <eric...@google.com>
    Commit-Queue: Eric Ekey <eric...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1609810}
    Files:
    Change size: L
    Delta: 1 file changed, 205 insertions(+), 208 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Chris Lu
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7b710923e362c7f987fe682bb83680e616e4d43f
    Gerrit-Change-Number: 7728223
    Gerrit-PatchSet: 5
    Gerrit-Owner: Eric Ekey <eric...@google.com>
    Gerrit-Reviewer: Chris Lu <thegre...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Eric Ekey <eric...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages