Reland "[ios] Add fieldtrial config for UseSceneViewController" [chromium/src : main]

0 views

Skip to first unread message

Scott Yoder (Gerrit)

unread,

11:52 AM (5 hours ago) 11:52 AM

to Gauthier Ambard, AyeAye, Chromium LUCI CQ, Ginny Huang, chromium...@chromium.org, Chromium Metrics Reviews, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, asvitkine...@chromium.org

Attention needed from Gauthier Ambard

Scott Yoder added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Scott Yoder . resolved

Please take a look.

Open in Gerrit

Related details

Attention is currently required from:

Gauthier Ambard

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ginny Huang (Gerrit)

unread,

3:50 PM (1 hour ago) 3:50 PM

to Scott Yoder, Gauthier Ambard, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, asvitkine...@chromium.org

Attention needed from Gauthier Ambard and Scott Yoder

Ginny Huang voted and added 1 comment

Votes added by Ginny Huang

Code-Review

1 comment

File ios/chrome/browser/contextual_panel/ui/contextual_sheet_view_controller.mm

Line 234, Patchset 5 (Latest):

  if (_heightConstraint.constant == constant) {
    return;
  }

Ginny Huang . unresolved

maybe return if the absolute difference between these two constants is less than 0.5? Reference: https://source.chromium.org/chromium/chromium/src/+/main:ios/chrome/browser/infobars/ui_bundled/presentation/infobar_banner_presentation_controller.mm;l=104?q=viewwilllayoutsubview%20cgrect&start=11

⬆️ which still fails occasionally due to infinite recursion