[crypto] Convert to UNSAFE_TODO [chromium/src : main]
0 views
Skip to first unread message
Arthur Sonzogni (Gerrit)
Apr 3, 2026, 5:40:48 AM (2 days ago) Apr 3
to chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Arthur Sonzogni has uploaded the change for review![]( "Open in Gerrit")
Commit message
[crypto] Convert to UNSAFE_TODO
[crypto] Convert to UNSAFE_TODO
We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations,
allowing the rest of the file to be enforced as safe.
Script: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp=sharing
AX-Relnotes: N/A
Cleanup: This is an automated #cleanup.
Bug: 409340989
Change-Id: I996f659024ed96da05c01acc0b1b74575fa2faab
[ios] Convert to UNSAFE_TODO
We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations,
allowing the rest of the file to be enforced as safe.
Script: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp=sharing
AX-Relnotes: N/A
Cleanup: This is an automated #cleanup.
Bug: 409340989
Change-Id: I75d7f935294f104665579baf0a69a5a2244653db
Change diff
Change information
Files:
- M crypto/unexportable_key_win.cc
- M ios/chrome/app/perf_tests_hook_logging.mm
Change size: S
Delta: 2 files changed, 15 insertions(+), 20 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Apr 3, 2026, 5:40:53 AM (2 days ago) Apr 3
to chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Arthur Sonzogni has uploaded the change for review![]( "Open in Gerrit")
Commit message
[ios] Convert to UNSAFE_TODO
[ios] Convert to UNSAFE_TODO
We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations,
allowing the rest of the file to be enforced as safe.
Script: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp=sharing
AX-Relnotes: N/A
Cleanup: This is an automated #cleanup.
Bug: 409340989
Change-Id: I75d7f935294f104665579baf0a69a5a2244653db
Change diff
diff --git a/ios/chrome/app/perf_tests_hook_logging.mm b/ios/chrome/app/perf_tests_hook_logging.mm
index 9a55334e..819efd9 100644
--- a/ios/chrome/app/perf_tests_hook_logging.mm
+++ b/ios/chrome/app/perf_tests_hook_logging.mm
@@ -2,11 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifdef UNSAFE_BUFFERS_BUILD
-// TODO(crbug.com/474474271): Address use of unsafe formatting functions.
-#pragma allow_unsafe_buffers
-#endif
-
// clang-format off
#import "ios/chrome/app/tests_hook.h"
// clang-format on
Change information
Files:
- M ios/chrome/app/perf_tests_hook_logging.mm
Change size: XS
Delta: 1 file changed, 0 insertions(+), 5 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Apr 3, 2026, 7:20:37 AM (2 days ago) Apr 3
to chromium...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org, marq+...@chromium.org
Arthur Sonzogni has uploaded the change for review![]( "Open in Gerrit")
Commit message
[ios] Convert to UNSAFE_TODO
We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations,
allowing the rest of the file to be enforced as safe.
Script: https://docs.google.com/document/d/1ORQGBNn2R-CEvNbDTjRd-GrOBOFlCxIHdcvSUA_EhR4/edit?usp=sharing
AX-Relnotes: N/A
Cleanup: This is an automated #cleanup.
Bug: 409340989
Change-Id: I1349de2a20755d32c130e95ec65575070d29daf9
Arthur Sonzogni (Gerrit)
Apr 3, 2026, 9:43:47 AM (2 days ago) Apr 3
to AyeAye, Chromium LUCI CQ, chromium...@chromium.org, language...@chromium.org, ios-r...@chromium.org, storage...@chromium.org
Arthur Sonzogni voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Apr 3, 2026, 10:00:01 AM (2 days ago) Apr 3
to Gauthier Ambard, Hans Wennborg, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard and Hans Wennborg
Arthur Sonzogni added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Arthur Sonzogni . resolved
Hello!
Could you please take a look?
File ios/chrome/app/perf_tests_hook_logging.mm
Line 5, Patchset 2 (Parent):
#ifdef UNSAFE_BUFFERS_BUILD
// TODO(crbug.com/474474271): Address use of unsafe formatting functions.
#pragma allow_unsafe_buffers
#endifArthur Sonzogni . unresolved
Hans:
I see you added it here:
https://source.chromium.org/chromium/chromium/src/+/28b09ac53bbaad2ddfbaa58cb39ce92f9e5dc36d
But I don't see what line would be problematic.
Can I merge this?
Related details
Attention is currently required from:
- Gauthier Ambard
- Hans Wennborg
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Apr 3, 2026, 11:03:26 AM (2 days ago) Apr 3
to AyeAye, Chromium LUCI CQ, chromium...@chromium.org, language...@chromium.org, ios-r...@chromium.org, storage...@chromium.org
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Apr 3, 2026, 11:51:10 AM (2 days ago) Apr 3
to chromium...@chromium.org, Peter Beverloo, ortuno...@chromium.org, ios-r...@chromium.org, mac-r...@chromium.org, titoua...@chromium.org
Arthur Sonzogni has uploaded the change for review![]( "Open in Gerrit")
Commit message
[content] Convert to UNSAFE_TODO
We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations,
allowing the rest of the file to be enforced as safe.
AX-Relnotes: N/A
Cleanup: This is a mechanical #cleanup.
Bug: 409340989
Change-Id: Ie2cb0ec066853bcfafa404bf11e3b3c913c73e86
Change diff
Change information
Files:
- M content/app/ios/appex/child_process_bridge.mm
- M content/browser/child_process_launcher_helper_ios.mm
- M content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc
- M content/shell/app/shell_main_mac.cc
- M content/test/fuzzer/file_system_manager_mojolpm_fuzzer.cc
Change size: S
Delta: 5 files changed, 14 insertions(+), 32 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Apr 3, 2026, 3:55:27 PM (2 days ago) Apr 3
to chromium...@chromium.org, Peter Beverloo, ortuno...@chromium.org, ios-r...@chromium.org, mac-r...@chromium.org, titoua...@chromium.org
Arthur Sonzogni has uploaded the change for review![]( "Open in Gerrit")
Commit message
[content] Convert to UNSAFE_TODO
We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations,
allowing the rest of the file to be enforced as safe.
AX-Relnotes: N/A
Cleanup: This is a mechanical #cleanup.
Bug: 409340989
Change-Id: I9cf91dfacb74a5563e795ff081a2809f4b3ae88f
Change diff
Change information
Files:
- M content/app/ios/appex/child_process_bridge.mm
- M content/browser/child_process_launcher_helper_ios.mm
- M content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc
- M content/shell/app/shell_main_mac.cc
- M content/test/fuzzer/file_system_manager_mojolpm_fuzzer.cc
Change size: S
Delta: 5 files changed, 14 insertions(+), 27 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Apr 3, 2026, 4:22:48 PM (2 days ago) Apr 3
to chromium...@chromium.org, Peter Beverloo, ortuno...@chromium.org, ios-r...@chromium.org, mac-r...@chromium.org, titoua...@chromium.org
Arthur Sonzogni has uploaded the change for review![]( "Open in Gerrit")
Commit message
[content] Convert to UNSAFE_TODO
We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations,
allowing the rest of the file to be enforced as safe.
AX-Relnotes: N/A
Cleanup: This is a mechanical #cleanup.
Bug: 409340989
Change-Id: I3bf11cdebb9f0e74437fa03853b31f2be7456bc3
Change diff
Change information
Files:
- M content/app/ios/appex/child_process_bridge.mm
- M content/browser/child_process_launcher_helper_ios.mm
- M content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc
- M content/shell/app/shell_main_mac.cc
- M content/test/fuzzer/file_system_manager_mojolpm_fuzzer.cc
Change size: S
Delta: 5 files changed, 14 insertions(+), 32 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Apr 3, 2026, 7:31:43 PM (2 days ago) Apr 3
to chromium...@chromium.org, Peter Beverloo, ortuno...@chromium.org, ios-r...@chromium.org, mac-r...@chromium.org, titoua...@chromium.org
Arthur Sonzogni has uploaded the change for review![]( "Open in Gerrit")
Commit message
[content] Convert to UNSAFE_TODO
[content] Convert to UNSAFE_TODO
We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations,
allowing the rest of the file to be enforced as safe.
AX-Relnotes: N/A
Cleanup: This is a mechanical #cleanup.
Bug: 409340989
Change-Id: Id66463b69ba826abab5fdaaac0a49b76654b47c2
Change diff
Change information
Files:
- M content/app/ios/appex/child_process_bridge.mm
- M content/browser/child_process_launcher_helper_ios.mm
- M content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc
- M content/shell/app/shell_main_mac.cc
- M content/test/fuzzer/file_system_manager_mojolpm_fuzzer.cc
Change size: L
Delta: 5 files changed, 142 insertions(+), 789 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Apr 3, 2026, 10:00:44 PM (2 days ago) Apr 3
to chromium...@chromium.org, ios-r...@chromium.org, language...@chromium.org
Arthur Sonzogni has uploaded the change for review![]( "Open in Gerrit")
Commit message
[components] Convert to UNSAFE_TODO
We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations,
allowing the rest of the file to be enforced as safe.
AX-Relnotes: N/A
Cleanup: This is a mechanical #cleanup.
Bug: 409340989
Change-Id: I0ffb953464fe5f6b0f41c009c1a0a81f3aeaf385
Change diff
diff --git a/components/language/ios/browser/language_detection_javascript_unittest.mm b/components/language/ios/browser/language_detection_javascript_unittest.mm
index 46d1946..79f5d877 100644
--- a/components/language/ios/browser/language_detection_javascript_unittest.mm
+++ b/components/language/ios/browser/language_detection_javascript_unittest.mm
@@ -2,11 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifdef UNSAFE_BUFFERS_BUILD
-// TODO(crbug.com/390223051): Remove C-library calls to fix the errors.
-#pragma allow_unsafe_libc_calls
-#endif
-
+#include "base/compiler_specific.h"
#import "base/test/ios/wait_util.h"
#import "components/language/ios/browser/ios_language_detection_tab_helper.h"
#import "ios/web/public/test/javascript_test.h"
@@ -24,7 +20,7 @@
// Returns an NSString filled with the char 'a' of length `length`.
NSString* GetLongString(NSUInteger length) {
NSMutableData* data = [[NSMutableData alloc] initWithLength:length];
- memset([data mutableBytes], 'a', length);
+ UNSAFE_TODO(memset([data mutableBytes], 'a', length));
NSString* long_string = [[NSString alloc] initWithData:data
encoding:NSASCIIStringEncoding];
return long_string;
Change information
Files:
- M components/language/ios/browser/language_detection_javascript_unittest.mm
Change size: XS
Delta: 1 file changed, 2 insertions(+), 6 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Apr 3, 2026, 10:30:37 PM (2 days ago) Apr 3
to chromium...@chromium.org, Peter Beverloo, ortuno...@chromium.org, ios-r...@chromium.org, mac-r...@chromium.org, titoua...@chromium.org
Arthur Sonzogni has uploaded the change for review![]( "Open in Gerrit")
Commit message
[content] Convert to UNSAFE_TODO
We are migrating from coarse-grained file-level suppression (#pragma
allow_unsafe_buffers) to granular, expression-level markers
(UNSAFE_TODO()). The pragma disables safety checks for an entire file,
whereas UNSAFE_TODO() isolates specific potentially unsafe operations,
allowing the rest of the file to be enforced as safe.
AX-Relnotes: N/A
Cleanup: This is a mechanical #cleanup.
Bug: 409340989
Change-Id: Idfe80ecc16d56fc5ab02ab4668efefe9391c0a8a
Change diff
Change information
Files:
- M content/app/ios/appex/child_process_bridge.mm
- M content/browser/child_process_launcher_helper_ios.mm
- M content/child/dwrite_font_proxy/dwrite_font_proxy_win.cc
- M content/shell/app/shell_main_mac.cc
- M content/test/fuzzer/file_system_manager_mojolpm_fuzzer.cc
Change size: M
Delta: 5 files changed, 17 insertions(+), 36 deletions(-)
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Arthur Sonzogni (Gerrit)
Apr 4, 2026, 3:22:00 AM (yesterday) Apr 4
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, ios-r...@chromium.org, language...@chromium.org
Attention needed from Colin Blundell
Arthur Sonzogni voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages