[iOS] Update location bar badges design [chromium/src : main]

0 views
Skip to first unread message

Gauthier Ambard (Gerrit)

unread,
Apr 2, 2026, 11:54:12 AM (3 days ago) Apr 2
to Ibrahim Kanouche, Joemer Ramos, chromium...@chromium.org, christia...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Ibrahim Kanouche and Joemer Ramos

Gauthier Ambard voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ibrahim Kanouche
  • Joemer Ramos
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a8f6ae604dbf863ad1dbd953cc6650d3301802c
Gerrit-Change-Number: 7716700
Gerrit-PatchSet: 5
Gerrit-Owner: Gauthier Ambard <gam...@chromium.org>
Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>
Gerrit-Reviewer: Ibrahim Kanouche <kano...@google.com>
Gerrit-Reviewer: Joemer Ramos <joeme...@google.com>
Gerrit-Attention: Joemer Ramos <joeme...@google.com>
Gerrit-Attention: Ibrahim Kanouche <kano...@google.com>
Gerrit-Comment-Date: Thu, 02 Apr 2026 15:53:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ibrahim Kanouche (Gerrit)

unread,
Apr 2, 2026, 7:16:01 PM (3 days ago) Apr 2
to Gauthier Ambard, Chromium LUCI CQ, Joemer Ramos, chromium...@chromium.org, christia...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Gauthier Ambard and Joemer Ramos

Ibrahim Kanouche added 3 comments

File ios/chrome/browser/badges/ui_bundled/badge_button_factory.mm
Line 321, Patchset 5 (Latest): ConfigureIPHImageStyleForImageView(button.imageView);
Ibrahim Kanouche . unresolved

This applies the IPH highlight style at badge button creation time, but the button can exist in both highlighted and non-highlighted states. Is this style always appropriate for every badge button under ChromeNextIa, regardless of badge state?

If not, this should only be applied when the badge is in the highlighted/IPH state, and `RemoveIPHImageStyleFromImageView` should be called when transitioning out.

File ios/chrome/browser/location_bar/ui_bundled/badges_container_view.mm
Line 55, Patchset 5 (Latest): UIView* _availableBackground;
Ibrahim Kanouche . unresolved

nit: `_availableBackground` seems generic, maybe: `_availableStateOverlay` or something more descriptive?

Line 493, Patchset 5 (Latest): _availableBackground.backgroundColor = UIColor.whiteColor;
Ibrahim Kanouche . unresolved

is this what we want for dark mode as well? if not maybe use `[UIColor colorNamed:kBackgroundColor]` to preserve the correct dark mode behavior.

Open in Gerrit

Related details

Attention is currently required from:
  • Gauthier Ambard
  • Joemer Ramos
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7a8f6ae604dbf863ad1dbd953cc6650d3301802c
    Gerrit-Change-Number: 7716700
    Gerrit-PatchSet: 5
    Gerrit-Owner: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Reviewer: Ibrahim Kanouche <kano...@google.com>
    Gerrit-Reviewer: Joemer Ramos <joeme...@google.com>
    Gerrit-Attention: Joemer Ramos <joeme...@google.com>
    Gerrit-Attention: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Comment-Date: Thu, 02 Apr 2026 23:15:53 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gauthier Ambard (Gerrit)

    unread,
    Apr 3, 2026, 4:14:17 AM (2 days ago) Apr 3
    to Chromium LUCI CQ, Ibrahim Kanouche, Joemer Ramos, chromium...@chromium.org, christia...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Ibrahim Kanouche and Joemer Ramos

    Gauthier Ambard added 3 comments

    File ios/chrome/browser/badges/ui_bundled/badge_button_factory.mm
    Line 321, Patchset 5 (Latest): ConfigureIPHImageStyleForImageView(button.imageView);
    Ibrahim Kanouche . unresolved

    This applies the IPH highlight style at badge button creation time, but the button can exist in both highlighted and non-highlighted states. Is this style always appropriate for every badge button under ChromeNextIa, regardless of badge state?

    If not, this should only be applied when the badge is in the highlighted/IPH state, and `RemoveIPHImageStyleFromImageView` should be called when transitioning out.

    Gauthier Ambard

    I am not clear on what are the different states for the buttons? Is the "accepted" state the same as "highlighted"?
    What are the other states (available I guess)?

    File ios/chrome/browser/location_bar/ui_bundled/badges_container_view.mm
    Line 55, Patchset 5 (Latest): UIView* _availableBackground;
    Ibrahim Kanouche . resolved

    nit: `_availableBackground` seems generic, maybe: `_availableStateOverlay` or something more descriptive?

    Gauthier Ambard

    Done

    Line 493, Patchset 5 (Latest): _availableBackground.backgroundColor = UIColor.whiteColor;
    Ibrahim Kanouche . resolved

    is this what we want for dark mode as well? if not maybe use `[UIColor colorNamed:kBackgroundColor]` to preserve the correct dark mode behavior.

    Gauthier Ambard

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ibrahim Kanouche
    • Joemer Ramos
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7a8f6ae604dbf863ad1dbd953cc6650d3301802c
    Gerrit-Change-Number: 7716700
    Gerrit-PatchSet: 5
    Gerrit-Owner: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Reviewer: Ibrahim Kanouche <kano...@google.com>
    Gerrit-Reviewer: Joemer Ramos <joeme...@google.com>
    Gerrit-Attention: Joemer Ramos <joeme...@google.com>
    Gerrit-Attention: Ibrahim Kanouche <kano...@google.com>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 08:14:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Ibrahim Kanouche <kano...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Gauthier Ambard (Gerrit)

    unread,
    Apr 3, 2026, 4:15:33 AM (2 days ago) Apr 3
    to Chromium LUCI CQ, Ibrahim Kanouche, Joemer Ramos, chromium...@chromium.org, christia...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Ibrahim Kanouche and Joemer Ramos

    Gauthier Ambard voted Commit-Queue+1

    Commit-Queue+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ibrahim Kanouche
    • Joemer Ramos
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7a8f6ae604dbf863ad1dbd953cc6650d3301802c
    Gerrit-Change-Number: 7716700
    Gerrit-PatchSet: 6
    Gerrit-Owner: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Reviewer: Ibrahim Kanouche <kano...@google.com>
    Gerrit-Reviewer: Joemer Ramos <joeme...@google.com>
    Gerrit-Attention: Joemer Ramos <joeme...@google.com>
    Gerrit-Attention: Ibrahim Kanouche <kano...@google.com>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 08:15:20 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ibrahim Kanouche (Gerrit)

    unread,
    Apr 3, 2026, 3:10:01 PM (2 days ago) Apr 3
    to Gauthier Ambard, Chromium LUCI CQ, Joemer Ramos, chromium...@chromium.org, christia...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Gauthier Ambard and Joemer Ramos

    Ibrahim Kanouche added 1 comment

    File ios/chrome/browser/badges/ui_bundled/badge_button_factory.mm
    Line 321, Patchset 5: ConfigureIPHImageStyleForImageView(button.imageView);
    Ibrahim Kanouche . unresolved

    This applies the IPH highlight style at badge button creation time, but the button can exist in both highlighted and non-highlighted states. Is this style always appropriate for every badge button under ChromeNextIa, regardless of badge state?

    If not, this should only be applied when the badge is in the highlighted/IPH state, and `RemoveIPHImageStyleFromImageView` should be called when transitioning out.

    Gauthier Ambard

    I am not clear on what are the different states for the buttons? Is the "accepted" state the same as "highlighted"?
    What are the other states (available I guess)?

    Ibrahim Kanouche

    Yes, I am thinking the available and active states.

    Also, `ConfigureIPHImageStyleForImageView` sets the icon to white tint and `_availableBackground` uses a light/white background for `ContextualPanelEntrypointState::kAvailable`. If a badge button is created with white tint and then displayed while the available state overlay is showing, you'd have a white icon on a white-ish background, potentially very low contrast.

    If badge buttons under ChromeNextIa are only ever shown when the gradient background is active (never during the available state), then applying the style at creation time is fine and you can ignore this. But is this the case?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Gauthier Ambard
    • Joemer Ramos
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7a8f6ae604dbf863ad1dbd953cc6650d3301802c
    Gerrit-Change-Number: 7716700
    Gerrit-PatchSet: 6
    Gerrit-Owner: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Reviewer: Ibrahim Kanouche <kano...@google.com>
    Gerrit-Reviewer: Joemer Ramos <joeme...@google.com>
    Gerrit-Attention: Joemer Ramos <joeme...@google.com>
    Gerrit-Attention: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 19:09:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Ibrahim Kanouche <kano...@google.com>
    Comment-In-Reply-To: Gauthier Ambard <gam...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages