Reland "Create managed policies for kMetricsReportingLevel" [chromium/src : main]

0 views
Skip to first unread message

Chirag Arora (Gerrit)

unread,
Mar 31, 2026, 10:37:28 AM (5 days ago) Mar 31
to chromium...@chromium.org, Chromium LUCI CQ, Sébastien Lalancette, Matt Dembski, Nicolas Ouellet-Payeur, Pavol Marko, Rohit Rao, Martin Šrámek, AyeAye, Enterprise Policy Reviews, Victor Gabriel Savu, Sergey Poromov, Chromium Metrics Reviews, eic+...@google.com, marq+...@chromium.org, vsavu...@google.com, asvitkine...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org
Attention needed from Martin Šrámek, Matt Dembski, Nicolas Ouellet-Payeur, Pavol Marko, Rohit Rao and Sébastien Lalancette

Message from Chirag Arora

Set Ready For Review

Open in Gerrit

Related details

Attention is currently required from:
  • Martin Šrámek
  • Matt Dembski
  • Nicolas Ouellet-Payeur
  • Pavol Marko
  • Rohit Rao
  • Sébastien Lalancette
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id7504cc4dda2a65859671095510071c04109b04a
Gerrit-Change-Number: 7716581
Gerrit-PatchSet: 2
Gerrit-Owner: Chirag Arora <heyc...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Martin Šrámek <msr...@chromium.org>
Gerrit-Reviewer: Matt Dembski <dem...@google.com>
Gerrit-Reviewer: Nicolas Ouellet-Payeur <nico...@chromium.org>
Gerrit-Reviewer: Pavol Marko <pma...@chromium.org>
Gerrit-Reviewer: Rohit Rao <rohi...@chromium.org>
Gerrit-Reviewer: Sébastien Lalancette <seblal...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Sergey Poromov <por...@chromium.org>
Gerrit-CC: Victor Gabriel Savu <vs...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Sébastien Lalancette <seblal...@chromium.org>
Gerrit-Attention: Matt Dembski <dem...@google.com>
Gerrit-Attention: Nicolas Ouellet-Payeur <nico...@chromium.org>
Gerrit-Attention: Pavol Marko <pma...@chromium.org>
Gerrit-Attention: Rohit Rao <rohi...@chromium.org>
Gerrit-Attention: Martin Šrámek <msr...@chromium.org>
Gerrit-Comment-Date: Tue, 31 Mar 2026 14:37:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rohit Rao (Gerrit)

unread,
Apr 1, 2026, 3:25:11 PM (4 days ago) Apr 1
to Chirag Arora, Rohit Rao, chromium...@chromium.org, Chromium LUCI CQ, Sébastien Lalancette, Matt Dembski, Nicolas Ouellet-Payeur, Pavol Marko, Martin Šrámek, AyeAye, Enterprise Policy Reviews, Victor Gabriel Savu, Sergey Poromov, Chromium Metrics Reviews, eic+...@google.com, marq+...@chromium.org, vsavu...@google.com, asvitkine...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org
Attention needed from Chirag Arora, Martin Šrámek, Matt Dembski, Nicolas Ouellet-Payeur, Pavol Marko and Sébastien Lalancette

Rohit Rao voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Chirag Arora
  • Martin Šrámek
  • Matt Dembski
  • Nicolas Ouellet-Payeur
  • Pavol Marko
  • Sébastien Lalancette
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id7504cc4dda2a65859671095510071c04109b04a
    Gerrit-Change-Number: 7716581
    Gerrit-PatchSet: 3
    Gerrit-Owner: Chirag Arora <heyc...@google.com>
    Gerrit-Reviewer: Chirag Arora <heyc...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Martin Šrámek <msr...@chromium.org>
    Gerrit-Reviewer: Matt Dembski <dem...@google.com>
    Gerrit-Reviewer: Nicolas Ouellet-Payeur <nico...@chromium.org>
    Gerrit-Reviewer: Pavol Marko <pma...@chromium.org>
    Gerrit-Reviewer: Rohit Rao <rohi...@chromium.org>
    Gerrit-Reviewer: Sébastien Lalancette <seblal...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Sergey Poromov <por...@chromium.org>
    Gerrit-CC: Victor Gabriel Savu <vs...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Sébastien Lalancette <seblal...@chromium.org>
    Gerrit-Attention: Matt Dembski <dem...@google.com>
    Gerrit-Attention: Nicolas Ouellet-Payeur <nico...@chromium.org>
    Gerrit-Attention: Pavol Marko <pma...@chromium.org>
    Gerrit-Attention: Martin Šrámek <msr...@chromium.org>
    Gerrit-Attention: Chirag Arora <heyc...@google.com>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 19:25:01 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Matt Dembski (Gerrit)

    unread,
    Apr 1, 2026, 5:52:40 PM (4 days ago) Apr 1
    to Chirag Arora, Rohit Rao, chromium...@chromium.org, Chromium LUCI CQ, Sébastien Lalancette, Nicolas Ouellet-Payeur, Pavol Marko, Martin Šrámek, AyeAye, Enterprise Policy Reviews, Victor Gabriel Savu, Sergey Poromov, Chromium Metrics Reviews, eic+...@google.com, marq+...@chromium.org, vsavu...@google.com, asvitkine...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org
    Attention needed from Chirag Arora, Martin Šrámek, Nicolas Ouellet-Payeur, Pavol Marko, Rohit Rao and Sébastien Lalancette

    Matt Dembski voted and added 1 comment

    Votes added by Matt Dembski

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Matt Dembski . resolved

    re-LGTM for the "typo" fix

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chirag Arora
    • Martin Šrámek
    • Nicolas Ouellet-Payeur
    • Pavol Marko
    • Rohit Rao
    • Sébastien Lalancette
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id7504cc4dda2a65859671095510071c04109b04a
    Gerrit-Change-Number: 7716581
    Gerrit-PatchSet: 4
    Gerrit-Owner: Chirag Arora <heyc...@google.com>
    Gerrit-Reviewer: Chirag Arora <heyc...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Martin Šrámek <msr...@chromium.org>
    Gerrit-Reviewer: Matt Dembski <dem...@google.com>
    Gerrit-Reviewer: Nicolas Ouellet-Payeur <nico...@chromium.org>
    Gerrit-Reviewer: Pavol Marko <pma...@chromium.org>
    Gerrit-Reviewer: Rohit Rao <rohi...@chromium.org>
    Gerrit-Reviewer: Sébastien Lalancette <seblal...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Sergey Poromov <por...@chromium.org>
    Gerrit-CC: Victor Gabriel Savu <vs...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Sébastien Lalancette <seblal...@chromium.org>
    Gerrit-Attention: Rohit Rao <rohi...@chromium.org>
    Gerrit-Attention: Nicolas Ouellet-Payeur <nico...@chromium.org>
    Gerrit-Attention: Pavol Marko <pma...@chromium.org>
    Gerrit-Attention: Martin Šrámek <msr...@chromium.org>
    Gerrit-Attention: Chirag Arora <heyc...@google.com>
    Gerrit-Comment-Date: Wed, 01 Apr 2026 21:52:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Sébastien Lalancette (Gerrit)

    unread,
    Apr 1, 2026, 7:16:29 PM (4 days ago) Apr 1
    to Chirag Arora, Matt Dembski, Rohit Rao, chromium...@chromium.org, Chromium LUCI CQ, Nicolas Ouellet-Payeur, Pavol Marko, Martin Šrámek, AyeAye, Enterprise Policy Reviews, Victor Gabriel Savu, Sergey Poromov, Chromium Metrics Reviews, eic+...@google.com, marq+...@chromium.org, vsavu...@google.com, asvitkine...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org
    Attention needed from Chirag Arora, Martin Šrámek, Nicolas Ouellet-Payeur, Pavol Marko and Rohit Rao

    Sébastien Lalancette voted and added 1 comment

    Votes added by Sébastien Lalancette

    Code-Review+1

    1 comment

    Patchset-level comments
    Sébastien Lalancette . resolved

    enums.xml LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Chirag Arora
    • Martin Šrámek
    • Nicolas Ouellet-Payeur
    • Pavol Marko
    • Rohit Rao
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Gerrit-Attention: Rohit Rao <rohi...@chromium.org>
      Gerrit-Attention: Nicolas Ouellet-Payeur <nico...@chromium.org>
      Gerrit-Attention: Pavol Marko <pma...@chromium.org>
      Gerrit-Attention: Martin Šrámek <msr...@chromium.org>
      Gerrit-Attention: Chirag Arora <heyc...@google.com>
      Gerrit-Comment-Date: Wed, 01 Apr 2026 23:16:16 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nicolas Ouellet-Payeur (Gerrit)

      unread,
      Apr 2, 2026, 9:45:41 AM (3 days ago) Apr 2
      to Chirag Arora, Igor, Sébastien Lalancette, Matt Dembski, Rohit Rao, chromium...@chromium.org, Chromium LUCI CQ, Pavol Marko, Martin Šrámek, AyeAye, Enterprise Policy Reviews, Victor Gabriel Savu, Sergey Poromov, Chromium Metrics Reviews, eic+...@google.com, marq+...@chromium.org, vsavu...@google.com, asvitkine...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org
      Attention needed from Chirag Arora, Igor, Martin Šrámek, Pavol Marko and Rohit Rao

      Nicolas Ouellet-Payeur voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Chirag Arora
      • Igor
      • Martin Šrámek
      • Pavol Marko
      • Rohit Rao
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id7504cc4dda2a65859671095510071c04109b04a
      Gerrit-Change-Number: 7716581
      Gerrit-PatchSet: 4
      Gerrit-Owner: Chirag Arora <heyc...@google.com>
      Gerrit-Reviewer: Chirag Arora <heyc...@google.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Igor <igo...@chromium.org>
      Gerrit-Reviewer: Martin Šrámek <msr...@chromium.org>
      Gerrit-Reviewer: Matt Dembski <dem...@google.com>
      Gerrit-Reviewer: Nicolas Ouellet-Payeur <nico...@chromium.org>
      Gerrit-Reviewer: Pavol Marko <pma...@chromium.org>
      Gerrit-Reviewer: Rohit Rao <rohi...@chromium.org>
      Gerrit-Reviewer: Sébastien Lalancette <seblal...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
      Gerrit-CC: Sergey Poromov <por...@chromium.org>
      Gerrit-CC: Victor Gabriel Savu <vs...@google.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Igor <igo...@chromium.org>
      Gerrit-Attention: Rohit Rao <rohi...@chromium.org>
      Gerrit-Attention: Pavol Marko <pma...@chromium.org>
      Gerrit-Attention: Martin Šrámek <msr...@chromium.org>
      Gerrit-Attention: Chirag Arora <heyc...@google.com>
      Gerrit-Comment-Date: Thu, 02 Apr 2026 13:45:30 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Rohit Rao (Gerrit)

      unread,
      Apr 2, 2026, 9:49:49 AM (3 days ago) Apr 2
      to Chirag Arora, Rohit Rao, Nicolas Ouellet-Payeur, Igor, Sébastien Lalancette, Matt Dembski, chromium...@chromium.org, Chromium LUCI CQ, Pavol Marko, Martin Šrámek, AyeAye, Enterprise Policy Reviews, Victor Gabriel Savu, Sergey Poromov, Chromium Metrics Reviews, eic+...@google.com, marq+...@chromium.org, vsavu...@google.com, asvitkine...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org
      Attention needed from Chirag Arora, Igor, Martin Šrámek and Pavol Marko

      Rohit Rao voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Chirag Arora
      • Igor
      • Martin Šrámek
      • Pavol Marko
      Gerrit-Attention: Pavol Marko <pma...@chromium.org>
      Gerrit-Attention: Martin Šrámek <msr...@chromium.org>
      Gerrit-Attention: Chirag Arora <heyc...@google.com>
      Gerrit-Comment-Date: Thu, 02 Apr 2026 13:49:34 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Igor (Gerrit)

      unread,
      Apr 2, 2026, 10:16:39 AM (3 days ago) Apr 2
      to Chirag Arora, Rohit Rao, Nicolas Ouellet-Payeur, Sébastien Lalancette, Matt Dembski, chromium...@chromium.org, Chromium LUCI CQ, Pavol Marko, Martin Šrámek, AyeAye, Enterprise Policy Reviews, Victor Gabriel Savu, Sergey Poromov, Chromium Metrics Reviews, eic+...@google.com, marq+...@chromium.org, vsavu...@google.com, asvitkine...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org
      Attention needed from Chirag Arora, Martin Šrámek and Pavol Marko

      Igor voted and added 1 comment

      Votes added by Igor

      Code-Review+1

      1 comment

      File components/policy/resources/templates/policy_definitions/Miscellaneous/MetricsReportingLevel.yaml
      Line 2, Patchset 4 (Latest):default: null
      Igor . unresolved

      The text mentions that the user can choose when the policy is not set. But what is the default behavior if the policy is unset and the user didn't choose anything?
      The same question for the device policy defined for ChromeOs

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Chirag Arora
      • Martin Šrámek
      • Pavol Marko
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Gerrit-Attention: Pavol Marko <pma...@chromium.org>
      Gerrit-Attention: Martin Šrámek <msr...@chromium.org>
      Gerrit-Attention: Chirag Arora <heyc...@google.com>
      Gerrit-Comment-Date: Thu, 02 Apr 2026 14:16:19 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Chirag Arora (Gerrit)

      unread,
      Apr 3, 2026, 8:04:34 AM (2 days ago) Apr 3
      to Igor, Rohit Rao, Nicolas Ouellet-Payeur, Sébastien Lalancette, Matt Dembski, chromium...@chromium.org, Chromium LUCI CQ, Pavol Marko, Martin Šrámek, AyeAye, Enterprise Policy Reviews, Victor Gabriel Savu, Sergey Poromov, Chromium Metrics Reviews, eic+...@google.com, marq+...@chromium.org, vsavu...@google.com, asvitkine...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org
      Attention needed from Igor, Martin Šrámek, Matt Dembski, Nicolas Ouellet-Payeur, Pavol Marko, Rohit Rao and Sébastien Lalancette

      Chirag Arora added 1 comment

      File components/policy/resources/templates/policy_definitions/Miscellaneous/MetricsReportingLevel.yaml
      Line 2, Patchset 4:default: null
      Igor . unresolved

      The text mentions that the user can choose when the policy is not set. But what is the default behavior if the policy is unset and the user didn't choose anything?
      The same question for the device policy defined for ChromeOs

      Chirag Arora

      I took this from the current policy which will be getting overridden by this policy. There too it is defined as `null` and I am not sure of the consequences of this being `null` or not being `null`.

      https://source.chromium.org/chromium/chromium/src/+/main:components/policy/resources/templates/policy_definitions/Miscellaneous/MetricsReportingEnabled.yaml;l=2

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Igor
      • Martin Šrámek
      • Matt Dembski
      • Nicolas Ouellet-Payeur
      • Pavol Marko
      • Rohit Rao
      • Sébastien Lalancette
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement is not satisfiedCode-Review
        • requirement is not satisfiedNo-Unresolved-Comments
        • requirement is not satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Id7504cc4dda2a65859671095510071c04109b04a
        Gerrit-Change-Number: 7716581
        Gerrit-PatchSet: 5
        Gerrit-Owner: Chirag Arora <heyc...@google.com>
        Gerrit-Reviewer: Chirag Arora <heyc...@google.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Igor <igo...@chromium.org>
        Gerrit-Reviewer: Martin Šrámek <msr...@chromium.org>
        Gerrit-Reviewer: Matt Dembski <dem...@google.com>
        Gerrit-Reviewer: Nicolas Ouellet-Payeur <nico...@chromium.org>
        Gerrit-Reviewer: Pavol Marko <pma...@chromium.org>
        Gerrit-Reviewer: Rohit Rao <rohi...@chromium.org>
        Gerrit-Reviewer: Sébastien Lalancette <seblal...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
        Gerrit-CC: Sergey Poromov <por...@chromium.org>
        Gerrit-CC: Victor Gabriel Savu <vs...@google.com>
        Gerrit-CC: gwsq
        Gerrit-Attention: Igor <igo...@chromium.org>
        Gerrit-Attention: Sébastien Lalancette <seblal...@chromium.org>
        Gerrit-Attention: Matt Dembski <dem...@google.com>
        Gerrit-Attention: Rohit Rao <rohi...@chromium.org>
        Gerrit-Attention: Nicolas Ouellet-Payeur <nico...@chromium.org>
        Gerrit-Attention: Pavol Marko <pma...@chromium.org>
        Gerrit-Attention: Martin Šrámek <msr...@chromium.org>
        Gerrit-Comment-Date: Fri, 03 Apr 2026 12:04:21 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        Comment-In-Reply-To: Igor <igo...@chromium.org>
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Igor (Gerrit)

        unread,
        Apr 4, 2026, 9:31:33 AM (yesterday) Apr 4
        to Chirag Arora, Rohit Rao, Nicolas Ouellet-Payeur, Sébastien Lalancette, Matt Dembski, chromium...@chromium.org, Chromium LUCI CQ, Pavol Marko, Martin Šrámek, AyeAye, Enterprise Policy Reviews, Victor Gabriel Savu, Sergey Poromov, Chromium Metrics Reviews, eic+...@google.com, marq+...@chromium.org, vsavu...@google.com, asvitkine...@chromium.org, ios-r...@chromium.org, ios-revie...@chromium.org
        Attention needed from Chirag Arora, Martin Šrámek, Matt Dembski, Nicolas Ouellet-Payeur, Pavol Marko, Rohit Rao and Sébastien Lalancette

        Igor voted and added 1 comment

        Votes added by Igor

        Code-Review+1

        1 comment

        File components/policy/resources/templates/policy_definitions/Miscellaneous/MetricsReportingLevel.yaml
        Line 2, Patchset 4:default: null
        Igor . resolved

        The text mentions that the user can choose when the policy is not set. But what is the default behavior if the policy is unset and the user didn't choose anything?
        The same question for the device policy defined for ChromeOs

        Chirag Arora

        I took this from the current policy which will be getting overridden by this policy. There too it is defined as `null` and I am not sure of the consequences of this being `null` or not being `null`.

        https://source.chromium.org/chromium/chromium/src/+/main:components/policy/resources/templates/policy_definitions/Miscellaneous/MetricsReportingEnabled.yaml;l=2

        Igor
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Chirag Arora
        • Martin Šrámek
        • Matt Dembski
        • Nicolas Ouellet-Payeur
        • Pavol Marko
        • Rohit Rao
        • Sébastien Lalancette
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement satisfiedCode-Owners
            • requirement is not satisfiedCode-Review
            • requirement satisfiedReview-Enforcement
            Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
            Gerrit-MessageType: comment
            Gerrit-Project: chromium/src
            Gerrit-Branch: main
            Gerrit-Change-Id: Id7504cc4dda2a65859671095510071c04109b04a
            Gerrit-Change-Number: 7716581
            Gerrit-PatchSet: 6
            Gerrit-Owner: Chirag Arora <heyc...@google.com>
            Gerrit-Reviewer: Chirag Arora <heyc...@google.com>
            Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
            Gerrit-Reviewer: Igor <igo...@chromium.org>
            Gerrit-Reviewer: Martin Šrámek <msr...@chromium.org>
            Gerrit-Reviewer: Matt Dembski <dem...@google.com>
            Gerrit-Reviewer: Nicolas Ouellet-Payeur <nico...@chromium.org>
            Gerrit-Reviewer: Pavol Marko <pma...@chromium.org>
            Gerrit-Reviewer: Rohit Rao <rohi...@chromium.org>
            Gerrit-Reviewer: Sébastien Lalancette <seblal...@chromium.org>
            Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
            Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
            Gerrit-CC: Sergey Poromov <por...@chromium.org>
            Gerrit-CC: Victor Gabriel Savu <vs...@google.com>
            Gerrit-CC: gwsq
            Gerrit-Attention: Sébastien Lalancette <seblal...@chromium.org>
            Gerrit-Attention: Matt Dembski <dem...@google.com>
            Gerrit-Attention: Rohit Rao <rohi...@chromium.org>
            Gerrit-Attention: Nicolas Ouellet-Payeur <nico...@chromium.org>
            Gerrit-Attention: Pavol Marko <pma...@chromium.org>
            Gerrit-Attention: Martin Šrámek <msr...@chromium.org>
            Gerrit-Attention: Chirag Arora <heyc...@google.com>
            Gerrit-Comment-Date: Sat, 04 Apr 2026 13:31:07 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            Comment-In-Reply-To: Igor <igo...@chromium.org>
            Comment-In-Reply-To: Chirag Arora <heyc...@google.com>
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy
            Reply all
            Reply to author
            Forward
            0 new messages