[M146] [iOS] Do not present infobar before the profile is initialized [chromium/src : refs/branch-heads/7680]
0 views
Skip to first unread message
Chrome Cherry Picker (Gerrit)
11:45 AM (6 hours ago) 11:45 AM
to Gauthier Ambard, AyeAye, ios-r...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org
Chrome Cherry Picker voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
11:46 AM (6 hours ago) 11:46 AM
to Chrome Cherry Picker, Gauthier Ambard, AyeAye, ios-r...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org
Rubber Stamper voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
1:04 PM (5 hours ago) 1:04 PM
to Chrome Cherry Picker, Gauthier Ambard, Rubber Stamper, AyeAye, ios-r...@chromium.org, marq+...@chromium.org, ios-revie...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M146] [iOS] Do not present infobar before the profile is initialized
Original change's description:
> [iOS] Do not present infobar before the profile is initialized
>
> This CL adds a condition to present an infobar. It requires that the
> ProfileState reached the "kNormal" state.
> It also adds an observer (by adding a bridge) to make sure it is
> presenting the paused infobar when the correct state is reached.
>
> This ensures that no infobars are presented during the FRE. Presenting
> an infobar during FRE is preventing the FRE from transitioning between
> screens.
>
> A long term solution is probably to move the infobar from a presented
> logic to a contained one.
>
> Fixed: 485825356
> Change-Id: Ibc2b41487b9e76922bfe0d53c653b6c5fcfb8a2b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7595296
> Commit-Queue: Gauthier Ambard <gam...@chromium.org>
> Reviewed-by: Sylvain Defresne <sdef...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1588667}
(cherry picked from commit 382ca0c2dc81aac457b1faf506aa0f51da19731f)
Bug: 486837416,485825356
Change-Id: Ibc2b41487b9e76922bfe0d53c653b6c5fcfb8a2b
Auto-Submit: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7680@{#1244}
Cr-Branched-From: 76b7d80e5cda23fe6537eed26d68c92e995c7f39-refs/heads/main@{#1582197}
Files:
- M ios/chrome/app/profile/BUILD.gn
- A ios/chrome/app/profile/profile_state_observer_bridge.h
- A ios/chrome/app/profile/profile_state_observer_bridge.mm
- M ios/chrome/browser/overlays/model/BUILD.gn
- M ios/chrome/browser/overlays/model/overlay_presenter_impl.h
- M ios/chrome/browser/overlays/model/overlay_presenter_impl.mm
- M ios/chrome/browser/overlays/model/overlay_presenter_impl_unittest.mm
Change size: L
Delta: 7 files changed, 262 insertions(+), 3 deletions(-)
Branch: refs/branch-heads/7680
Submit Requirements:
Code-Review: Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages