[iOS] Youtube Incognito cleanup - II [chromium/src : main]
0 views
Skip to first unread message
Sylvain Defresne (Gerrit)
Jan 19, 2026, 8:20:46 AM (2 days ago) Jan 19
to Elmehdi Rahmaoui, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Elmehdi Rahmaoui
Sylvain Defresne voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sylvain Defresne
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Elmehdi Rahmaoui
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sylvain Defresne (Gerrit)
Jan 19, 2026, 8:23:33 AM (2 days ago) Jan 19
to Elmehdi Rahmaoui, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Elmehdi Rahmaoui
Sylvain Defresne added 1 comment![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 1 (Latest):
Remove the youtube incognito flag, variations, name and descriptionSylvain Defresne . unresolved
Explain why in addition to what.
Related details
Attention is currently required from:
- Elmehdi Rahmaoui
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Elmehdi Rahmaoui (Gerrit)
Jan 19, 2026, 11:31:01 AM (2 days ago) Jan 19
to Sylvain Defresne, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Elmehdi Rahmaoui added 1 comment![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 1:
Remove the youtube incognito flag, variations, name and descriptionSylvain Defresne . resolved
Explain why in addition to what.
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Elmehdi Rahmaoui (Gerrit)
7:22 AM (6 hours ago) 7:22 AM
to Sylvain Defresne, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Elmehdi Rahmaoui voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sylvain Defresne (Gerrit)
8:17 AM (5 hours ago) 8:17 AM
to Elmehdi Rahmaoui, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Elmehdi Rahmaoui
Sylvain Defresne voted and added 1 comment![]( "Open in Gerrit")
Votes added by Sylvain Defresne
| Code-Review | +1 |
Sylvain Defresne . resolved
lgtm
Attention is currently required from:
- Elmehdi Rahmaoui
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Elmehdi Rahmaoui (Gerrit)
8:18 AM (5 hours ago) 8:18 AM
to Sylvain Defresne, Chromium LUCI CQ, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Elmehdi Rahmaoui voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
9:25 AM (4 hours ago) 9:25 AM
to Elmehdi Rahmaoui, Sylvain Defresne, AyeAye, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Youtube Incognito cleanup - II
Remove the youtube incognito flag, variations, name and description from
chromium. The feature is now enabled by default and launched, remove the
code checking the feature
Bug: 465404415
Change-Id: Ib6c14c8f42a0f82b96acc4cabb913e1737575931
Commit-Queue: Elmehdi Rahmaoui <erah...@google.com>
Reviewed-by: Sylvain Defresne <sdef...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1572274}
Files:
- M chrome/browser/flag-metadata.json
- M ios/chrome/app/app_startup_parameters.mm
- M ios/chrome/browser/flags/about_flags.mm
- M ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc
- M ios/chrome/browser/flags/ios_chrome_flag_descriptions.h
- M ios/chrome/browser/shared/public/features/features.h
- M ios/chrome/browser/shared/public/features/features.mm
- M testing/variations/fieldtrial_testing_config.json
Change size: M
Delta: 8 files changed, 2 insertions(+), 156 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Sylvain Defresne
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages