[ios] Remove the dependency to base/ in observer.h [chromium/src : main]

0 views
Skip to first unread message

Justin Novosad (Gerrit)

unread,
10:49 AM (7 hours ago) 10:49 AM
to Asami Doi, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Asami Doi

Justin Novosad added 1 comment

File PRESUBMIT.py
Line 1143, Patchset 5 (Latest): r'ios/chrome/test/swift_interop/closure/observer\.h',
Justin Novosad . unresolved

If theses strings are regexes or if they support wildcards, perhaps we could exclude all contents of subdirectories named "swift_interop" from the ban. That way wouldn't have to touch this file every time we add an interop shim.

Open in Gerrit

Related details

Attention is currently required from:
  • Asami Doi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9dd86b7171c6ba6a2ad3f77a9c9c448cb2da731f
Gerrit-Change-Number: 7581956
Gerrit-PatchSet: 5
Gerrit-Owner: Asami Doi <asam...@chromium.org>
Gerrit-Reviewer: Asami Doi <asam...@chromium.org>
Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
Gerrit-Attention: Asami Doi <asam...@chromium.org>
Gerrit-Comment-Date: Tue, 24 Feb 2026 15:49:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Justin Novosad (Gerrit)

unread,
10:53 AM (7 hours ago) 10:53 AM
to Asami Doi, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Asami Doi

Justin Novosad voted and added 1 comment

Votes added by Justin Novosad

Code-Review+1

1 comment

File PRESUBMIT.py
Line 1143, Patchset 5 (Latest): r'ios/chrome/test/swift_interop/closure/observer\.h',
Justin Novosad . unresolved

If theses strings are regexes or if they support wildcards, perhaps we could exclude all contents of subdirectories named "swift_interop" from the ban. That way wouldn't have to touch this file every time we add an interop shim.

Justin Novosad

In a follow-up CL you could rename //base/ios/swift_shims to //base/ios/swift_interop to make it fit the regex pattern.

Open in Gerrit

Related details

Attention is currently required from:
  • Asami Doi
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9dd86b7171c6ba6a2ad3f77a9c9c448cb2da731f
    Gerrit-Change-Number: 7581956
    Gerrit-PatchSet: 5
    Gerrit-Owner: Asami Doi <asam...@chromium.org>
    Gerrit-Reviewer: Asami Doi <asam...@chromium.org>
    Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
    Gerrit-Attention: Asami Doi <asam...@chromium.org>
    Gerrit-Comment-Date: Tue, 24 Feb 2026 15:52:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Justin Novosad <ju...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Asami Doi (Gerrit)

    unread,
    1:31 PM (4 hours ago) 1:31 PM
    to Justin Novosad, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
    Attention needed from Justin Novosad

    Asami Doi added 1 comment

    File PRESUBMIT.py
    Line 1143, Patchset 5: r'ios/chrome/test/swift_interop/closure/observer\.h',
    Justin Novosad . resolved

    If theses strings are regexes or if they support wildcards, perhaps we could exclude all contents of subdirectories named "swift_interop" from the ban. That way wouldn't have to touch this file every time we add an interop shim.

    Justin Novosad

    In a follow-up CL you could rename //base/ios/swift_shims to //base/ios/swift_interop to make it fit the regex pattern.

    Asami Doi

    Wildcards are supported so I have updated the script in a chained CL (https://chromium-review.googlesource.com/c/chromium/src/+/7572162). We don't have to add files if they are in `swift_interop` directory.

    I can rename swift_shims in a follow-up CL.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Justin Novosad
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I9dd86b7171c6ba6a2ad3f77a9c9c448cb2da731f
      Gerrit-Change-Number: 7581956
      Gerrit-PatchSet: 6
      Gerrit-Owner: Asami Doi <asam...@chromium.org>
      Gerrit-Reviewer: Asami Doi <asam...@chromium.org>
      Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
      Gerrit-Attention: Justin Novosad <ju...@chromium.org>
      Gerrit-Comment-Date: Tue, 24 Feb 2026 18:30:53 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Justin Novosad <ju...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Asami Doi (Gerrit)

      unread,
      1:31 PM (4 hours ago) 1:31 PM
      to Sylvain Defresne, Justin Novosad, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
      Attention needed from Sylvain Defresne

      Asami Doi voted and added 1 comment

      Votes added by Asami Doi

      Commit-Queue+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 6 (Latest):
      Asami Doi . resolved

      sdefresne@: Can you review this CL? Thank you.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Sylvain Defresne
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I9dd86b7171c6ba6a2ad3f77a9c9c448cb2da731f
      Gerrit-Change-Number: 7581956
      Gerrit-PatchSet: 6
      Gerrit-Owner: Asami Doi <asam...@chromium.org>
      Gerrit-Reviewer: Asami Doi <asam...@chromium.org>
      Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
      Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
      Gerrit-Attention: Sylvain Defresne <sdef...@chromium.org>
      Gerrit-Comment-Date: Tue, 24 Feb 2026 18:31:28 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Justin Novosad (Gerrit)

      unread,
      2:41 PM (3 hours ago) 2:41 PM
      to Asami Doi, Sylvain Defresne, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
      Attention needed from Asami Doi and Sylvain Defresne

      Justin Novosad voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Asami Doi
      • Sylvain Defresne
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I9dd86b7171c6ba6a2ad3f77a9c9c448cb2da731f
        Gerrit-Change-Number: 7581956
        Gerrit-PatchSet: 6
        Gerrit-Owner: Asami Doi <asam...@chromium.org>
        Gerrit-Reviewer: Asami Doi <asam...@chromium.org>
        Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
        Gerrit-Reviewer: Sylvain Defresne <sdef...@chromium.org>
        Gerrit-Attention: Asami Doi <asam...@chromium.org>
        Gerrit-Attention: Sylvain Defresne <sdef...@chromium.org>
        Gerrit-Comment-Date: Tue, 24 Feb 2026 19:41:37 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages