[Autofill AI - Reauth] Log reauth on filling metrics [chromium/src : main]

0 views
Skip to first unread message

Jan Keitel (Gerrit)

unread,
Jan 19, 2026, 3:36:18 AM (2 days ago) Jan 19
to Bruno Braga, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Attention needed from Bruno Braga

Jan Keitel added 4 comments

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Jan Keitel . resolved

LGTM % comments below - but fixing them will cause you to lose the +1 anyway... :/

File chrome/browser/ui/autofill/chrome_autofill_client.h
Line 220, Patchset 1 (Latest): std::unique_ptr<device_reauth::DeviceAuthenticator> GetDeviceAuthenticator(
Jan Keitel . unresolved

Please fix this WARNING reported by ClangTidy: check: google-default-arguments

default arguments on virtual or override method...

check: google-default-arguments

default arguments on virtual or override methods are prohibited (https://clang.llvm.org/extra/clang-tidy/checks/google/default-arguments.html)

(Note: You can add `Skip-Clang-Tidy-Checks: google-default-arguments` footer to the CL description to skip the check)

(Lint observed on `android-clang-tidy-rel`, but not on `linux-clang-tidy-rel`)

File chrome/browser/ui/autofill/chrome_autofill_client.cc
Line 1165, Patchset 1 (Latest): base::Seconds(60), device_reauth::DeviceAuthSource::kAutofill, histogram);
Jan Keitel . unresolved

`std::move(...)`

File components/autofill/core/browser/ui/autofill_external_delegate.cc
Line 1440, Patchset 1 (Latest): const std::string& histogram,
Jan Keitel . unresolved

Please pass a `std::string` and move it into the call below to avoid a copy.

Open in Gerrit

Related details

Attention is currently required from:
  • Bruno Braga
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7afa40787b342a807f58b8ff91559331dd610713
Gerrit-Change-Number: 7484921
Gerrit-PatchSet: 1
Gerrit-Owner: Bruno Braga <bruno...@google.com>
Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
Gerrit-Reviewer: Jan Keitel <jke...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Bruno Braga <bruno...@google.com>
Gerrit-Comment-Date: Mon, 19 Jan 2026 08:36:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Bruno Braga (Gerrit)

unread,
Jan 20, 2026, 8:41:17 AM (yesterday) Jan 20
to Jan Keitel, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
Attention needed from Jan Keitel

Bruno Braga added 3 comments

File chrome/browser/ui/autofill/chrome_autofill_client.h
Line 220, Patchset 1: std::unique_ptr<device_reauth::DeviceAuthenticator> GetDeviceAuthenticator(
Jan Keitel . resolved

Please fix this WARNING reported by ClangTidy: check: google-default-arguments

default arguments on virtual or override method...

check: google-default-arguments

default arguments on virtual or override methods are prohibited (https://clang.llvm.org/extra/clang-tidy/checks/google/default-arguments.html)

(Note: You can add `Skip-Clang-Tidy-Checks: google-default-arguments` footer to the CL description to skip the check)

(Lint observed on `android-clang-tidy-rel`, but not on `linux-clang-tidy-rel`)

Bruno Braga

Done

File chrome/browser/ui/autofill/chrome_autofill_client.cc
Line 1165, Patchset 1: base::Seconds(60), device_reauth::DeviceAuthSource::kAutofill, histogram);
Jan Keitel . resolved

`std::move(...)`

Bruno Braga

Done

File components/autofill/core/browser/ui/autofill_external_delegate.cc
Line 1440, Patchset 1: const std::string& histogram,
Jan Keitel . resolved

Please pass a `std::string` and move it into the call below to avoid a copy.

Bruno Braga

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Jan Keitel
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7afa40787b342a807f58b8ff91559331dd610713
    Gerrit-Change-Number: 7484921
    Gerrit-PatchSet: 4
    Gerrit-Owner: Bruno Braga <bruno...@google.com>
    Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
    Gerrit-Reviewer: Jan Keitel <jke...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Jan Keitel <jke...@google.com>
    Gerrit-Comment-Date: Tue, 20 Jan 2026 13:41:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Jan Keitel <jke...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Jan Keitel (Gerrit)

    unread,
    Jan 20, 2026, 10:29:08 AM (yesterday) Jan 20
    to Bruno Braga, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
    Attention needed from Bruno Braga

    Jan Keitel voted and added 2 comments

    Votes added by Jan Keitel

    Code-Review+1

    2 comments

    File chrome/browser/ui/autofill/chrome_autofill_client.cc
    Line 1165, Patchset 4 (Latest): base::Seconds(60), device_reauth::DeviceAuthSource::kAutofill, histogram);
    Jan Keitel . unresolved

    `std::move(histogram)`

    File ios/chrome/browser/autofill/ui_bundled/chrome_autofill_client_ios.mm
    Line 448, Patchset 4 (Latest): base::Seconds(60), device_reauth::DeviceAuthSource::kAutofill, histogram);
    Jan Keitel . unresolved

    `std::move(histogram)`

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Bruno Braga
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I7afa40787b342a807f58b8ff91559331dd610713
      Gerrit-Change-Number: 7484921
      Gerrit-PatchSet: 4
      Gerrit-Owner: Bruno Braga <bruno...@google.com>
      Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
      Gerrit-Reviewer: Jan Keitel <jke...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-Attention: Bruno Braga <bruno...@google.com>
      Gerrit-Comment-Date: Tue, 20 Jan 2026 15:28:54 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Bruno Braga (Gerrit)

      unread,
      Jan 20, 2026, 10:40:30 AM (yesterday) Jan 20
      to Jan Keitel, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com

      Bruno Braga added 2 comments

      File chrome/browser/ui/autofill/chrome_autofill_client.cc
      Line 1165, Patchset 4: base::Seconds(60), device_reauth::DeviceAuthSource::kAutofill, histogram);
      Jan Keitel . resolved

      `std::move(histogram)`

      Bruno Braga

      Done

      File ios/chrome/browser/autofill/ui_bundled/chrome_autofill_client_ios.mm
      Line 448, Patchset 4: base::Seconds(60), device_reauth::DeviceAuthSource::kAutofill, histogram);
      Jan Keitel . resolved

      `std::move(histogram)`

      Bruno Braga

      Done

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I7afa40787b342a807f58b8ff91559331dd610713
        Gerrit-Change-Number: 7484921
        Gerrit-PatchSet: 5
        Gerrit-Owner: Bruno Braga <bruno...@google.com>
        Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
        Gerrit-Reviewer: Jan Keitel <jke...@google.com>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-Comment-Date: Tue, 20 Jan 2026 15:40:15 +0000
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Bruno Braga (Gerrit)

        unread,
        Jan 20, 2026, 11:19:26 AM (yesterday) Jan 20
        to Tommy Martino, Jan Keitel, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
        Attention needed from Tommy Martino

        Bruno Braga voted Auto-Submit+1

        Auto-Submit+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Tommy Martino
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I7afa40787b342a807f58b8ff91559331dd610713
        Gerrit-Change-Number: 7484921
        Gerrit-PatchSet: 5
        Gerrit-Owner: Bruno Braga <bruno...@google.com>
        Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
        Gerrit-Reviewer: Jan Keitel <jke...@google.com>
        Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-Attention: Tommy Martino <tmar...@chromium.org>
        Gerrit-Comment-Date: Tue, 20 Jan 2026 16:19:11 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Tommy Martino (Gerrit)

        unread,
        10:08 AM (3 hours ago) 10:08 AM
        to Bruno Braga, Jan Keitel, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com
        Attention needed from Bruno Braga

        Tommy Martino voted

        Code-Review+1
        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Bruno Braga
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I7afa40787b342a807f58b8ff91559331dd610713
        Gerrit-Change-Number: 7484921
        Gerrit-PatchSet: 5
        Gerrit-Owner: Bruno Braga <bruno...@google.com>
        Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
        Gerrit-Reviewer: Jan Keitel <jke...@google.com>
        Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-Attention: Bruno Braga <bruno...@google.com>
        Gerrit-Comment-Date: Wed, 21 Jan 2026 15:08:01 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        11:17 AM (2 hours ago) 11:17 AM
        to Bruno Braga, Tommy Martino, Jan Keitel, Chromium Metrics Reviews, chromium...@chromium.org, armalhotra+a...@google.com, asvitkine...@chromium.org, browser-comp...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, osaul+aut...@google.com, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, tmartino+tran...@chromium.org, vinnypersky+...@google.com

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        [Autofill AI - Reauth] Log reauth on filling metrics

        This change involves:

        1. Updating the GetDeviceAuthenticator method to receive an optional
        histogram string that is passed on the the instance of the device
        authenticator.

        2. Use this new parameter during the filling moment.
        Bug: 468236777
        Change-Id: I7afa40787b342a807f58b8ff91559331dd610713
        Reviewed-by: Jan Keitel <jke...@google.com>
        Auto-Submit: Bruno Braga <bruno...@google.com>
        Commit-Queue: Tommy Martino <tmar...@chromium.org>
        Reviewed-by: Tommy Martino <tmar...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1572347}
        Files:
        • M chrome/browser/ui/autofill/chrome_autofill_client.cc
        • M chrome/browser/ui/autofill/chrome_autofill_client.h
        • M components/autofill/core/browser/foundations/autofill_client.cc
        • M components/autofill/core/browser/foundations/autofill_client.h
        • M components/autofill/core/browser/foundations/test_autofill_client.h
        • M components/autofill/core/browser/ui/autofill_external_delegate.cc
        • M components/autofill/core/browser/ui/autofill_external_delegate.h
        • M components/autofill/core/browser/ui/autofill_external_delegate_unittest.cc
        • M ios/chrome/browser/autofill/ui_bundled/chrome_autofill_client_ios.h
        • M ios/chrome/browser/autofill/ui_bundled/chrome_autofill_client_ios.mm
        • M tools/metrics/histograms/metadata/autofill/histograms.xml
        Change size: M
        Delta: 11 files changed, 52 insertions(+), 18 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Jan Keitel, +1 by Tommy Martino
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I7afa40787b342a807f58b8ff91559331dd610713
        Gerrit-Change-Number: 7484921
        Gerrit-PatchSet: 6
        Gerrit-Owner: Bruno Braga <bruno...@google.com>
        Gerrit-Reviewer: Bruno Braga <bruno...@google.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Jan Keitel <jke...@google.com>
        Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages