[iOS] Increase the width of the guided tour promo title [chromium/src : main]
0 views
Skip to first unread message
Robbie Gibson (Gerrit)
Apr 1, 2026, 5:34:13 PM (4 days ago) Apr 1
to Guillaume Jenkins, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Guillaume Jenkins
Robbie Gibson voted and added 1 comment![]( "Open in Gerrit")
Votes added by Robbie Gibson
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Guillaume Jenkins
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Guillaume Jenkins (Gerrit)
Apr 2, 2026, 9:54:23 AM (3 days ago) Apr 2
to Robbie Gibson, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Robbie Gibson
Guillaume Jenkins voted![]( "Open in Gerrit")
Attention is currently required from:
- Robbie Gibson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robbie Gibson (Gerrit)
Apr 2, 2026, 8:20:36 PM (3 days ago) Apr 2
to Jérôme Lebel, Guillaume Jenkins, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Guillaume Jenkins and Jérôme Lebel
Robbie Gibson added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Guillaume Jenkins
- Jérôme Lebel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jérôme Lebel (Gerrit)
Apr 3, 2026, 5:25:05 AM (2 days ago) Apr 3
to Robbie Gibson, Guillaume Jenkins, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Guillaume Jenkins and Robbie Gibson
Jérôme Lebel voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Guillaume Jenkins
- Robbie Gibson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robbie Gibson (Gerrit)
Apr 3, 2026, 2:25:12 PM (2 days ago) Apr 3
to Jérôme Lebel, Guillaume Jenkins, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Attention needed from Guillaume Jenkins
Robbie Gibson voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Guillaume Jenkins
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 3, 2026, 3:27:04 PM (2 days ago) Apr 3
to Robbie Gibson, Jérôme Lebel, Guillaume Jenkins, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[iOS] Increase the width of the guided tour promo title
Increasing the allowed width of the title allows it to stay on one line
for as many environments as possible, which keeps the promo from having
to scroll for as many environments as possible.
Fixed: b:498700918
Change-Id: Ieef640d133c93f00439664e5ad34f583f0155fbb
Commit-Queue: Robbie Gibson <rkgi...@google.com>
Reviewed-by: Jérôme Lebel <jle...@chromium.org>
Auto-Submit: Robbie Gibson <rkgi...@google.com>
Reviewed-by: Guillaume Jenkins <gu...@google.com>
Cr-Commit-Position: refs/heads/main@{#1609903}
Files:
- M ios/chrome/browser/first_run/guided_tour/ui/guided_tour_promo_view_controller.mm
Change size: XS
Delta: 1 file changed, 3 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Guillaume Jenkins, +1 by Jérôme Lebel
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages