[iOS] Swift compiler to use absolute path to SDK [chromium/src : main]
0 views
Skip to first unread message
Sylvain Defresne (Gerrit)
11:52 AM (5 hours ago) 11:52 AM
to Justin Novosad, Rohit Rao, Chromium LUCI CQ, chromium...@chromium.org, ios-r...@chromium.org
Attention needed from Justin Novosad and Rohit Rao
Sylvain Defresne added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Sylvain Defresne . resolved
Please ask someone working on siso to review this.
I was explicitly asked to not use absolute path in any command-line in the generated ninja files. I think this request to not use absolute path (even for commands that are only run locally) still holds.
Related details
Attention is currently required from:
- Justin Novosad
- Rohit Rao
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sylvain Defresne (Gerrit)
11:53 AM (5 hours ago) 11:53 AM
to Justin Novosad, Rohit Rao, Chromium LUCI CQ, chromium...@chromium.org, ios-r...@chromium.org
Attention needed from Justin Novosad and Rohit Rao
Sylvain Defresne added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Sylvain Defresne . resolved
If we still need to use relative paths, you can change `swiftc.py` to check whether any component in `-sdk` path is a symlink and to resolve it at run time.
Reply all
Reply to author
Forward
0 new messages