[iOS][AIM] Add canvas option in the composebox input plate [chromium/src : main]

0 views

Skip to first unread message

Radu Nitescu (Gerrit)

unread,

9:41 AM (3 hours ago) 9:41 AM

to Christian Xu, Ewann Pellé, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org

Attention needed from Christian Xu and Ewann Pellé

Radu Nitescu voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu
Ewann Pellé

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Ewann Pellé (Gerrit)

unread,

10:52 AM (2 hours ago) 10:52 AM

to Radu Nitescu, Chromium LUCI CQ, Christian Xu, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org

Attention needed from Christian Xu and Radu Nitescu

Ewann Pellé added 6 comments

File ios/chrome/app/strings/ios_strings.grd

Line 1455, Patchset 5 (Latest):

      <message name="IDS_IOS_COMPOSEBOX_CANVAS_ACTION" desc="The contextual menu option for opening the tool where users can dynamically build and edit content with the help of AI. [iOS only]..">

Ewann Pellé . unresolved

```suggestion
      <message name="IDS_IOS_COMPOSEBOX_CANVAS_ACTION" desc="The contextual menu option for opening the tool where users can dynamically build and edit content with the help of AI. [iOS only].">
```

File ios/chrome/browser/composebox/coordinator/composebox_constants.h

Line 12, Patchset 5 (Latest):

  kRegularSearch,
  kAIM,
  kImageGeneration,
  kCanvas,

Ewann Pellé . unresolved

Nit: It would be helpful to add a brief comment for each enum value to clarify their specific use cases.

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm

Line 476, Patchset 5 (Latest): [self.consumer setAIModeEnabled:mode == ComposeboxMode::kAIM];

Ewann Pellé . unresolved

duplicate?

Line 1210, Patchset 5 (Latest):- (BOOL)isEligibleToCanvas {

Ewann Pellé . unresolved

Private methods should have a comment. Same for some methods below.

Line 1257, Patchset 5 (Latest): _isMultiline || _modeHolder.mode != ComposeboxMode::kRegularSearch;

Ewann Pellé . unresolved

optional nit: Adding new values to the ComposeboxMode enum may require an update to this flow. Maybe having a switch could solve this issue.

File ios/chrome/browser/composebox/ui/composebox_input_plate_view_controller.mm

Line 1719, Patchset 5 (Latest):- (UIButton*)createCanvasButton {

Ewann Pellé . unresolved

optional nit: It seems like a lot of private methods are also missing a comment in this file.

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu
Radu Nitescu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages