Implement save logic for scan card bottom sheet suggestion [chromium/src : main]

0 views
Skip to first unread message

Olivia Saul (Gerrit)

unread,
Apr 2, 2026, 7:06:16 PM (3 days ago) Apr 2
to Qihui Zhao, Olivia Saul, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Qihui Zhao

Olivia Saul added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Olivia Saul . resolved

Hey Rebecca, I definitely don't have the expertise to help with this CL, I think. I don't have enough familiarity with Objective-C or iOS patterns, and this starts to get beyond my ability.

Can you please replace me with Yiwen for iOS-heavy CLs like these? When Siyu gets back then Shiva says perhaps we can try him as well, but for now I think Yiwen will give you a better review than me.

Thank you!

Open in Gerrit

Related details

Attention is currently required from:
  • Qihui Zhao
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I25ebc2f538cc57e005122ee6b61f4ff0e2d7593d
Gerrit-Change-Number: 7711182
Gerrit-PatchSet: 4
Gerrit-Owner: Qihui Zhao <qihu...@google.com>
Gerrit-Reviewer: Olivia Saul <os...@google.com>
Gerrit-Reviewer: Qihui Zhao <qihu...@google.com>
Gerrit-Attention: Qihui Zhao <qihu...@google.com>
Gerrit-Comment-Date: Thu, 02 Apr 2026 23:06:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

yiwen qian (Gerrit)

unread,
Apr 3, 2026, 5:05:31 PM (2 days ago) Apr 3
to Qihui Zhao, Olivia Saul, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Qihui Zhao

yiwen qian added 2 comments

Patchset-level comments
yiwen qian . resolved

LGTM

File ios/chrome/browser/autofill/scan_save_and_fill/coordinator/payments_scan_save_and_fill_offer_bottom_sheet_mediator.mm
Line 69, Patchset 4 (Latest): autofill::Suggestion::Guid(
base::SysNSStringToUTF8(@"")))
yiwen qian . unresolved

Does autofill::Suggestion::Guid("") work?

Open in Gerrit

Related details

Attention is currently required from:
  • Qihui Zhao
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I25ebc2f538cc57e005122ee6b61f4ff0e2d7593d
    Gerrit-Change-Number: 7711182
    Gerrit-PatchSet: 4
    Gerrit-Owner: Qihui Zhao <qihu...@google.com>
    Gerrit-Reviewer: Olivia Saul <os...@google.com>
    Gerrit-Reviewer: Qihui Zhao <qihu...@google.com>
    Gerrit-Reviewer: yiwen qian <yiwe...@chromium.org>
    Gerrit-Attention: Qihui Zhao <qihu...@google.com>
    Gerrit-Comment-Date: Fri, 03 Apr 2026 21:05:20 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Qihui Zhao (Gerrit)

    unread,
    Apr 3, 2026, 7:17:25 PM (2 days ago) Apr 3
    to Tommy Martino, yiwen qian, Olivia Saul, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, tmartino+tran...@chromium.org
    Attention needed from Tommy Martino and yiwen qian

    Qihui Zhao added 2 comments

    Patchset-level comments
    File-level comment, Patchset 4:
    Qihui Zhao . resolved

    Hi Tommy, please review, thanks!

    File ios/chrome/browser/autofill/scan_save_and_fill/coordinator/payments_scan_save_and_fill_offer_bottom_sheet_mediator.mm
    Line 69, Patchset 4: autofill::Suggestion::Guid(
    base::SysNSStringToUTF8(@"")))
    yiwen qian . resolved

    Does autofill::Suggestion::Guid("") work?

    Qihui Zhao

    Done, thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tommy Martino
    • yiwen qian
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I25ebc2f538cc57e005122ee6b61f4ff0e2d7593d
      Gerrit-Change-Number: 7711182
      Gerrit-PatchSet: 4
      Gerrit-Owner: Qihui Zhao <qihu...@google.com>
      Gerrit-Reviewer: Olivia Saul <os...@google.com>
      Gerrit-Reviewer: Qihui Zhao <qihu...@google.com>
      Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
      Gerrit-Reviewer: yiwen qian <yiwe...@chromium.org>
      Gerrit-Attention: yiwen qian <yiwe...@chromium.org>
      Gerrit-Attention: Tommy Martino <tmar...@chromium.org>
      Gerrit-Comment-Date: Fri, 03 Apr 2026 23:17:16 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: yiwen qian <yiwe...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages