Christian Xu (Gerrit)

unread,

Feb 11, 2026, 4:50:38 AM (13 days ago) Feb 11

to Chris Lu, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Chris Lu

Christian Xu added 2 comments

Commit Message

Line 16, Patchset 3 (Latest):Fixed: 481648910

Christian Xu . unresolved

How do you repro this bug on Canary ? When I add a long query it resizes and scrolls as expected.

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm

Line 1966, Patchset 3 (Latest): [self commitUIUpdates];

Christian Xu . unresolved

The UI is already updated in commitUIUpdates, why do we need to force a layout after ?

Open in Gerrit

Related details

Attention is currently required from:

Chris Lu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Chris Lu (Gerrit)

unread,

Feb 11, 2026, 10:54:48 AM (13 days ago) Feb 11

to Christian Xu, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Christian Xu

Chris Lu added 1 comment

Commit Message

Line 16, Patchset 3 (Latest):Fixed: 481648910

Christian Xu . unresolved

How do you repro this bug on Canary ? When I add a long query it resizes and scrolls as expected.

Chris Lu

Did you have a tab input context? That is the only way I can repro.

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Chris Lu (Gerrit)

unread,

Feb 11, 2026, 10:56:09 AM (13 days ago) Feb 11

to Christian Xu, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Christian Xu

Chris Lu added 1 comment

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm

Line 1966, Patchset 3 (Latest): [self commitUIUpdates];

Christian Xu . unresolved

The UI is already updated in commitUIUpdates, why do we need to force a layout after ?

Chris Lu

because we need to update preferredContentSize. In this bug instance, nothing in commitUIUpdates triggers anything because it is just the text field changing, nothing else.

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Chris Lu (Gerrit)

unread,

Feb 12, 2026, 5:10:48 PM (12 days ago) Feb 12

to Radu Nitescu, Christian Xu, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Radu Nitescu

Chris Lu added 1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Chris Lu . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:

Radu Nitescu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Radu Nitescu (Gerrit)

unread,

Feb 23, 2026, 6:57:42 AM (yesterday) Feb 23

to Chris Lu, Code Review Nudger, Christian Xu, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Chris Lu

Radu Nitescu added 1 comment

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm

Line 2274, Patchset 4 (Latest): [self.consumer updatePreferredContentSizeForNewTextFieldHeight];

Radu Nitescu . unresolved

What if you instead override the preferredContentSize to be a computed property instead

```
- (CGSize)preferredContentSize {
  CGFloat inputHeight = [self inputHeight];
  return CGSizeMake(self.view.bounds.size.width, inputHeight);
}
```

Open in Gerrit

Related details

Attention is currently required from:

Chris Lu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Chris Lu (Gerrit)

unread,

Feb 23, 2026, 11:44:35 AM (yesterday) Feb 23

to Code Review Nudger, Radu Nitescu, Christian Xu, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Christian Xu and Radu Nitescu

Chris Lu voted and added 2 comments

Votes added by Chris Lu

Auto-Submit

+1

2 comments

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm

Line 1966, Patchset 3: [self commitUIUpdates];

Christian Xu . resolved

The UI is already updated in commitUIUpdates, why do we need to force a layout after ?

Chris Lu

because we need to update preferredContentSize. In this bug instance, nothing in commitUIUpdates triggers anything because it is just the text field changing, nothing else.

Chris Lu

Acknowledged

Line 2274, Patchset 4 (Latest): [self.consumer updatePreferredContentSizeForNewTextFieldHeight];

Radu Nitescu . unresolved

What if you instead override the preferredContentSize to be a computed property instead
```
- (CGSize)preferredContentSize {
  CGFloat inputHeight = [self inputHeight];
  return CGSizeMake(self.view.bounds.size.width, inputHeight);
}
```

Chris Lu

That doesn't solve anything here. We need to actually trigger a recalculation by ComposeboxViewController, which is done by triggering a relayout.

Open in Gerrit

Related details

Attention is currently required from:

Christian Xu
Radu Nitescu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Christian Xu (Gerrit)

unread,

Feb 23, 2026, 12:09:27 PM (yesterday) Feb 23

to Chris Lu, Code Review Nudger, Radu Nitescu, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Chris Lu and Radu Nitescu

Christian Xu voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

Chris Lu
Radu Nitescu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Radu Nitescu (Gerrit)

unread,

4:13 AM (12 hours ago) 4:13 AM

to Chris Lu, Christian Xu, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Chris Lu

Radu Nitescu voted and added 1 comment

Votes added by Radu Nitescu

Code-Review

+1

1 comment

File ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm

Line 2274, Patchset 4 (Latest): [self.consumer updatePreferredContentSizeForNewTextFieldHeight];

Radu Nitescu . resolved

What if you instead override the preferredContentSize to be a computed property instead
```
- (CGSize)preferredContentSize {
  CGFloat inputHeight = [self inputHeight];
  return CGSizeMake(self.view.bounds.size.width, inputHeight);
}
```

Chris Lu

That doesn't solve anything here. We need to actually trigger a recalculation by ComposeboxViewController, which is done by triggering a relayout.

Radu Nitescu

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

Chris Lu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Chris Lu (Gerrit)

unread,

11:51 AM (5 hours ago) 11:51 AM

to Radu Nitescu, Christian Xu, Code Review Nudger, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Chris Lu voted and added 1 comment

Votes added by Chris Lu

Commit-Queue

+2

1 comment

Commit Message

Line 16, Patchset 3:Fixed: 481648910

Christian Xu . resolved

How do you repro this bug on Canary ? When I add a long query it resizes and scrolls as expected.

Chris Lu

Did you have a tab input context? That is the only way I can repro.

Chris Lu

Acknowledged

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

12:51 PM (4 hours ago) 12:51 PM

to Chris Lu, Radu Nitescu, Christian Xu, Code Review Nudger, chromium...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[ios] Force layout when composebox text field height changes

There is currently no signal that forces a recalculation of the
preferredContentSize. Calling layoutIfNeeded ensures the updated
text field height is factored in.

Setting the composebox input items should also require a recalculation
since it adds height to ComposeboxInputPlateViewController.

Fixed: 481648910

Change-Id: I9a817457f7800a86a5e2400e6657ecb589c38f43

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7564773

Auto-Submit: Chris Lu <thegre...@chromium.org>

Reviewed-by: Christian Xu <chris...@chromium.org>

Reviewed-by: Radu Nitescu <radun...@google.com>

Commit-Queue: Chris Lu <thegre...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1589501}

Files:

M ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator.mm
M ios/chrome/browser/composebox/coordinator/composebox_input_plate_mediator_unittest.mm
M ios/chrome/browser/composebox/ui/composebox_input_plate_consumer.h
M ios/chrome/browser/composebox/ui/composebox_input_plate_view_controller.mm

Change size: S

Delta: 4 files changed, 13 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Christian Xu, +1 by Radu Nitescu

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[ios] Force layout when composebox text field height changes [chromium/src : main]

Christian Xu (Gerrit)

Christian Xu added 2 comments

Related details

Chris Lu (Gerrit)

Chris Lu added 1 comment

Related details

Chris Lu (Gerrit)

Chris Lu added 1 comment

Related details

Chris Lu (Gerrit)

Chris Lu added 1 comment

Related details

Radu Nitescu (Gerrit)

Radu Nitescu added 1 comment

Related details

Chris Lu (Gerrit)

Chris Lu voted and added 2 comments

Votes added by Chris Lu

2 comments

Related details

Christian Xu (Gerrit)

Christian Xu voted Code-Review+1

Related details

Radu Nitescu (Gerrit)

Radu Nitescu voted and added 1 comment

Votes added by Radu Nitescu

1 comment

Related details

Chris Lu (Gerrit)

Chris Lu voted and added 1 comment

Votes added by Chris Lu

1 comment

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information