Briana McClure (Gerrit)

unread,

Feb 23, 2026, 10:21:05 AM (yesterday) Feb 23

to Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Briana McClure voted Commit-Queue+1

Commit-Queue

+1

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Briana McClure (Gerrit)

unread,

Feb 23, 2026, 1:42:52 PM (yesterday) Feb 23

to Benjamin Williams, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Benjamin Williams

Briana McClure added 1 comment

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Briana McClure . resolved

Hey Ben, PTAL at this change to enable the DB Magic Stack card by default.

Open in Gerrit

Related details

Attention is currently required from:

Benjamin Williams

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Benjamin Williams (Gerrit)

unread,

Feb 23, 2026, 3:01:19 PM (yesterday) Feb 23

to Briana McClure, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Briana McClure

Benjamin Williams voted and added 2 comments

Votes added by Benjamin Williams

Code-Review

+1

2 comments

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Benjamin Williams . resolved

LGTM w/ one nit

File ios/chrome/browser/content_suggestions/magic_stack/coordinator/magic_stack_ranking_model.mm

Line 647, Patchset 13 (Latest):

      inputContext->metadata_args.emplace(
          segmentation_platform::kIsDefaultBrowserChromeIos,
          segmentation_platform::processing::ProcessedValue::FromFloat(
              IsChromeLikelyDefaultBrowser()));

Benjamin Williams . unresolved

Should this be reformatted (looks like indentation is a bit off)?

Open in Gerrit

Related details

Attention is currently required from:

Briana McClure

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Briana McClure (Gerrit)

unread,

Feb 23, 2026, 3:59:45 PM (yesterday) Feb 23

to Hailey Wang, Benjamin Williams, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Hailey Wang

Briana McClure added 2 comments

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Briana McClure . resolved

Hi Hailey, PTAL at i/c/b/segmentation_platform and components/segmentation_platform. Thanks!

File ios/chrome/browser/content_suggestions/magic_stack/coordinator/magic_stack_ranking_model.mm

Line 647, Patchset 13: inputContext->metadata_args.emplace(


          segmentation_platform::kIsDefaultBrowserChromeIos,
          segmentation_platform::processing::ProcessedValue::FromFloat(
              IsChromeLikelyDefaultBrowser()));

Benjamin Williams . resolved

Should this be reformatted (looks like indentation is a bit off)?

Briana McClure

Done

Open in Gerrit

Related details

Attention is currently required from:

Hailey Wang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Hailey Wang (Gerrit)

unread,

Feb 23, 2026, 4:59:35 PM (yesterday) Feb 23

to Briana McClure, Benjamin Williams, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Briana McClure

Hailey Wang voted and added 1 comment

Votes added by Hailey Wang

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 14 (Latest):

Hailey Wang . resolved

segmentation_platform/* LGTM thanks!

Open in Gerrit

Related details

Attention is currently required from:

Briana McClure

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Briana McClure (Gerrit)

unread,

10:06 AM (8 hours ago) 10:06 AM

to Hailey Wang, Benjamin Williams, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Briana McClure voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Briana McClure (Gerrit)

unread,

1:39 PM (4 hours ago) 1:39 PM

to Hailey Wang, Benjamin Williams, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Briana McClure voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

2:52 PM (3 hours ago) 2:52 PM

to Briana McClure, Hailey Wang, Benjamin Williams, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

14 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: ios/chrome/browser/content_suggestions/coordinator/content_suggestions_coordinator.mm
Insertions: 6, Deletions: 0.

The diff is too large to show. Please review the diff.
```

Change information

Commit message:

[iOS] Enable the Default Browser Magic Stack card by default

This change enables kDefaultBrowserMagicStackIos by default on iOS. The
feature variations are also removed.

Bug: 485209157

Change-Id: I1b19d2b9a1b8119ab5f470661abeef3cf976e285

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7588179

Reviewed-by: Hailey Wang <haile...@google.com>

Commit-Queue: Briana McClure <bmcc...@google.com>

Reviewed-by: Benjamin Williams <bwwil...@google.com>

Cr-Commit-Position: refs/heads/main@{#1589604}

Files:

M components/segmentation_platform/embedder/home_modules/home_modules_card_registry_unittest.cc
M components/segmentation_platform/public/features.cc
M components/segmentation_platform/public/features.h
M ios/chrome/browser/content_suggestions/coordinator/BUILD.gn
M ios/chrome/browser/content_suggestions/coordinator/content_suggestions_coordinator.mm
M ios/chrome/browser/content_suggestions/default_browser/coordinator/BUILD.gn
D ios/chrome/browser/content_suggestions/default_browser/public/BUILD.gn
D ios/chrome/browser/content_suggestions/default_browser/public/features.h
D ios/chrome/browser/content_suggestions/default_browser/public/features.mm
M ios/chrome/browser/content_suggestions/magic_stack/coordinator/BUILD.gn
M ios/chrome/browser/content_suggestions/magic_stack/coordinator/magic_stack_ranking_model.mm
M ios/chrome/browser/flags/BUILD.gn
M ios/chrome/browser/flags/about_flags.mm
M ios/chrome/browser/flags/ios_chrome_flag_descriptions.cc
M ios/chrome/browser/flags/ios_chrome_flag_descriptions.h
M ios/chrome/browser/segmentation_platform/model/segmentation_platform_service_factory_unittest.mm
M testing/variations/fieldtrial_testing_config.json

Change size: M

Delta: 17 files changed, 39 insertions(+), 187 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Benjamin Williams, +1 by Hailey Wang

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[iOS] Enable the Default Browser Magic Stack card by default [chromium/src : main]

Briana McClure (Gerrit)

Briana McClure voted Commit-Queue+1

Related details

Briana McClure (Gerrit)

Briana McClure added 1 comment

Related details

Benjamin Williams (Gerrit)

Benjamin Williams voted and added 2 comments

Votes added by Benjamin Williams

2 comments

Related details

Briana McClure (Gerrit)

Briana McClure added 2 comments

Related details

Hailey Wang (Gerrit)

Hailey Wang voted and added 1 comment

Votes added by Hailey Wang

1 comment

Related details

Briana McClure (Gerrit)

Briana McClure voted Commit-Queue+2

Related details

Briana McClure (Gerrit)

Briana McClure voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information