[iOS] Add regression test for instantiation of InfobarBadgeTabHelper. [chromium/src : main]

0 views

Skip to first unread message

Sylvain Defresne (Gerrit)

unread,

10:02 AM (3 hours ago) 10:02 AM

to Nohemi Fernandez, Ginny Huang, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Attention needed from Nohemi Fernandez

Sylvain Defresne voted and added 1 comment

Votes added by Sylvain Defresne

Code-Review

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Sylvain Defresne . resolved

lgtm

Thank you.

Open in Gerrit

Related details

Attention is currently required from:

Nohemi Fernandez

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Nohemi Fernandez (Gerrit)

unread,

10:18 AM (3 hours ago) 10:18 AM

to Sylvain Defresne, Ginny Huang, Chromium LUCI CQ, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Nohemi Fernandez voted Commit-Queue+2

Commit-Queue

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

10:21 AM (3 hours ago) 10:21 AM

to Nohemi Fernandez, Sylvain Defresne, Ginny Huang, chromium...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[iOS] Add regression test for instantiation of InfobarBadgeTabHelper.

Bug: 465908300

Change-Id: I106b68bafffa3644ae6a82adfb590034dd2d482f

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7493870

Reviewed-by: Sylvain Defresne <sdef...@chromium.org>

Commit-Queue: Nohemi Fernandez <fern...@google.com>

Cr-Commit-Position: refs/heads/main@{#1572303}

Files:

M ios/chrome/browser/tabs/model/BUILD.gn
M ios/chrome/browser/tabs/model/tab_helper_util_unittest.mm

Change size: S

Delta: 2 files changed, 27 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Sylvain Defresne

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages